Forbid all inline script tags in Linter::InlineJavaScript

2018-02-28 21:23:58 +00:00 · 2018-02-28 21:23:58 +00:00 · 9d06504d42
parent 891d13022d
commit 9d06504d42
1 changed files with 1 additions and 1 deletions
--- a/lib/haml_lint/inline_javascript.rb
+++ b/lib/haml_lint/inline_javascript.rb
@ -8,7 +8,7 @@ unless Rails.env.production?
      include LinterRegistry

      def visit_filter(node)
-        return unless node.filter_type == 'javascript'
+        return unless node.tag_name == 'script'

        record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)')
      end