kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Change docs to recommend perform_enqueued_jobs 

- Instead of Sidekiq::Testing.inline!, recommend the use of
perform_enqueued_jobs. This is due to the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20768
This commit is contained in:
rpereira2 2019-06-19 16:50:00 +05:30
parent 08ed6b1720
commit 9d67a3d17c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/development/testing_guide/best_practices.md
View File

@ -327,7 +327,7 @@ However, if a spec makes direct Redis calls, it should mark itself with the
`:clean_gitlab_redis_queues` traits as appropriate.
Sidekiq jobs are typically not run in specs, but this behaviour can be altered
in each spec through the use of `Sidekiq::Testing.inline!` blocks. Any spec that
in each spec through the use of `perform_enqueued_jobs` blocks. Any spec that
causes Sidekiq jobs to be pushed to Redis should use the `:sidekiq` trait, to
ensure that they are removed once the spec completes.