kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

specify that webpack entry points are exempt from unit tests, not integration tests

This commit is contained in:
Mike Greiling 2018-03-12 17:51:01 -05:00
parent d92baff68f
commit 9f9257fa5a
No known key found for this signature in database
GPG Key ID: 0303DF507FA67596
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/development/fe_guide/performance.md
View File

@ -87,10 +87,10 @@ In addition to these page-specific bundles, the code within `main.js` and
- **Keep Entry Points Lite:**
Page-specific javascript entry points should be as lite as possible. These
files are exempt from tests, and should be used primarily for instantiation
and dependency injection of classes and methods that live in modules outside
of the entry point script. Just import, read the DOM, instantiate, and
nothing else.
files are exempt from unit tests, and should be used primarily for
instantiation and dependency injection of classes and methods that live in
modules outside of the entry point script. Just import, read the DOM,
instantiate, and nothing else.
- **Entry Points May Be Asynchronous:**
_DO NOT ASSUME_ that the DOM has been fully loaded and available when an