kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix performance bar specs

This commit is contained in:
Sean McGivern 2017-07-07 16:30:50 +01:00
parent c179f507ee
commit 9fc63aa7f6
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
spec/features/user_can_display_performance_bar_spec.rb
View File

@ -33,6 +33,8 @@ describe 'User can display performance bar', :js do
end
end
let(:group) { create(:group) }
context 'when user is logged-out' do
before do
visit root_path
@ -40,7 +42,7 @@ describe 'User can display performance bar', :js do
context 'when the performance_bar feature is disabled' do
before do
Feature.disable(:performance_bar)
stub_application_setting(performance_bar_allowed_group_id: nil)
end
it_behaves_like 'performance bar is disabled'
@ -48,7 +50,7 @@ describe 'User can display performance bar', :js do
context 'when the performance_bar feature is enabled' do
before do
Feature.enable(:performance_bar)
stub_application_setting(performance_bar_allowed_group_id: group.id)
end
it_behaves_like 'performance bar is disabled'
@ -57,14 +59,17 @@ describe 'User can display performance bar', :js do
context 'when user is logged-in' do
before do
gitlab_sign_in(create(:user))
user = create(:user)
gitlab_sign_in(user)
group.add_guest(user)
visit root_path
end
context 'when the performance_bar feature is disabled' do
before do
Feature.disable(:performance_bar)
stub_application_setting(performance_bar_allowed_group_id: nil)
end
it_behaves_like 'performance bar is disabled'
@ -72,7 +77,7 @@ describe 'User can display performance bar', :js do
context 'when the performance_bar feature is enabled' do
before do
Feature.enable(:performance_bar)
stub_application_setting(performance_bar_allowed_group_id: group.id)
end
it_behaves_like 'performance bar is enabled'