Use new partial to render a badge without a link in the builds details. Preventing from having a link to itself.

Adds MR ID to CHANGELOG entry

app/views/admin/runners/show.html.haml

@@ -91,7 +91,7 @@
               %strong ##{build.id}
 
           %td.status
-            = render 'ci/status/badge', status: build.detailed_status(current_user)
+            = render 'ci/status/badge_link', status: build.detailed_status(current_user)
 
           %td.status
             - if project

app/views/ci/status/_badge.html.haml

@@ -1,11 +1,5 @@
 - status = local_assigns.fetch(:status)
-- css_classes = "ci-status ci-#{status.group}"
 
-- if status.has_details?
-  = link_to status.details_path, class: css_classes do
-    = custom_icon(status.icon)
-    = status.text
-- else
-  %span{ class: css_classes }
-    = custom_icon(status.icon)
-    = status.text
+%span{ class: "ci-status ci-#{status.group}" }
+  = custom_icon(status.icon)
+  = status.text

app/views/ci/status/_badge_link.html.haml

@@ -0,0 +1,11 @@
+- status = local_assigns.fetch(:status)
+- css_classes = "ci-status ci-#{status.group}"
+
+- if status.has_details?
+  = link_to status.details_path, class: css_classes do
+    = custom_icon(status.icon)
+    = status.text
+- else
+  %span{ class: css_classes }
+    = custom_icon(status.icon)
+    = status.text

app/views/projects/ci/builds/_build.html.haml

@@ -9,7 +9,7 @@
 
 %tr.build.commit{ class: ('retried' if retried) }
   %td.status
-    = render "ci/status/badge", status: build.detailed_status(current_user)
+    = render "ci/status/badge_link", status: build.detailed_status(current_user)
 
   %td.branch-commit
     - if can?(current_user, :read_build, build)

app/views/projects/ci/pipelines/_pipeline.html.haml

@@ -4,7 +4,7 @@
 
 %tr.commit
   %td.commit-link
-    = render 'ci/status/badge', status: pipeline.detailed_status(current_user)
+    = render 'ci/status/badge_link', status: pipeline.detailed_status(current_user)
 
   %td
     = link_to namespace_project_pipeline_path(pipeline.project.namespace, pipeline.project, pipeline.id) do

app/views/projects/generic_commit_statuses/_generic_commit_status.html.haml

@@ -8,7 +8,7 @@
 
 %tr.generic_commit_status{ class: ('retried' if retried) }
   %td.status
-    = render 'ci/status/badge', status: generic_commit_status.detailed_status(current_user)
+    = render 'ci/status/badge_link', status: generic_commit_status.detailed_status(current_user)
 
   %td.generic_commit_status-link
     - if can?(current_user, :read_commit_status, generic_commit_status) && generic_commit_status.target_url

app/views/projects/pipelines/_info.html.haml

@@ -1,6 +1,6 @@
 .page-content-header
   .header-main-content
-    = render 'ci/status/badge', status: @pipeline.detailed_status(current_user)
+    = render 'ci/status/badge_link', status: @pipeline.detailed_status(current_user)
     %strong Pipeline ##{@commit.pipelines.last.id}
     triggered #{time_ago_with_tooltip(@commit.authored_date)} by
     = author_avatar(@commit, size: 24)

changelogs/unreleased/26947-build-status-self-link.yml

@@ -0,0 +1,4 @@
+---
+title: Add new ci status partial to render a badge without a link
+merge_request:
+author: 8740