kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Actually converted code to following suggestions.

Browse source
This commit is contained in:
Michael Chmielewski 2015-10-28 22:12:22 -04:00
parent 7b62791afc
commit a0d0a01791
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/models/repository.rb
View file

@ -91,12 +91,9 @@ class Repository
# Limited to 1000 commits for now, could be parameterized?
args = %W(git log --pretty=%H --max-count 1000 --grep=#{query})
git_log_results = Gitlab::Popen.popen(args, path_to_repo)
# 1. Get result, which is 1-element array
# 2. Split on lines
# 3. Recreate array, but remove trailing newline characters on each element
git_log_results.first.lines.map{ |l| l.chomp }
git_log_results = Gitlab::Popen.popen(args, path_to_repo).first.lines.map{ |l| l.chomp }
commits = git_log_results.map{ |c| commit(c) }
commits
end
def find_branch(name)

2
spec/models/repository_spec.rb
View file

@ -27,7 +27,7 @@ describe Repository do
end
describe :find_commits_with_matching_log do
subject { repository.find_commits_with_matching_log('submodule') }
subject { repository.find_commits_with_matching_log('submodule').map{ |k| k.id } }
it { is_expected.to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e') }
it { is_expected.to include('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }