kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Unify build policy tests and pipeline policy tests

This commit is contained in:
Lin Jen-Shin 2017-07-18 22:04:22 +08:00
parent 679789ee93
commit a27cf281b1
2 changed files with 32 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spec/policies/ci/build_policy_spec.rb
View File

@ -96,7 +96,7 @@ describe Ci::BuildPolicy, :models do
end
end
describe 'rules for protected branch' do
describe 'rules for protected ref' do
let(:project) { create(:project) }
let(:build) { create(:ci_build, ref: 'some-ref', pipeline: pipeline) }
@ -107,7 +107,7 @@ describe Ci::BuildPolicy, :models do
context 'when no one can push or merge to the branch' do
before do
create(:protected_branch, :no_one_can_push,
name: 'some-ref', project: project)
name: build.ref, project: project)
end
it 'does not include ability to update build' do
@ -118,7 +118,7 @@ describe Ci::BuildPolicy, :models do
context 'when developers can push to the branch' do
before do
create(:protected_branch, :developers_can_merge,
name: 'some-ref', project: project)
name: build.ref, project: project)
end
it 'includes ability to update build' do
@ -129,7 +129,7 @@ describe Ci::BuildPolicy, :models do
context 'when no one can create the tag' do
before do
create(:protected_tag, :no_one_can_create,
name: 'some-ref', project: project)
name: build.ref, project: project)
build.update(tag: true)
end
@ -142,7 +142,7 @@ describe Ci::BuildPolicy, :models do
context 'when no one can create the tag but it is not a tag' do
before do
create(:protected_tag, :no_one_can_create,
name: 'some-ref', project: project)
name: build.ref, project: project)
end
it 'includes ability to update build' do

35
spec/policies/ci/pipeline_policy_spec.rb
View File

@ -9,18 +9,18 @@ describe Ci::PipelinePolicy, :models do
end
describe 'rules' do
describe 'rules for protected branch' do
describe 'rules for protected ref' do
let(:project) { create(:project) }
before do
project.add_developer(user)
create(:protected_branch, branch_policy,
name: pipeline.ref, project: project)
end
context 'when no one can push or merge to the branch' do
let(:branch_policy) { :no_one_can_push }
before do
create(:protected_branch, :no_one_can_push,
name: pipeline.ref, project: project)
end
it 'does not include ability to update pipeline' do
expect(policy).to be_disallowed :update_pipeline
@ -28,15 +28,34 @@ describe Ci::PipelinePolicy, :models do
end
context 'when developers can push to the branch' do
let(:branch_policy) { :developers_can_push }
before do
create(:protected_branch, :developers_can_merge,
name: pipeline.ref, project: project)
end
it 'includes ability to update pipeline' do
expect(policy).to be_allowed :update_pipeline
end
end
context 'when developers can push to the branch' do
let(:branch_policy) { :developers_can_merge }
context 'when no one can create the tag' do
before do
create(:protected_tag, :no_one_can_create,
name: pipeline.ref, project: project)
pipeline.update(tag: true)
end
it 'does not include ability to update pipeline' do
expect(policy).to be_disallowed :update_pipeline
end
end
context 'when no one can create the tag but it is not a tag' do
before do
create(:protected_tag, :no_one_can_create,
name: pipeline.ref, project: project)
end
it 'includes ability to update pipeline' do
expect(policy).to be_allowed :update_pipeline