kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Extend N+1 Builds and Jobs API specs

Browse source
This commit is contained in:
Matija Čupić 2018-01-15 17:58:56 +01:00
parent 87cc03736c
commit a4d7f155bf
No known key found for this signature in database
GPG key ID: 4BAF84FFACD2E5DE
2 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
spec/requests/api/jobs_spec.rb
View file

@ -54,8 +54,19 @@ describe API::Jobs do
end end
it 'avoids N+1 queries', skip_before_request: true do it 'avoids N+1 queries', skip_before_request: true do
first_build = create(:ci_build, :artifacts, pipeline: pipeline)
first_build.runner = create(:ci_runner)
first_build.user = create(:user)
first_build.save
control_count = ActiveRecord::QueryRecorder.new { go }.count control_count = ActiveRecord::QueryRecorder.new { go }.count
create_list(:ci_build, 5, pipeline: pipeline)
second_pipeline = create(:ci_empty_pipeline, project: project, sha: project.commit.id, ref: project.default_branch)
second_build = create(:ci_build, :artifacts, pipeline: second_pipeline)
second_build.runner = create(:ci_runner)
second_build.user = create(:user)
second_build.save
expect { go }.not_to exceed_query_limit(control_count) expect { go }.not_to exceed_query_limit(control_count)
end end

13
spec/requests/api/v3/builds_spec.rb
View file

@ -43,8 +43,19 @@ describe API::V3::Builds do
end end
it 'avoids N+1 queries', skip_before_request: true do it 'avoids N+1 queries', skip_before_request: true do
first_build = create(:ci_build, :artifacts, pipeline: pipeline)
first_build.runner = create(:ci_runner)
first_build.user = create(:user)
first_build.save
control_count = ActiveRecord::QueryRecorder.new { go }.count control_count = ActiveRecord::QueryRecorder.new { go }.count
create_list(:ci_build, 5, pipeline: pipeline)
second_pipeline = create(:ci_empty_pipeline, project: project, sha: project.commit.id, ref: project.default_branch)
second_build = create(:ci_build, :artifacts, pipeline: second_pipeline)
second_build.runner = create(:ci_runner)
second_build.user = create(:user)
second_build.save
expect { go }.not_to exceed_query_limit(control_count) expect { go }.not_to exceed_query_limit(control_count)
end end