From a4f73241708a777117637d7671584bd255638768 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Thu, 17 Jan 2019 18:53:09 +0100 Subject: [PATCH] [Review Apps] Don't exit when dependable job fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The function that retrieves the dependable job is pretty basic and retrieves the first job found with the matching name, but this job can be failed but then successfully retried. In that case, we would exit the depending job even though the dependable job actually succeeded (the second time). Let's simplify things, be optimistic and continue with the depending job even if the dependable job fails. That reverts to the original behavior. Signed-off-by: Rémy Coutable --- scripts/review_apps/review-apps.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh index 4e1dbff7b80..1ee6f502b8e 100755 --- a/scripts/review_apps/review-apps.sh +++ b/scripts/review_apps/review-apps.sh @@ -346,7 +346,6 @@ function wait_for_job_to_be_done() { if [[ "${job_status}" == "failed" ]]; then echo "The '${job_name}' failed." - exit 1 elif [[ "${job_status}" == "manual" ]]; then echo "The '${job_name}' is manual." else