update all records at once using `update_all`

2017-07-25 21:14:14 +02:00 · 2017-07-25 21:14:14 +02:00 · a5f04df8d7
parent 843b1de0de
commit a5f04df8d7
1 changed files with 5 additions and 6 deletions
--- a/app/models/gpg_key.rb
+++ b/app/models/gpg_key.rb
@ -77,12 +77,11 @@ class GpgKey < ActiveRecord::Base
  end

  def revoke
-    GpgSignature.where(gpg_key: self, valid_signature: true).find_each do |gpg_signature|
-      gpg_signature.update_attributes!(
-        gpg_key: nil,
-        valid_signature: false
-      )
-    end
+    GpgSignature.where(gpg_key: self, valid_signature: true).update_all(
+      gpg_key_id: nil,
+      valid_signature: false,
+      updated_at: Time.zone.now
+    )

    destroy
  end