kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use Ci instead of CI. 

Use kebab case instead of camelCase in templates props
This commit is contained in:
Filipa Lacerda 2017-03-23 20:14:09 +00:00
parent cfe2e6b7a3
commit a5f17beb43
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/vue_pipelines_index/components/nav_controls.js
View File

@ -5,7 +5,7 @@ export default {
required: true, required: true,
}, },
hasCIEnabled: { hasCiEnabled: {
type: Boolean, type: Boolean,
required: true, required: true,
}, },
@ -36,7 +36,7 @@ export default {
</a> </a>
<a <a
v-if="!hasCIEnabled" v-if="!hasCiEnabled"
:href="helpPagePath" :href="helpPagePath"
class="btn btn-info"> class="btn btn-info">
Get started with Pipelines Get started with Pipelines

10
app/assets/javascripts/vue_pipelines_index/pipelines.js
View File

@ -106,7 +106,7 @@ export default {
this.state.pageInfo.total > this.state.pageInfo.perPage; this.state.pageInfo.total > this.state.pageInfo.perPage;
}, },
hasCIEnabled() { hasCiEnabled() {
return this.hasCi !== undefined; return this.hasCi !== undefined;
}, },
@ -190,11 +190,11 @@ export default {
:paths="paths" /> :paths="paths" />
<navigation-controls <navigation-controls
:newPipelinePath="newPipelinePath" :new-pipeline-path="newPipelinePath"
:hasCIEnabled="hasCIEnabled" :has-ci-enabled="hasCiEnabled"
:helpPagePath="helpPagePath" :help-page-path="helpPagePath"
:ciLintPath="ciLintPath" :ciLintPath="ciLintPath"
:canCreatePipeline="canCreatePipelineParsed " /> :can-create-pipeline="canCreatePipelineParsed " />
</div> </div>
<div class="content-list pipelines"> <div class="content-list pipelines">

10
spec/javascripts/vue_pipelines_index/nav_controls_spec.js
View File

@ -11,7 +11,7 @@ describe('Pipelines Nav Controls', () => {
it('should render link to create a new pipeline', () => { it('should render link to create a new pipeline', () => {
const mockData = { const mockData = {
newPipelinePath: 'foo', newPipelinePath: 'foo',
hasCIEnabled: true, hasCiEnabled: true,
helpPagePath: 'foo', helpPagePath: 'foo',
ciLintPath: 'foo', ciLintPath: 'foo',
canCreatePipeline: true, canCreatePipeline: true,
@ -28,7 +28,7 @@ describe('Pipelines Nav Controls', () => {
it('should not render link to create pipeline if no permission is provided', () => { it('should not render link to create pipeline if no permission is provided', () => {
const mockData = { const mockData = {
newPipelinePath: 'foo', newPipelinePath: 'foo',
hasCIEnabled: true, hasCiEnabled: true,
helpPagePath: 'foo', helpPagePath: 'foo',
ciLintPath: 'foo', ciLintPath: 'foo',
canCreatePipeline: false, canCreatePipeline: false,
@ -44,7 +44,7 @@ describe('Pipelines Nav Controls', () => {
it('should render link for CI lint', () => { it('should render link for CI lint', () => {
const mockData = { const mockData = {
newPipelinePath: 'foo', newPipelinePath: 'foo',
hasCIEnabled: true, hasCiEnabled: true,
helpPagePath: 'foo', helpPagePath: 'foo',
ciLintPath: 'foo', ciLintPath: 'foo',
canCreatePipeline: true, canCreatePipeline: true,
@ -61,7 +61,7 @@ describe('Pipelines Nav Controls', () => {
it('should render link to help page when CI is not enabled', () => { it('should render link to help page when CI is not enabled', () => {
const mockData = { const mockData = {
newPipelinePath: 'foo', newPipelinePath: 'foo',
hasCIEnabled: false, hasCiEnabled: false,
helpPagePath: 'foo', helpPagePath: 'foo',
ciLintPath: 'foo', ciLintPath: 'foo',
canCreatePipeline: true, canCreatePipeline: true,
@ -78,7 +78,7 @@ describe('Pipelines Nav Controls', () => {
it('should not render link to help page when CI is enabled', () => { it('should not render link to help page when CI is enabled', () => {
const mockData = { const mockData = {
newPipelinePath: 'foo', newPipelinePath: 'foo',
hasCIEnabled: true, hasCiEnabled: true,
helpPagePath: 'foo', helpPagePath: 'foo',
ciLintPath: 'foo', ciLintPath: 'foo',
canCreatePipeline: true, canCreatePipeline: true,