kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

ReleasesFinder will always return a relation

Browse source
This commit is contained in:
Alessio Caiazza 2018-12-21 15:51:46 +01:00 committed by Shinya Maeda
parent b9aac409a5
commit a7aaad96f3
4 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/finders/releases_finder.rb
View file

@ -6,11 +6,9 @@ class ReleasesFinder
@current_user = current_user
end
# rubocop: disable CodeReuse/ActiveRecord
def execute
return [] unless Ability.allowed?(@current_user, :read_release, @project)
return Release.none unless Ability.allowed?(@current_user, :read_release, @project)
@project.releases.order('created_at DESC')
@project.releases.sorted
end
# rubocop: enable CodeReuse/ActiveRecord
end

2
app/models/release.rb
View file

@ -11,6 +11,8 @@ class Release < ActiveRecord::Base
validates :description, :project, :tag, presence: true
scope :sorted, -> { order(created_at: :desc) }
delegate :repository, to: :project
def commit

2
lib/api/releases.rb
View file

@ -21,7 +21,7 @@ module API
use :pagination
end
get ':id/releases' do
releases = ::Kaminari.paginate_array(::ReleasesFinder.new(user_project, current_user).execute)
releases = ::ReleasesFinder.new(user_project, current_user).execute
present paginate(releases), with: Entities::Release
end

9
spec/finders/releases_finder_spec.rb
View file

@ -6,15 +6,14 @@ describe ReleasesFinder do
let(:user) { create(:user) }
let(:project) { create(:project, :repository) }
let(:repository) { project.repository }
let(:v1_0_0) { create(:release, project: project, tag: 'v1.0.0')}
let(:v1_1_0) { create(:release, project: project, tag: 'v1.1.0')}
let(:v1_0_0) { create(:release, project: project, tag: 'v1.0.0') }
let(:v1_1_0) { create(:release, project: project, tag: 'v1.1.0') }
subject { described_class.new(project, user)}
before do
now = Time.now
v1_0_0.update_attribute(:created_at, now - 2.days)
v1_1_0.update_attribute(:created_at, now - 1.day)
v1_0_0.update_attribute(:created_at, 2.days.ago)
v1_1_0.update_attribute(:created_at, 1.day.ago)
end
describe '#execute' do