kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Refactor .show_gke_cluster_integration_callout?

Browse source
This commit is contained in:
Matija Čupić 2018-02-05 14:33:49 +01:00
parent c1e1f8070b
commit a85b85e1d8
No known key found for this signature in database
GPG key ID: 4BAF84FFACD2E5DE
2 changed files with 12 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/helpers/user_callouts_helper.rb
View file

@ -2,8 +2,8 @@ module UserCalloutsHelper
GKE_CLUSTER_INTEGRATION = 'gke_cluster_integration'.freeze
def show_gke_cluster_integration_callout?(project)
current_user && !user_dismissed?(GKE_CLUSTER_INTEGRATION) &&
can?(current_user, :create_cluster, project)
can?(current_user, :create_cluster, project) &&
!user_dismissed?(GKE_CLUSTER_INTEGRATION)
end
private

28
spec/helpers/user_callouts_helper_spec.rb
View file

@ -12,44 +12,36 @@ describe UserCalloutsHelper do
subject { helper.show_gke_cluster_integration_callout?(project) }
context 'when user has not dismissed' do
context 'when user can create a cluster' do
before do
allow(helper).to receive(:user_dismissed?).and_return(false)
allow(helper).to receive(:can?).with(anything, :create_cluster, anything)
.and_return(true)
end
context 'when user can create a cluster' do
context 'when user has not dismissed' do
before do
allow(helper).to receive(:can?).with(anything, :create_cluster, anything)
.and_return(true)
allow(helper).to receive(:user_dismissed?).and_return(false)
end
it { is_expected.to be true }
end
context 'when user can not create a cluster' do
context 'when user dismissed' do
before do
allow(helper).to receive(:can?).with(anything, :create_cluster, anything)
.and_return(false)
allow(helper).to receive(:user_dismissed?).and_return(true)
end
it { is_expected.to be false }
end
end
context 'when user dismissed' do
context 'when user can not create a cluster' do
before do
allow(helper).to receive(:user_dismissed?).and_return(true)
allow(helper).to receive(:can?).with(anything, :create_cluster, anything)
.and_return(false)
end
it { is_expected.to be false }
end
context 'when the user is not logged in' do
before do
allow(helper).to receive(:current_user).and_return(nil)
end
it { is_expected.to be_falsey }
end
end
end