From db68003e8b18e46fdfc91f0ca3030a18478b1085 Mon Sep 17 00:00:00 2001 From: Igor Date: Thu, 28 Mar 2019 12:11:37 +0000 Subject: [PATCH] Memoize old_blob and new_blob to improve performance --- lib/gitlab/diff/file.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/gitlab/diff/file.rb b/lib/gitlab/diff/file.rb index dce80bf21de..c46087e65de 100644 --- a/lib/gitlab/diff/file.rb +++ b/lib/gitlab/diff/file.rb @@ -133,11 +133,15 @@ module Gitlab end def new_blob - new_blob_lazy&.itself + strong_memoize(:new_blob) do + new_blob_lazy&.itself + end end def old_blob - old_blob_lazy&.itself + strong_memoize(:old_blob) do + old_blob_lazy&.itself + end end def new_blob_lines_between(from_line, to_line)