kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

move click handler to button. when on the icon it wasn't triggered in firefox

This commit is contained in:
Simon Knox 2017-07-17 15:44:08 +10:00
parent 00861676a0
commit a8f22ddf12
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/projects/cycle_analytics/show.html.haml
View File

@ -9,8 +9,8 @@
#cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
- if @cycle_analytics_no_data
.landing.content-block{ "v-if" => "!isOverviewDialogDismissed" }
%button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box' }
= icon("times", "@click" => "dismissOverviewDialog()")
%button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box', "@click" => "dismissOverviewDialog()" }
= icon("times")
.svg-container
= custom_icon('icon_cycle_analytics_splash')
.inner-content

4
changelogs/unreleased/35164-cycle-analytics-firefox.yml Normal file
View File

@ -0,0 +1,4 @@
---
title: allow closing Cycle Analytics intro box in firefox
merge_request:
author: