move click handler to button. when on the icon it wasn't triggered in firefox
This commit is contained in:
parent
00861676a0
commit
a8f22ddf12
2 changed files with 6 additions and 2 deletions
|
@ -9,8 +9,8 @@
|
|||
#cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
|
||||
- if @cycle_analytics_no_data
|
||||
.landing.content-block{ "v-if" => "!isOverviewDialogDismissed" }
|
||||
%button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box' }
|
||||
= icon("times", "@click" => "dismissOverviewDialog()")
|
||||
%button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box', "@click" => "dismissOverviewDialog()" }
|
||||
= icon("times")
|
||||
.svg-container
|
||||
= custom_icon('icon_cycle_analytics_splash')
|
||||
.inner-content
|
||||
|
|
4
changelogs/unreleased/35164-cycle-analytics-firefox.yml
Normal file
4
changelogs/unreleased/35164-cycle-analytics-firefox.yml
Normal file
|
@ -0,0 +1,4 @@
|
|||
---
|
||||
title: allow closing Cycle Analytics intro box in firefox
|
||||
merge_request:
|
||||
author:
|
Loading…
Reference in a new issue