Merge branch 'fix-danger-when-nobody-in-category' into 'master'

Fix reviewer roulette when no-one is in a category See merge request gitlab-org/gitlab-ce!27895
2019-04-30 13:35:47 +00:00 · 2019-04-30 13:35:47 +00:00 · a96e96d5c8
parent 56c8b35b84 60525148e7
commit a96e96d5c8
1 changed files with 3 additions and 1 deletions
--- a/danger/roulette/Dangerfile
+++ b/danger/roulette/Dangerfile
@ -57,10 +57,12 @@ def spin_for_person(people, random:)
  people.size.times do
    person = people.sample(random: random)

-    return person unless out_of_office?(person)
+    break person unless out_of_office?(person)

    people -= [person]
  end
+
+  person
 end

 def out_of_office?(person)