From a9c7de8815def87867daf025ff9753aae2615228 Mon Sep 17 00:00:00 2001 From: Zevs Date: Wed, 20 Jun 2012 21:01:00 +0300 Subject: [PATCH] Revert "Handle MR "show all commits" link with a doc-ready event handler." This reverts commit 5b1ede628065ecfdf95552322328b5bb7613753a. --- app/assets/javascripts/merge_requests.js | 13 ++++++------- app/views/merge_requests/_commits.html.haml | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/merge_requests.js b/app/assets/javascripts/merge_requests.js index 9a18f335559..c075cb4c0a3 100644 --- a/app/assets/javascripts/merge_requests.js +++ b/app/assets/javascripts/merge_requests.js @@ -58,16 +58,15 @@ var MergeRequest = { dataType: "script"}); }, + showAllCommits: + function() { + $(".first_mr_commits").remove(); + $(".all_mr_commits").removeClass("hide"); + }, + already_cannot_be_merged: function(){ $(".automerge_widget").hide(); $(".automerge_widget.already_cannot_be_merged").show(); } } - -$(function () { - $('.first_mr_commits a.show_all').live('click', function() { - $(".first_mr_commits").remove(); - $(".all_mr_commits").removeClass("hide"); - }); -}); diff --git a/app/views/merge_requests/_commits.html.haml b/app/views/merge_requests/_commits.html.haml index bad328b6792..441a7f32ef4 100644 --- a/app/views/merge_requests/_commits.html.haml +++ b/app/views/merge_requests/_commits.html.haml @@ -9,7 +9,7 @@ %li.bottom 8 of #{@commits.count} commits displayed. %strong - %a.show_all Click here to show all + = link_to_function "Click here to show all", "MergeRequest.showAllCommits()" %ul.all_mr_commits.hide.unstyled - @commits.each do |commit| = render "commits/commit", :commit => commit