Fix 404 for pipelines
This commit is contained in:
parent
9ee8693fda
commit
aa05fbc05d
|
@ -196,7 +196,8 @@ class Ability
|
||||||
@public_project_rules ||= project_guest_rules + [
|
@public_project_rules ||= project_guest_rules + [
|
||||||
:download_code,
|
:download_code,
|
||||||
:fork_project,
|
:fork_project,
|
||||||
:read_commit_status
|
:read_commit_status,
|
||||||
|
:read_pipeline
|
||||||
]
|
]
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -288,4 +288,142 @@ describe "Internal Project Access", feature: true do
|
||||||
it { is_expected.to be_denied_for :external }
|
it { is_expected.to be_denied_for :external }
|
||||||
it { is_expected.to be_denied_for :visitor }
|
it { is_expected.to be_denied_for :visitor }
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/pipelines" do
|
||||||
|
subject { namespace_project_pipelines_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_allowed_for guest }
|
||||||
|
it { is_expected.to be_allowed_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/pipelines/:id" do
|
||||||
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
||||||
|
subject { namespace_project_pipeline_path(project.namespace, project, pipeline) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_allowed_for guest }
|
||||||
|
it { is_expected.to be_allowed_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/builds" do
|
||||||
|
subject { namespace_project_builds_path(project.namespace, project) }
|
||||||
|
|
||||||
|
context "when allowed for public and internal" do
|
||||||
|
before { project.update(public_builds: true) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_allowed_for guest }
|
||||||
|
it { is_expected.to be_allowed_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
context "when disallowed for public and internal" do
|
||||||
|
before { project.update(public_builds: false) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/builds/:id" do
|
||||||
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
||||||
|
let(:build) { create(:ci_build, pipeline: pipeline) }
|
||||||
|
subject { namespace_project_build_path(project.namespace, project, build.id) }
|
||||||
|
|
||||||
|
context "when allowed for public and internal" do
|
||||||
|
before { project.update(public_builds: true) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_allowed_for guest }
|
||||||
|
it { is_expected.to be_allowed_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
context "when disallowed for public and internal" do
|
||||||
|
before { project.update(public_builds: false) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/environments" do
|
||||||
|
subject { namespace_project_environments_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/environments/:id" do
|
||||||
|
let(:environment) { create(:environment, project: project) }
|
||||||
|
subject { namespace_project_environment_path(project.namespace, project, environment) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/environments/new" do
|
||||||
|
subject { new_namespace_project_environment_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_denied_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -260,4 +260,106 @@ describe "Private Project Access", feature: true do
|
||||||
it { is_expected.to be_denied_for :external }
|
it { is_expected.to be_denied_for :external }
|
||||||
it { is_expected.to be_denied_for :visitor }
|
it { is_expected.to be_denied_for :visitor }
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/pipelines" do
|
||||||
|
subject { namespace_project_pipelines_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/pipelines/:id" do
|
||||||
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
||||||
|
subject { namespace_project_pipeline_path(project.namespace, project, pipeline) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/builds" do
|
||||||
|
subject { namespace_project_builds_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/builds/:id" do
|
||||||
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
||||||
|
let(:build) { create(:ci_build, pipeline: pipeline) }
|
||||||
|
subject { namespace_project_build_path(project.namespace, project, build.id) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/environments" do
|
||||||
|
subject { namespace_project_environments_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/environments/:id" do
|
||||||
|
let(:environment) { create(:environment, project: project) }
|
||||||
|
subject { namespace_project_environment_path(project.namespace, project, environment) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/environments/new" do
|
||||||
|
subject { new_namespace_project_environment_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_denied_for reporter }
|
||||||
|
it { is_expected.to be_denied_for guest }
|
||||||
|
it { is_expected.to be_denied_for :user }
|
||||||
|
it { is_expected.to be_denied_for :external }
|
||||||
|
it { is_expected.to be_denied_for :visitor }
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -109,6 +109,35 @@ describe "Public Project Access", feature: true do
|
||||||
it { is_expected.to be_allowed_for :external }
|
it { is_expected.to be_allowed_for :external }
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/pipelines" do
|
||||||
|
subject { namespace_project_pipelines_path(project.namespace, project) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_allowed_for guest }
|
||||||
|
it { is_expected.to be_allowed_for :user }
|
||||||
|
it { is_expected.to be_allowed_for :external }
|
||||||
|
it { is_expected.to be_allowed_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
|
describe "GET /:project_path/pipelines/:id" do
|
||||||
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
||||||
|
subject { namespace_project_pipeline_path(project.namespace, project, pipeline) }
|
||||||
|
|
||||||
|
it { is_expected.to be_allowed_for :admin }
|
||||||
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
it { is_expected.to be_allowed_for master }
|
||||||
|
it { is_expected.to be_allowed_for developer }
|
||||||
|
it { is_expected.to be_allowed_for reporter }
|
||||||
|
it { is_expected.to be_allowed_for guest }
|
||||||
|
it { is_expected.to be_allowed_for :user }
|
||||||
|
it { is_expected.to be_allowed_for :external }
|
||||||
|
it { is_expected.to be_allowed_for :visitor }
|
||||||
|
end
|
||||||
|
|
||||||
describe "GET /:project_path/builds" do
|
describe "GET /:project_path/builds" do
|
||||||
subject { namespace_project_builds_path(project.namespace, project) }
|
subject { namespace_project_builds_path(project.namespace, project) }
|
||||||
|
|
||||||
|
@ -191,7 +220,7 @@ describe "Public Project Access", feature: true do
|
||||||
|
|
||||||
describe "GET /:project_path/environments/:id" do
|
describe "GET /:project_path/environments/:id" do
|
||||||
let(:environment) { create(:environment, project: project) }
|
let(:environment) { create(:environment, project: project) }
|
||||||
subject { namespace_project_environments_path(project.namespace, project, environment) }
|
subject { namespace_project_environment_path(project.namespace, project, environment) }
|
||||||
|
|
||||||
it { is_expected.to be_allowed_for :admin }
|
it { is_expected.to be_allowed_for :admin }
|
||||||
it { is_expected.to be_allowed_for owner }
|
it { is_expected.to be_allowed_for owner }
|
||||||
|
|
Loading…
Reference in New Issue