From aa73ef5b16851ba69c5198f98683bf1200656bd5 Mon Sep 17 00:00:00 2001 From: James Ramsay Date: Wed, 24 Oct 2018 14:27:40 -0400 Subject: [PATCH] Add title to commit links in list view The short commit message may be truncated making the truncated portion unreadable. The title of the link should be the commit message so that the commit message is shown when hovering the commit message anchor. Closes gitlab-org/gitlab-ce#42673 --- app/views/projects/tree/_tree_commit_column.html.haml | 2 +- changelogs/unreleased/jramsay-42673-commit-tooltip.yml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/jramsay-42673-commit-tooltip.yml diff --git a/app/views/projects/tree/_tree_commit_column.html.haml b/app/views/projects/tree/_tree_commit_column.html.haml index 406dccb74fb..e37fd7624be 100644 --- a/app/views/projects/tree/_tree_commit_column.html.haml +++ b/app/views/projects/tree/_tree_commit_column.html.haml @@ -1,2 +1,2 @@ %span.str-truncated - = link_to_html commit.redacted_full_title_html, project_commit_path(@project, commit.id), class: 'tree-commit-link' + = link_to_html commit.redacted_full_title_html, project_commit_path(@project, commit.id), title: commit.redacted_full_title_html, class: 'tree-commit-link' diff --git a/changelogs/unreleased/jramsay-42673-commit-tooltip.yml b/changelogs/unreleased/jramsay-42673-commit-tooltip.yml new file mode 100644 index 00000000000..083cd1a54a0 --- /dev/null +++ b/changelogs/unreleased/jramsay-42673-commit-tooltip.yml @@ -0,0 +1,5 @@ +--- +title: Add commit message to commit tree anchor title +merge_request: 22585 +author: +type: fixed