From aaa65d324933a1f7e380c0f05a7b87fb3fe2e4b7 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 3 Mar 2022 12:14:02 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/database/multiple_databases.yml | 2 - .rubocop_todo/graphql/argument_uniqueness.yml | 4 + .rubocop_todo/graphql/unused_argument.yml | 5 + .rubocop_todo/rspec/instance_variable.yml | 203 +++ .rubocop_todo/rspec/verified_doubles.yml | 1206 +++++++++++++++++ Gemfile | 2 +- Gemfile.lock | 6 +- app/models/concerns/spammable.rb | 5 +- .../14-0-nfs-fot-git-repository-storage.yml | 24 +- .../14-2-deprecation-release-cli.yml | 24 +- .../14-2-deprecation-task-runner.yml | 24 +- ...atabase-deprecate-legacy-database-conf.yml | 2 +- ...14-3-deprecation_omniauth-kerberos_gem.yml | 3 +- .../14-3-repository-push-audit-events.yml | 10 +- ...cate-based-integration-with-kubernetes.yml | 6 +- ...ate-convert-instance-runner-to-project.yml | 8 +- ...geCommitMessageWithDescription-graphql.yml | 24 +- .../14-5-deprecate-opensuse-15-2.yml | 12 +- .../14-5-deprecate-sles-12sp2.yml | 10 +- .../14-5-deprecation-versions-packagetype.yml | 10 +- ...precation-of-vsa-filtering-calculation.yml | 18 +- .../14-5-disable_strict_host_key_checking.yml | 6 +- .../14-5-geo-deprecate-promote-db.yml | 16 +- ...-geo-deprecate-promote-to-primary-node.yml | 16 +- ...ge-container-registry-api-group-update.yml | 8 +- ...move-dependency-proxy-permissions-flag.yml | 12 +- .../14-5-remove-package-pipelines-api.yml | 12 +- ...-5-remove-pipelines-from-version-field.yml | 12 +- ...-runner-api-status-does-contain-paused.yml | 8 +- ...iontype-nonexplicit-config-deprecation.yml | 8 +- ...Enforce-validation-of-security-schemas.yml | 18 +- ...-6-container-scanning-schemas-below-14.yml | 24 +- ...14-6-coverage-fuzzing-schemas-below-14.yml | 24 +- .../14-6-dast-schemas-below-14.yml | 24 +- ...6-dependency-scanning-schemas-below-14.yml | 24 +- data/deprecations/14-6-deprecate-types.yml | 24 +- ...precation-license-compliance-api-terms.yml | 18 +- ...cure-dependency-scanning-bundler-audit.yml | 16 +- data/deprecations/14-6-job_char_limit.yml | 22 +- ...-6-pipeline-fields-package-deprecation.yml | 10 +- ...unner-api-status-renames-not_connected.yml | 6 +- ...r_api_new_stale_status_breaking_change.yml | 6 +- .../14-6-sast-schemas-below-14.yml | 24 +- ...14-6-secret-detection-schemas-below-14.yml | 24 +- ...te-godep-support-in-license-compliance.yml | 12 +- .../14-7-deprecate-merged_by-api-field.yml | 20 +- .../14-7-deprecate-static-site-editor.yml | 16 +- data/deprecations/14-7-pseudonymizer.yml | 12 +- ...-7-sidekiq-metrics-health-check-donfig.yml | 2 +- data/deprecations/14-8-Elasticsearch-6-8.yml | 11 +- ...equired-pipeline-configuration-premium.yml | 2 +- ...14-8-compliance-status-check-api-field.yml | 2 +- ...-PipelineSecurityReportFinding-GraphQL.yml | 2 +- ...n-secure-dependency-scanning-retire-js.yml | 16 +- .../14-8-enforce-pat-expiration.yml | 16 +- .../14-8-enforce-ssh-expiration.yml | 16 +- .../14-8-geo-deprecate-db-rake-tasks.yml | 4 +- ...eo-deprecate-replication-detail-routes.yml | 6 +- ...-gitaly-remove-per-repository-election.yml | 4 +- data/deprecations/14-8-graphql-ids.yml | 6 +- .../14-8-iteration-started-field.yml | 20 +- data/deprecations/14-8-protect-cns-chs.yml | 2 +- .../14-8-protect-vulnerability-check.yml | 2 +- ...commit-message-triggering-draft-status.yml | 12 +- ...ve_ff_push_rules_supersede_code_owners.yml | 6 +- data/deprecations/14-8-request-profiling.yml | 4 +- ...d-replaced-with-paused-breaking-change.yml | 4 +- ...unner-api-project_type-breaking-change.yml | 4 +- ...us-filter-does-accept-active-or-paused.yml | 4 +- .../14-8-sast-secret-analyzer-image.yml | 2 +- .../14-8-secure-and-protect-analyzer-bump.yml | 2 +- .../14-8-secure-ca-python-deprecation.yml | 18 +- .../15-0-deprecate-monitor-logging.yml | 17 +- .../15-0-deprecate-monitor-metrics.yml | 17 +- .../15-0-deprecate-monitor-tracing.yml | 16 +- ...stance-statistics-graphql-node-removal.yml | 2 +- data/deprecations/15-0-oauth-noexpiry.yml | 22 +- data/deprecations/15-0-oauth.yml | 22 +- ...cation_bump_terraform_template_version.yml | 2 +- ...al-sidekiq_experimental_queue_selector.yml | 2 - .../14_0/removal_ci_project_config_path.yml | 1 - .../removals/14_0/removal_enablement_pg11.yml | 2 - .../14_0/removal_enablement_ubuntu_16.yml | 3 - data/removals/14_0/removal_runner_25555.yml | 1 - .../14_0/verify-ci-removal-parametertrace.yml | 2 - .../14_3/removal-limit-tags-to-50.yml | 2 +- .../removal-verify-pe-pipelinefindername.yml | 4 +- .../14_3/removal_legacy_storage_setting.yml | 4 +- ...t_stringified_raw_metadata_hash_to_json.rb | 27 + ...e_nullify_orphan_runner_id_on_ci_builds.rb | 27 + db/schema_migrations/20220215190020 | 1 + db/schema_migrations/20220223112304 | 1 + doc/api/users.md | 26 + doc/ci/pipelines/cicd_minutes.md | 22 + doc/development/adding_database_indexes.md | 8 +- doc/development/service_ping/implement.md | 9 +- doc/update/deprecations.md | 8 +- doc/user/admin_area/license.md | 2 +- lib/api/users.rb | 17 + ...occurrences_with_hashes_as_raw_metadata.rb | 2 +- .../nullify_orphan_runner_id_on_ci_builds.rb | 40 + locale/gitlab.pot | 3 + rubocop/cop/database/multiple_databases.rb | 13 + .../confirmations_controller_spec.rb | 2 +- spec/controllers/passwords_controller_spec.rb | 2 +- spec/controllers/sessions_controller_spec.rb | 6 +- spec/features/users/signup_spec.rb | 2 +- ...lify_orphan_runner_id_on_ci_builds_spec.rb | 49 + spec/models/concerns/spammable_spec.rb | 4 +- spec/requests/api/users_spec.rb | 27 + .../cop/database/multiple_databases_spec.rb | 10 + 111 files changed, 2144 insertions(+), 480 deletions(-) create mode 100644 .rubocop_todo/graphql/argument_uniqueness.yml create mode 100644 .rubocop_todo/graphql/unused_argument.yml create mode 100644 .rubocop_todo/rspec/instance_variable.yml create mode 100644 .rubocop_todo/rspec/verified_doubles.yml create mode 100644 db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb create mode 100644 db/post_migrate/20220223112304_schedule_nullify_orphan_runner_id_on_ci_builds.rb create mode 100644 db/schema_migrations/20220215190020 create mode 100644 db/schema_migrations/20220223112304 create mode 100644 lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb create mode 100644 spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml index e390f81f030..38a6ccb3ef4 100644 --- a/.rubocop_todo/database/multiple_databases.yml +++ b/.rubocop_todo/database/multiple_databases.yml @@ -18,10 +18,8 @@ Database/MultipleDatabases: - lib/gitlab/database/migrations/observers/query_log.rb - lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb - lib/gitlab/database.rb - - lib/gitlab/gitlab_import/importer.rb - lib/gitlab/health_checks/db_check.rb - lib/gitlab/import_export/group/relation_tree_restorer.rb - - lib/gitlab/legacy_github_import/importer.rb - lib/gitlab/seeder.rb - spec/db/schema_spec.rb - spec/initializers/database_config_spec.rb diff --git a/.rubocop_todo/graphql/argument_uniqueness.yml b/.rubocop_todo/graphql/argument_uniqueness.yml new file mode 100644 index 00000000000..036d5d8ecdb --- /dev/null +++ b/.rubocop_todo/graphql/argument_uniqueness.yml @@ -0,0 +1,4 @@ +--- +GraphQL/ArgumentUniqueness: + Exclude: + - app/graphql/resolvers/merge_requests_resolver.rb diff --git a/.rubocop_todo/graphql/unused_argument.yml b/.rubocop_todo/graphql/unused_argument.yml new file mode 100644 index 00000000000..c55d8551591 --- /dev/null +++ b/.rubocop_todo/graphql/unused_argument.yml @@ -0,0 +1,5 @@ +--- +GraphQL/UnusedArgument: + Exclude: + - app/graphql/mutations/jira_import/start.rb + - app/graphql/resolvers/packages_base_resolver.rb diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml new file mode 100644 index 00000000000..6c147d22808 --- /dev/null +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -0,0 +1,203 @@ +--- +RSpec/InstanceVariable: + Exclude: + - ee/spec/controllers/admin/application_settings_controller_spec.rb + - ee/spec/controllers/admin/geo/settings_controller_spec.rb + - ee/spec/controllers/ee/sessions_controller_spec.rb + - ee/spec/controllers/groups/groups_controller_spec.rb + - ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb + - ee/spec/controllers/passwords_controller_spec.rb + - ee/spec/features/markdown/markdown_spec.rb + - ee/spec/frontend/fixtures/dast_profiles.rb + - ee/spec/frontend/fixtures/epic.rb + - ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb + - ee/spec/graphql/types/vulnerability_request_type_spec.rb + - ee/spec/graphql/types/vulnerability_response_type_spec.rb + - ee/spec/helpers/ee/issuables_helper_spec.rb + - ee/spec/helpers/ee/namespace_storage_limit_alert_helper_spec.rb + - ee/spec/helpers/ee/wiki_helper_spec.rb + - ee/spec/helpers/notes_helper_spec.rb + - ee/spec/helpers/search_helper_spec.rb + - ee/spec/lib/ee/gitlab/elastic/helper_spec.rb + - ee/spec/lib/gitlab/elastic/search_results_spec.rb + - ee/spec/lib/gitlab/reference_extractor_spec.rb + - ee/spec/services/ee/merge_requests/update_service_spec.rb + - ee/spec/services/ee/notification_service_spec.rb + - ee/spec/services/ee/users/create_service_spec.rb + - ee/spec/services/ee/users/destroy_service_spec.rb + - ee/spec/services/geo/metrics_update_service_spec.rb + - ee/spec/services/groups/create_service_spec.rb + - ee/spec/services/groups/participants_service_spec.rb + - ee/spec/services/projects/create_from_template_service_spec.rb + - ee/spec/services/projects/create_service_spec.rb + - ee/spec/support/shared_examples/views/subscription_shared_examples.rb + - ee/spec/tasks/geo_rake_spec.rb + - ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb + - ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb + - ee/spec/views/projects/security/dast_scanner_profiles/new.html.haml_spec.rb + - ee/spec/views/projects/security/dast_site_profiles/new.html.haml_spec.rb + - qa/qa/specs/features/api/1_manage/import_large_github_repo_spec.rb + - qa/qa/specs/features/api/1_manage/project_access_token_spec.rb + - qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb + - qa/qa/specs/features/browser_ui/1_manage/login/2fa_recovery_spec.rb + - qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb + - qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb + - qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb + - qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb + - qa/qa/specs/features/browser_ui/1_manage/project/protected_tags_spec.rb + - qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb + - qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb + - qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb + - qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb + - qa/qa/specs/features/browser_ui/3_create/web_ide/link_to_line_in_web_ide_spec.rb + - qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb + - qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb + - qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb + - qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_ci_job_log_artifacts_spec.rb + - qa/qa/specs/features/ee/browser_ui/12_geo/rename_replication_spec.rb + - qa/qa/specs/features/ee/browser_ui/13_secure/create_merge_request_with_secure_spec.rb + - qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb + - qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb + - qa/qa/specs/features/ee/browser_ui/13_secure/project_security_dashboard_spec.rb + - qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb + - qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb + - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb + - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_file_template_spec.rb + - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb + - qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb + - qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb + - qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb + - qa/qa/specs/features/ee/browser_ui/2_plan/integrations/jira_issues_list_spec.rb + - qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb + - qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb + - qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb + - qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb + - qa/qa/specs/features/ee/browser_ui/4_verify/cancelling_merge_request_in_merge_train_spec.rb + - qa/spec/support/repeater_spec.rb + - spec/commands/metrics_server/metrics_server_spec.rb + - spec/controllers/admin/clusters_controller_spec.rb + - spec/controllers/admin/topics/avatars_controller_spec.rb + - spec/controllers/concerns/renders_commits_spec.rb + - spec/controllers/confirmations_controller_spec.rb + - spec/controllers/groups/avatars_controller_spec.rb + - spec/controllers/groups/clusters_controller_spec.rb + - spec/controllers/import/bitbucket_controller_spec.rb + - spec/controllers/import/bitbucket_server_controller_spec.rb + - spec/controllers/metrics_controller_spec.rb + - spec/controllers/omniauth_callbacks_controller_spec.rb + - spec/controllers/passwords_controller_spec.rb + - spec/controllers/profiles/avatars_controller_spec.rb + - spec/controllers/projects/clusters_controller_spec.rb + - spec/controllers/sessions_controller_spec.rb + - spec/features/admin/admin_runners_spec.rb + - spec/features/calendar_spec.rb + - spec/features/issues/user_filters_issues_spec.rb + - spec/features/markdown/copy_as_gfm_spec.rb + - spec/features/markdown/gitlab_flavored_markdown_spec.rb + - spec/features/markdown/keyboard_shortcuts_spec.rb + - spec/features/markdown/markdown_spec.rb + - spec/features/merge_request/batch_comments_spec.rb + - spec/features/merge_request/user_sees_pipelines_spec.rb + - spec/features/merge_requests/user_lists_merge_requests_spec.rb + - spec/features/projects/diffs/diff_show_spec.rb + - spec/features/triggers_spec.rb + - spec/features/u2f_spec.rb + - spec/finders/admin/plans_finder_spec.rb + - spec/finders/groups_finder_spec.rb + - spec/finders/issues_finder_spec.rb + - spec/frontend/fixtures/listbox.rb + - spec/frontend/fixtures/raw.rb + - spec/frontend/fixtures/sessions.rb + - spec/frontend/fixtures/tabs.rb + - spec/frontend/fixtures/timezones.rb + - spec/frontend/fixtures/u2f.rb + - spec/frontend/fixtures/webauthn.rb + - spec/helpers/application_helper_spec.rb + - spec/helpers/award_emoji_helper_spec.rb + - spec/helpers/issuables_description_templates_helper_spec.rb + - spec/helpers/issuables_helper_spec.rb + - spec/helpers/notes_helper_spec.rb + - spec/helpers/projects_helper_spec.rb + - spec/helpers/search_helper_spec.rb + - spec/helpers/tree_helper_spec.rb + - spec/helpers/wiki_helper_spec.rb + - spec/lib/api/helpers/authentication_spec.rb + - spec/lib/banzai/filter/asset_proxy_filter_spec.rb + - spec/lib/extracts_path_spec.rb + - spec/lib/extracts_ref_spec.rb + - spec/lib/gitlab/auth/auth_finders_spec.rb + - spec/lib/gitlab/auth/ldap/person_spec.rb + - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb + - spec/lib/gitlab/bitbucket_import/importer_spec.rb + - spec/lib/gitlab/chat_name_token_spec.rb + - spec/lib/gitlab/ci/lint_spec.rb + - spec/lib/gitlab/ci/status/composite_spec.rb + - spec/lib/gitlab/contributions_calendar_spec.rb + - spec/lib/gitlab/diff/parser_spec.rb + - spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb + - spec/lib/gitlab/git/commit_spec.rb + - spec/lib/gitlab/git/diff_collection_spec.rb + - spec/lib/gitlab/git/diff_spec.rb + - spec/lib/gitlab/git/repository_spec.rb + - spec/lib/gitlab/http_spec.rb + - spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb + - spec/lib/gitlab/import_export/group/tree_restorer_spec.rb + - spec/lib/gitlab/import_export/project/tree_restorer_spec.rb + - spec/lib/gitlab/patch/prependable_spec.rb + - spec/lib/gitlab/popen_spec.rb + - spec/lib/gitlab/project_transfer_spec.rb + - spec/lib/gitlab/reference_extractor_spec.rb + - spec/lib/gitlab/tcp_checker_spec.rb + - spec/lib/gitlab/user_access_spec.rb + - spec/lib/gitlab/version_info_spec.rb + - spec/lib/gitlab/x509/certificate_spec.rb + - spec/mailers/emails/issues_spec.rb + - spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb + - spec/migrations/rename_services_to_integrations_spec.rb + - spec/migrations/replace_external_wiki_triggers_spec.rb + - spec/models/group_spec.rb + - spec/models/integrations/assembla_spec.rb + - spec/models/integrations/campfire_spec.rb + - spec/models/integrations/irker_spec.rb + - spec/models/member_spec.rb + - spec/models/members/project_member_spec.rb + - spec/models/namespace_spec.rb + - spec/models/note_spec.rb + - spec/models/postgresql/replication_slot_spec.rb + - spec/models/project_spec.rb + - spec/models/user_spec.rb + - spec/models/users/in_product_marketing_email_spec.rb + - spec/rack_servers/puma_spec.rb + - spec/requests/api/admin/plan_limits_spec.rb + - spec/requests/api/merge_requests_spec.rb + - spec/requests/api/users_spec.rb + - spec/requests/git_http_spec.rb + - spec/requests/openid_connect_spec.rb + - spec/requests/projects/issues/discussions_spec.rb + - spec/rubocop/cop/migration/update_column_in_batches_spec.rb + - spec/serializers/pipeline_serializer_spec.rb + - spec/services/ci/create_pipeline_service/logger_spec.rb + - spec/services/ci/process_sync_events_service_spec.rb + - spec/services/labels/update_service_spec.rb + - spec/services/members/destroy_service_spec.rb + - spec/services/merge_requests/close_service_spec.rb + - spec/services/merge_requests/refresh_service_spec.rb + - spec/services/merge_requests/reopen_service_spec.rb + - spec/services/merge_requests/update_service_spec.rb + - spec/services/milestones/create_service_spec.rb + - spec/services/notes/post_process_service_spec.rb + - spec/services/notes/update_service_spec.rb + - spec/services/notification_service_spec.rb + - spec/services/pages/zip_directory_service_spec.rb + - spec/services/projects/create_from_template_service_spec.rb + - spec/services/projects/download_service_spec.rb + - spec/services/projects/fork_service_spec.rb + - spec/services/upload_service_spec.rb + - spec/support/shared_contexts/controllers/ldap_omniauth_callbacks_controller_shared_context.rb + - spec/support/shared_contexts/email_shared_context.rb + - spec/support/shared_examples/features/wiki/user_views_wiki_empty_shared_examples.rb + - spec/support/shared_examples/path_extraction_shared_examples.rb + - spec/support/shared_examples/requests/api/notes_shared_examples.rb + - spec/support_specs/helpers/stub_feature_flags_spec.rb + - spec/views/search/_results.html.haml_spec.rb + - spec/workers/emails_on_push_worker_spec.rb diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml new file mode 100644 index 00000000000..7cffea49d3a --- /dev/null +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -0,0 +1,1206 @@ +--- +RSpec/VerifiedDoubles: + Exclude: + - ee/spec/controllers/boards/issues_controller_spec.rb + - ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb + - ee/spec/controllers/groups/clusters_controller_spec.rb + - ee/spec/controllers/groups/sso_controller_spec.rb + - ee/spec/controllers/oauth/geo_auth_controller_spec.rb + - ee/spec/controllers/projects/clusters_controller_spec.rb + - ee/spec/controllers/projects/security/network_policies_controller_spec.rb + - ee/spec/db/production/license_spec.rb + - ee/spec/elastic/migrate/20210510113500_delete_merge_requests_from_original_index_spec.rb + - ee/spec/elastic/migrate/20210510143200_delete_notes_from_original_index_spec.rb + - ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb + - ee/spec/features/billings/billing_plans_spec.rb + - ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb + - ee/spec/features/profiles/account_spec.rb + - ee/spec/finders/license_template_finder_spec.rb + - ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb + - ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb + - ee/spec/finders/template_finder_spec.rb + - ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb + - ee/spec/graphql/mutations/dast_scanner_profiles/create_spec.rb + - ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb + - ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb + - ee/spec/graphql/mutations/dast_site_profiles/update_spec.rb + - ee/spec/graphql/mutations/incident_management/oncall_rotation/create_spec.rb + - ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb + - ee/spec/graphql/mutations/issues/set_epic_spec.rb + - ee/spec/graphql/mutations/merge_requests/accept_spec.rb + - ee/spec/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb + - ee/spec/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb + - ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb + - ee/spec/graphql/resolvers/external_issue_resolver_spec.rb + - ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb + - ee/spec/graphql/resolvers/vulnerabilities/details_resolver_spec.rb + - ee/spec/graphql/types/network_policy_type_spec.rb + - ee/spec/graphql/types/security/training_type_spec.rb + - ee/spec/helpers/billing_plans_helper_spec.rb + - ee/spec/helpers/ee/ci/runners_helper_spec.rb + - ee/spec/helpers/ee/integrations_helper_spec.rb + - ee/spec/helpers/ee/subscribable_banner_helper_spec.rb + - ee/spec/helpers/ee/trial_helper_spec.rb + - ee/spec/helpers/ee/trial_registration_helper_spec.rb + - ee/spec/helpers/kerberos_spnego_helper_spec.rb + - ee/spec/helpers/license_helper_spec.rb + - ee/spec/helpers/roadmaps_helper_spec.rb + - ee/spec/helpers/routing/pseudonymization_helper_spec.rb + - ee/spec/helpers/subscriptions_helper_spec.rb + - ee/spec/helpers/timeboxes_helper_spec.rb + - ee/spec/helpers/vulnerabilities_helper_spec.rb + - ee/spec/lib/ee/backup/repositories_spec.rb + - ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb + - ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb + - ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb + - ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb + - ee/spec/lib/ee/gitlab/etag_caching/router/rails_spec.rb + - ee/spec/lib/ee/gitlab/gon_helper_spec.rb + - ee/spec/lib/elastic/latest/config_shared_examples.rb + - ee/spec/lib/elastic/latest/git_instance_proxy_spec.rb + - ee/spec/lib/elastic/migration_spec.rb + - ee/spec/lib/elastic/multi_version_class_proxy_spec.rb + - ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb + - ee/spec/lib/gitlab/audit/target_spec.rb + - ee/spec/lib/gitlab/auth/group_saml/response_check_spec.rb + - ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb + - ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb + - ee/spec/lib/gitlab/authority_analyzer_spec.rb + - ee/spec/lib/gitlab/cache_spec.rb + - ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb + - ee/spec/lib/gitlab/ci/pipeline/chain/limit/job_activity_spec.rb + - ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb + - ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb + - ee/spec/lib/gitlab/code_owners/users_loader_spec.rb + - ee/spec/lib/gitlab/custom_file_templates_spec.rb + - ee/spec/lib/gitlab/elastic/client_spec.rb + - ee/spec/lib/gitlab/elastic/search_results_spec.rb + - ee/spec/lib/gitlab/expiring_subscription_message_spec.rb + - ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb + - ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb + - ee/spec/lib/gitlab/geo/oauth/logout_token_spec.rb + - ee/spec/lib/gitlab/geo/oauth/session_spec.rb + - ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb + - ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb + - ee/spec/lib/gitlab/geo/replicator_spec.rb + - ee/spec/lib/gitlab/geo_spec.rb + - ee/spec/lib/gitlab/git_access_spec.rb + - ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb + - ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb + - ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb + - ee/spec/lib/gitlab/patch/legacy_database_config_spec.rb + - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb + - ee/spec/lib/gitlab/prometheus/queries/packet_flow_metrics_query_spec.rb + - ee/spec/lib/gitlab/prometheus/queries/packet_flow_query_spec.rb + - ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb + - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb + - ee/spec/lib/system_check/app/elasticsearch_check_spec.rb + - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb + - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb + - ee/spec/models/approvable_spec.rb + - ee/spec/models/concerns/ee/sha_attribute_spec.rb + - ee/spec/models/concerns/geo/verification_state_spec.rb + - ee/spec/models/ee/ci/job_artifact_spec.rb + - ee/spec/models/ee/user_spec.rb + - ee/spec/models/elastic/index_setting_spec.rb + - ee/spec/models/geo/project_registry_spec.rb + - ee/spec/models/geo/secondary_usage_data_spec.rb + - ee/spec/models/geo_node_status_spec.rb + - ee/spec/models/integrations/github/status_message_spec.rb + - ee/spec/models/integrations/github_spec.rb + - ee/spec/models/project_spec.rb + - ee/spec/models/push_rule_spec.rb + - ee/spec/presenters/audit_event_presenter_spec.rb + - ee/spec/presenters/group_member_presenter_spec.rb + - ee/spec/presenters/merge_request_approver_presenter_spec.rb + - ee/spec/presenters/project_member_presenter_spec.rb + - ee/spec/requests/api/alert_management_alerts_spec.rb + - ee/spec/requests/api/geo_spec.rb + - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb + - ee/spec/requests/api/internal/base_spec.rb + - ee/spec/requests/api/ldap_spec.rb + - ee/spec/requests/api/visual_review_discussions_spec.rb + - ee/spec/requests/api/vulnerability_findings_spec.rb + - ee/spec/requests/callout_spec.rb + - ee/spec/requests/rack_attack_spec.rb + - ee/spec/serializers/blocking_merge_request_entity_spec.rb + - ee/spec/serializers/clusters/environment_entity_spec.rb + - ee/spec/serializers/dashboard_operations_project_entity_spec.rb + - ee/spec/serializers/dependency_entity_spec.rb + - ee/spec/serializers/ee/admin/user_entity_spec.rb + - ee/spec/serializers/ee/build_details_entity_spec.rb + - ee/spec/serializers/ee/ci/job_entity_spec.rb + - ee/spec/serializers/ee/ci/pipeline_entity_spec.rb + - ee/spec/serializers/ee/group_child_entity_spec.rb + - ee/spec/serializers/ee/issue_board_entity_spec.rb + - ee/spec/serializers/ee/issue_entity_spec.rb + - ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb + - ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb + - ee/spec/serializers/ee/note_entity_spec.rb + - ee/spec/serializers/environment_entity_spec.rb + - ee/spec/serializers/epic_entity_spec.rb + - ee/spec/serializers/epic_note_entity_spec.rb + - ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb + - ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb + - ee/spec/serializers/issuable_sidebar_extras_entity_spec.rb + - ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb + - ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb + - ee/spec/serializers/merge_request_compliance_entity_spec.rb + - ee/spec/serializers/merge_request_poll_widget_entity_spec.rb + - ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb + - ee/spec/serializers/merge_request_widget_entity_spec.rb + - ee/spec/serializers/service_field_entity_spec.rb + - ee/spec/serializers/test_reports_comparer_serializer_spec.rb + - ee/spec/serializers/user_analytics_entity_spec.rb + - ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb + - ee/spec/serializers/vulnerabilities/finding_entity_spec.rb + - ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb + - ee/spec/serializers/vulnerabilities/finding_serializer_spec.rb + - ee/spec/serializers/vulnerability_note_entity_spec.rb + - ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb + - ee/spec/services/app_sec/dast/scans/create_service_spec.rb + - ee/spec/services/app_sec/dast/site_profiles/update_service_spec.rb + - ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb + - ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb + - ee/spec/services/ci/minutes/track_live_consumption_service_spec.rb + - ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb + - ee/spec/services/ci/pipeline_creation/drop_not_runnable_builds_service_spec.rb + - ee/spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb + - ee/spec/services/dashboard/operations/list_service_spec.rb + - ee/spec/services/dashboard/projects/create_service_spec.rb + - ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb + - ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb + - ee/spec/services/ee/issues/create_service_spec.rb + - ee/spec/services/ee/issues/update_service_spec.rb + - ee/spec/services/ee/merge_requests/base_service_spec.rb + - ee/spec/services/ee/merge_requests/post_merge_service_spec.rb + - ee/spec/services/ee/merge_requests/refresh_service_spec.rb + - ee/spec/services/ee/notification_service_spec.rb + - ee/spec/services/ee/post_receive_service_spec.rb + - ee/spec/services/ee/service_ping/build_payload_service_spec.rb + - ee/spec/services/ee/service_ping/permit_data_categories_service_spec.rb + - ee/spec/services/ee/service_ping/service_ping_settings_spec.rb + - ee/spec/services/geo/blob_download_service_spec.rb + - ee/spec/services/geo/file_download_service_spec.rb + - ee/spec/services/geo/graphql_request_service_spec.rb + - ee/spec/services/geo/node_status_request_service_spec.rb + - ee/spec/services/geo/replication_toggle_request_service_spec.rb + - ee/spec/services/geo/repository_verification_primary_service_spec.rb + - ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb + - ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb + - ee/spec/services/group_saml/sign_up_service_spec.rb + - ee/spec/services/groups/update_repository_storage_service_spec.rb + - ee/spec/services/ide/schemas_config_service_spec.rb + - ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb + - ee/spec/services/incident_management/pending_escalations/process_service_spec.rb + - ee/spec/services/merge_requests/approval_service_spec.rb + - ee/spec/services/merge_requests/build_service_spec.rb + - ee/spec/services/merge_requests/reset_approvals_service_spec.rb + - ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb + - ee/spec/services/network_policies/delete_resource_service_spec.rb + - ee/spec/services/network_policies/deploy_resource_service_spec.rb + - ee/spec/services/network_policies/find_resource_service_spec.rb + - ee/spec/services/network_policies/resources_service_spec.rb + - ee/spec/services/projects/update_mirror_service_spec.rb + - ee/spec/services/projects/update_pages_service_spec.rb + - ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb + - ee/spec/services/security/orchestration/assign_service_spec.rb + - ee/spec/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service_spec.rb + - ee/spec/services/slash_commands/global_slack_handler_spec.rb + - ee/spec/services/status_page/publish_details_service_spec.rb + - ee/spec/services/status_page/publish_service_spec.rb + - ee/spec/services/status_page/trigger_publish_service_spec.rb + - ee/spec/services/system_note_service_spec.rb + - ee/spec/services/vulnerability_exports/export_service_spec.rb + - ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb + - ee/spec/support/helpers/ee/ldap_helpers.rb + - ee/spec/support/prometheus/additional_metrics_shared_examples.rb + - ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb + - ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb + - ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb + - ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb + - ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb + - ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb + - ee/spec/support/shared_examples/services/alert_management/alert_processing/oncall_notifications_shared_examples.rb + - ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb + - ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb + - ee/spec/support/shared_examples/status_page/reference_links_examples.rb + - ee/spec/validators/json_schema_validator_spec.rb + - ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb + - ee/spec/workers/ci/sync_reports_to_report_approval_rules_worker_spec.rb + - ee/spec/workers/geo/container_repository_sync_worker_spec.rb + - ee/spec/workers/geo/design_repository_sync_worker_spec.rb + - ee/spec/workers/geo/destroy_worker_spec.rb + - ee/spec/workers/geo/event_worker_spec.rb + - ee/spec/workers/geo/file_download_dispatch_worker_spec.rb + - ee/spec/workers/geo/file_download_worker_spec.rb + - ee/spec/workers/geo/metrics_update_worker_spec.rb + - ee/spec/workers/geo/prune_event_log_worker_spec.rb + - ee/spec/workers/geo/registry_sync_worker_spec.rb + - ee/spec/workers/geo/reverification_batch_worker_spec.rb + - ee/spec/workers/geo/sidekiq_cron_config_worker_spec.rb + - ee/spec/workers/geo/sync_timeout_cron_worker_spec.rb + - ee/spec/workers/geo/verification_batch_worker_spec.rb + - ee/spec/workers/geo/verification_cron_worker_spec.rb + - ee/spec/workers/geo/verification_timeout_worker_spec.rb + - ee/spec/workers/geo/verification_worker_spec.rb + - ee/spec/workers/iterations/cadences/create_iterations_worker_spec.rb + - ee/spec/workers/iterations/roll_over_issues_worker_spec.rb + - ee/spec/workers/ldap_group_sync_worker_spec.rb + - ee/spec/workers/merge_request_reset_approvals_worker_spec.rb + - ee/spec/workers/new_epic_worker_spec.rb + - ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb + - qa/spec/git/repository_spec.rb + - qa/spec/page/base_spec.rb + - qa/spec/page/validator_spec.rb + - qa/spec/page/view_spec.rb + - qa/spec/resource/api_fabricator_spec.rb + - qa/spec/resource/base_spec.rb + - qa/spec/runtime/application_settings_spec.rb + - qa/spec/runtime/feature_spec.rb + - qa/spec/runtime/release_spec.rb + - qa/spec/scenario/template_spec.rb + - qa/spec/scenario/test/integration/github_spec.rb + - qa/spec/scenario/test/sanity/selectors_spec.rb + - qa/spec/specs/allure_report_spec.rb + - qa/spec/support/formatters/allure_metadata_formatter_spec.rb + - qa/spec/support/page_error_checker_spec.rb + - qa/spec/support/run_spec.rb + - qa/spec/support/shared_examples/scenario_shared_examples.rb + - qa/spec/tools/long_running_spec_reporter_spec.rb + - spec/benchmarks/banzai_benchmark.rb + - spec/bin/feature_flag_spec.rb + - spec/controllers/admin/clusters_controller_spec.rb + - spec/controllers/application_controller_spec.rb + - spec/controllers/boards/issues_controller_spec.rb + - spec/controllers/boards/lists_controller_spec.rb + - spec/controllers/concerns/checks_collaboration_spec.rb + - spec/controllers/concerns/import_url_params_spec.rb + - spec/controllers/concerns/issuable_actions_spec.rb + - spec/controllers/concerns/issuable_collections_spec.rb + - spec/controllers/concerns/page_limiter_spec.rb + - spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb + - spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb + - spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb + - spec/controllers/dashboard/snippets_controller_spec.rb + - spec/controllers/explore/projects_controller_spec.rb + - spec/controllers/groups/clusters_controller_spec.rb + - spec/controllers/groups/dependency_proxy_auth_controller_spec.rb + - spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb + - spec/controllers/help_controller_spec.rb + - spec/controllers/import/bitbucket_controller_spec.rb + - spec/controllers/import/bitbucket_server_controller_spec.rb + - spec/controllers/import/bulk_imports_controller_spec.rb + - spec/controllers/import/fogbugz_controller_spec.rb + - spec/controllers/import/gitea_controller_spec.rb + - spec/controllers/import/github_controller_spec.rb + - spec/controllers/import/gitlab_controller_spec.rb + - spec/controllers/oauth/jira/authorizations_controller_spec.rb + - spec/controllers/omniauth_callbacks_controller_spec.rb + - spec/controllers/profiles/two_factor_auths_controller_spec.rb + - spec/controllers/projects/blob_controller_spec.rb + - spec/controllers/projects/branches_controller_spec.rb + - spec/controllers/projects/clusters_controller_spec.rb + - spec/controllers/projects/error_tracking/projects_controller_spec.rb + - spec/controllers/projects/error_tracking/stack_traces_controller_spec.rb + - spec/controllers/projects/error_tracking_controller_spec.rb + - spec/controllers/projects/import/jira_controller_spec.rb + - spec/controllers/projects/jobs_controller_spec.rb + - spec/controllers/projects/merge_requests/diffs_controller_spec.rb + - spec/controllers/projects/merge_requests_controller_spec.rb + - spec/controllers/projects/notes_controller_spec.rb + - spec/controllers/projects/pages_controller_spec.rb + - spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb + - spec/controllers/projects/pipelines_controller_spec.rb + - spec/controllers/projects/prometheus/metrics_controller_spec.rb + - spec/controllers/projects/registry/tags_controller_spec.rb + - spec/controllers/projects/settings/operations_controller_spec.rb + - spec/controllers/projects/snippets_controller_spec.rb + - spec/controllers/sessions_controller_spec.rb + - spec/dependencies/omniauth_saml_spec.rb + - spec/experiments/concerns/project_commit_count_spec.rb + - spec/factories/ci/job_artifacts.rb + - spec/factories/clusters/applications/helm.rb + - spec/features/admin/admin_system_info_spec.rb + - spec/features/clusters/create_agent_spec.rb + - spec/features/file_uploads/maven_package_spec.rb + - spec/features/groups/container_registry_spec.rb + - spec/features/help_pages_spec.rb + - spec/features/issuables/markdown_references/jira_spec.rb + - spec/features/markdown/markdown_spec.rb + - spec/features/profiles/personal_access_tokens_spec.rb + - spec/features/projects/clusters/gcp_spec.rb + - spec/features/projects/clusters_spec.rb + - spec/features/projects/container_registry_spec.rb + - spec/features/projects/integrations/user_activates_jira_spec.rb + - spec/finders/ci/auth_job_finder_spec.rb + - spec/finders/merge_requests/oldest_per_commit_finder_spec.rb + - spec/finders/projects/serverless/functions_finder_spec.rb + - spec/finders/repositories/changelog_commits_finder_spec.rb + - spec/finders/repositories/changelog_tag_finder_spec.rb + - spec/graphql/features/authorization_spec.rb + - spec/graphql/features/feature_flag_spec.rb + - spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb + - spec/graphql/mutations/alert_management/update_alert_status_spec.rb + - spec/graphql/mutations/branches/create_spec.rb + - spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb + - spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb + - spec/graphql/mutations/concerns/mutations/finds_by_gid_spec.rb + - spec/graphql/mutations/design_management/upload_spec.rb + - spec/graphql/mutations/environments/canary_ingress/update_spec.rb + - spec/graphql/mutations/merge_requests/accept_spec.rb + - spec/graphql/mutations/merge_requests/create_spec.rb + - spec/graphql/resolvers/design_management/versions_resolver_spec.rb + - spec/graphql/resolvers/error_tracking/sentry_detailed_error_resolver_spec.rb + - spec/graphql/resolvers/error_tracking/sentry_error_collection_resolver_spec.rb + - spec/graphql/resolvers/error_tracking/sentry_errors_resolver_spec.rb + - spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb + - spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb + - spec/graphql/types/ci/detailed_status_type_spec.rb + - spec/graphql/types/ci/status_action_type_spec.rb + - spec/graphql/types/kas/agent_connection_type_spec.rb + - spec/graphql/types/permission_types/base_permission_type_spec.rb + - spec/graphql/types/project_type_spec.rb + - spec/graphql/types/range_input_type_spec.rb + - spec/helpers/blame_helper_spec.rb + - spec/helpers/blob_helper_spec.rb + - spec/helpers/ci/pipelines_helper_spec.rb + - spec/helpers/ci/status_helper_spec.rb + - spec/helpers/ci/triggers_helper_spec.rb + - spec/helpers/commits_helper_spec.rb + - spec/helpers/dev_ops_report_helper_spec.rb + - spec/helpers/diff_helper_spec.rb + - spec/helpers/emails_helper_spec.rb + - spec/helpers/environments_helper_spec.rb + - spec/helpers/form_helper_spec.rb + - spec/helpers/gitlab_routing_helper_spec.rb + - spec/helpers/integrations_helper_spec.rb + - spec/helpers/issuables_helper_spec.rb + - spec/helpers/markup_helper_spec.rb + - spec/helpers/merge_requests_helper_spec.rb + - spec/helpers/notes_helper_spec.rb + - spec/helpers/numbers_helper_spec.rb + - spec/helpers/preferences_helper_spec.rb + - spec/helpers/projects_helper_spec.rb + - spec/helpers/routing/pseudonymization_helper_spec.rb + - spec/helpers/sorting_helper_spec.rb + - spec/helpers/submodule_helper_spec.rb + - spec/helpers/todos_helper_spec.rb + - spec/helpers/tree_helper_spec.rb + - spec/helpers/version_check_helper_spec.rb + - spec/initializers/doorkeeper_spec.rb + - spec/initializers/global_id_spec.rb + - spec/initializers/hangouts_chat_http_override_spec.rb + - spec/lib/api/base_spec.rb + - spec/lib/api/entities/ci/job_request/image_spec.rb + - spec/lib/api/entities/ci/job_request/port_spec.rb + - spec/lib/api/helpers/authentication_spec.rb + - spec/lib/api/helpers/caching_spec.rb + - spec/lib/api/helpers/graphql_helpers_spec.rb + - spec/lib/api/helpers/pagination_spec.rb + - spec/lib/api/helpers/pagination_strategies_spec.rb + - spec/lib/api/helpers/sse_helpers_spec.rb + - spec/lib/api/helpers/variables_helpers_spec.rb + - spec/lib/api/helpers_spec.rb + - spec/lib/atlassian/jira_connect/client_spec.rb + - spec/lib/backup/files_spec.rb + - spec/lib/backup/gitaly_rpc_backup_spec.rb + - spec/lib/backup/repositories_spec.rb + - spec/lib/banzai/cross_project_reference_spec.rb + - spec/lib/banzai/filter/gollum_tags_filter_spec.rb + - spec/lib/banzai/filter/repository_link_filter_spec.rb + - spec/lib/banzai/pipeline/wiki_pipeline_spec.rb + - spec/lib/banzai/querying_spec.rb + - spec/lib/banzai/reference_parser/base_parser_spec.rb + - spec/lib/banzai/reference_parser/commit_parser_spec.rb + - spec/lib/banzai/reference_parser/commit_range_parser_spec.rb + - spec/lib/banzai/render_context_spec.rb + - spec/lib/banzai/renderer_spec.rb + - spec/lib/bitbucket/connection_spec.rb + - spec/lib/bitbucket/paginator_spec.rb + - spec/lib/bitbucket_server/paginator_spec.rb + - spec/lib/bulk_imports/clients/http_spec.rb + - spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb + - spec/lib/bulk_imports/common/extractors/rest_extractor_spec.rb + - spec/lib/bulk_imports/ndjson_pipeline_spec.rb + - spec/lib/bulk_imports/network_error_spec.rb + - spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb + - spec/lib/bulk_imports/projects/transformers/project_attributes_transformer_spec.rb + - spec/lib/constraints/admin_constrainer_spec.rb + - spec/lib/constraints/feature_constrainer_spec.rb + - spec/lib/constraints/group_url_constrainer_spec.rb + - spec/lib/constraints/jira_encoded_url_constrainer_spec.rb + - spec/lib/constraints/project_url_constrainer_spec.rb + - spec/lib/constraints/user_url_constrainer_spec.rb + - spec/lib/csv_builder_spec.rb + - spec/lib/csv_builders/stream_spec.rb + - spec/lib/error_tracking/collector/dsn_spec.rb + - spec/lib/error_tracking/collector/sentry_auth_parser_spec.rb + - spec/lib/error_tracking/collector/sentry_request_parser_spec.rb + - spec/lib/error_tracking/sentry_client/issue_spec.rb + - spec/lib/extracts_path_spec.rb + - spec/lib/feature_spec.rb + - spec/lib/gitaly/server_spec.rb + - spec/lib/gitlab/api_authentication/token_locator_spec.rb + - spec/lib/gitlab/application_context_spec.rb + - spec/lib/gitlab/application_rate_limiter_spec.rb + - spec/lib/gitlab/asciidoc/include_processor_spec.rb + - spec/lib/gitlab/auth/auth_finders_spec.rb + - spec/lib/gitlab/auth/blocked_user_tracker_spec.rb + - spec/lib/gitlab/auth/ldap/adapter_spec.rb + - spec/lib/gitlab/auth/ldap/authentication_spec.rb + - spec/lib/gitlab/authorized_keys_spec.rb + - spec/lib/gitlab/avatar_cache_spec.rb + - spec/lib/gitlab/background_migration/base_job_spec.rb + - spec/lib/gitlab/background_migration/batching_strategies/base_strategy_spec.rb + - spec/lib/gitlab/background_migration/fix_merge_request_diff_commit_users_spec.rb + - spec/lib/gitlab/background_migration/job_coordinator_spec.rb + - spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb + - spec/lib/gitlab/background_migration_spec.rb + - spec/lib/gitlab/bitbucket_import/importer_spec.rb + - spec/lib/gitlab/bitbucket_import/project_creator_spec.rb + - spec/lib/gitlab/bitbucket_server_import/importer_spec.rb + - spec/lib/gitlab/cache/import/caching_spec.rb + - spec/lib/gitlab/changelog/committer_spec.rb + - spec/lib/gitlab/chat/responder/base_spec.rb + - spec/lib/gitlab/chat/responder_spec.rb + - spec/lib/gitlab/ci/badge/coverage/metadata_spec.rb + - spec/lib/gitlab/ci/badge/coverage/template_spec.rb + - spec/lib/gitlab/ci/badge/pipeline/metadata_spec.rb + - spec/lib/gitlab/ci/badge/pipeline/template_spec.rb + - spec/lib/gitlab/ci/build/cache_spec.rb + - spec/lib/gitlab/ci/build/policy/changes_spec.rb + - spec/lib/gitlab/ci/build/policy/variables_spec.rb + - spec/lib/gitlab/ci/build/policy_spec.rb + - spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb + - spec/lib/gitlab/ci/build/rules/rule/clause/changes_spec.rb + - spec/lib/gitlab/ci/build/rules/rule_spec.rb + - spec/lib/gitlab/ci/build/rules_spec.rb + - spec/lib/gitlab/ci/build/status/reason_spec.rb + - spec/lib/gitlab/ci/config/entry/default_spec.rb + - spec/lib/gitlab/ci/config/entry/job_spec.rb + - spec/lib/gitlab/ci/config/entry/processable_spec.rb + - spec/lib/gitlab/ci/config/external/context_spec.rb + - spec/lib/gitlab/ci/config/external/file/local_spec.rb + - spec/lib/gitlab/ci/config/external/file/project_spec.rb + - spec/lib/gitlab/ci/config/external/rules_spec.rb + - spec/lib/gitlab/ci/parsers/test/junit_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/command_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/evaluate_workflow_rules_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/remove_unwanted_chat_jobs_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/sequence_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/skip_spec.rb + - spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb + - spec/lib/gitlab/ci/pipeline/expression/lexeme/and_spec.rb + - spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb + - spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb + - spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb + - spec/lib/gitlab/ci/pipeline/expression/lexeme/not_matches_spec.rb + - spec/lib/gitlab/ci/pipeline/expression/lexeme/or_spec.rb + - spec/lib/gitlab/ci/pipeline/preloader_spec.rb + - spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb + - spec/lib/gitlab/ci/pipeline/seed/build_spec.rb + - spec/lib/gitlab/ci/reports/security/report_spec.rb + - spec/lib/gitlab/ci/status/build/action_spec.rb + - spec/lib/gitlab/ci/status/build/cancelable_spec.rb + - spec/lib/gitlab/ci/status/build/canceled_spec.rb + - spec/lib/gitlab/ci/status/build/created_spec.rb + - spec/lib/gitlab/ci/status/build/erased_spec.rb + - spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb + - spec/lib/gitlab/ci/status/build/failed_spec.rb + - spec/lib/gitlab/ci/status/build/pending_spec.rb + - spec/lib/gitlab/ci/status/build/preparing_spec.rb + - spec/lib/gitlab/ci/status/build/retried_spec.rb + - spec/lib/gitlab/ci/status/build/retryable_spec.rb + - spec/lib/gitlab/ci/status/build/skipped_spec.rb + - spec/lib/gitlab/ci/status/build/stop_spec.rb + - spec/lib/gitlab/ci/status/build/unschedule_spec.rb + - spec/lib/gitlab/ci/status/canceled_spec.rb + - spec/lib/gitlab/ci/status/core_spec.rb + - spec/lib/gitlab/ci/status/created_spec.rb + - spec/lib/gitlab/ci/status/factory_spec.rb + - spec/lib/gitlab/ci/status/failed_spec.rb + - spec/lib/gitlab/ci/status/manual_spec.rb + - spec/lib/gitlab/ci/status/pending_spec.rb + - spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb + - spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb + - spec/lib/gitlab/ci/status/preparing_spec.rb + - spec/lib/gitlab/ci/status/running_spec.rb + - spec/lib/gitlab/ci/status/scheduled_spec.rb + - spec/lib/gitlab/ci/status/skipped_spec.rb + - spec/lib/gitlab/ci/status/stage/play_manual_spec.rb + - spec/lib/gitlab/ci/status/success_spec.rb + - spec/lib/gitlab/ci/status/success_warning_spec.rb + - spec/lib/gitlab/ci/status/waiting_for_resource_spec.rb + - spec/lib/gitlab/ci/trace/archive_spec.rb + - spec/lib/gitlab/ci/trace/remote_checksum_spec.rb + - spec/lib/gitlab/ci/trace/stream_spec.rb + - spec/lib/gitlab/ci/variables/builder_spec.rb + - spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb + - spec/lib/gitlab/cleanup/project_uploads_spec.rb + - spec/lib/gitlab/cleanup/remote_uploads_spec.rb + - spec/lib/gitlab/cluster/puma_worker_killer_observer_spec.rb + - spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb + - spec/lib/gitlab/color_schemes_spec.rb + - spec/lib/gitlab/conan_token_spec.rb + - spec/lib/gitlab/config/entry/configurable_spec.rb + - spec/lib/gitlab/config/entry/factory_spec.rb + - spec/lib/gitlab/config/entry/simplifiable_spec.rb + - spec/lib/gitlab/config/entry/unspecified_spec.rb + - spec/lib/gitlab/config/entry/validator_spec.rb + - spec/lib/gitlab/conflict/file_spec.rb + - spec/lib/gitlab/cross_project_access/check_collection_spec.rb + - spec/lib/gitlab/database/async_indexes_spec.rb + - spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb + - spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb + - spec/lib/gitlab/database/batch_count_spec.rb + - spec/lib/gitlab/database/count_spec.rb + - spec/lib/gitlab/database/each_database_spec.rb + - spec/lib/gitlab/database/load_balancing/configuration_spec.rb + - spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb + - spec/lib/gitlab/database/load_balancing/host_list_spec.rb + - spec/lib/gitlab/database/load_balancing/host_spec.rb + - spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb + - spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb + - spec/lib/gitlab/database/load_balancing/resolver_spec.rb + - spec/lib/gitlab/database/load_balancing/service_discovery_spec.rb + - spec/lib/gitlab/database/load_balancing/setup_spec.rb + - spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb + - spec/lib/gitlab/database/load_balancing_spec.rb + - spec/lib/gitlab/database/migration_helpers_spec.rb + - spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb + - spec/lib/gitlab/database/migrations/instrumentation_spec.rb + - spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb + - spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb + - spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb + - spec/lib/gitlab/database/migrations/runner_spec.rb + - spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb + - spec/lib/gitlab/database/partitioning/partition_manager_spec.rb + - spec/lib/gitlab/database/partitioning/partition_monitoring_spec.rb + - spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb + - spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb + - spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb + - spec/lib/gitlab/database/partitioning_spec.rb + - spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb + - spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb + - spec/lib/gitlab/database/query_analyzer_spec.rb + - spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb + - spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb + - spec/lib/gitlab/database/shared_model_spec.rb + - spec/lib/gitlab/database_spec.rb + - spec/lib/gitlab/diff/file_collection_sorter_spec.rb + - spec/lib/gitlab/diff/file_spec.rb + - spec/lib/gitlab/diff/line_spec.rb + - spec/lib/gitlab/diff/position_tracer_spec.rb + - spec/lib/gitlab/doctor/secrets_spec.rb + - spec/lib/gitlab/email/handler/service_desk_handler_spec.rb + - spec/lib/gitlab/email/receiver_spec.rb + - spec/lib/gitlab/email/service_desk_receiver_spec.rb + - spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb + - spec/lib/gitlab/error_tracking_spec.rb + - spec/lib/gitlab/etag_caching/middleware_spec.rb + - spec/lib/gitlab/etag_caching/router/graphql_spec.rb + - spec/lib/gitlab/etag_caching/router/rails_spec.rb + - spec/lib/gitlab/etag_caching/router_spec.rb + - spec/lib/gitlab/event_store/store_spec.rb + - spec/lib/gitlab/experiment/rollout/feature_spec.rb + - spec/lib/gitlab/experimentation/controller_concern_spec.rb + - spec/lib/gitlab/experimentation/experiment_spec.rb + - spec/lib/gitlab/experimentation_spec.rb + - spec/lib/gitlab/external_authorization/access_spec.rb + - spec/lib/gitlab/external_authorization/logger_spec.rb + - spec/lib/gitlab/faraday/error_callback_spec.rb + - spec/lib/gitlab/feature_categories_spec.rb + - spec/lib/gitlab/git/blob_spec.rb + - spec/lib/gitlab/git/commit_spec.rb + - spec/lib/gitlab/git/repository_spec.rb + - spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb + - spec/lib/gitlab/git/tag_spec.rb + - spec/lib/gitlab/git_access_snippet_spec.rb + - spec/lib/gitlab/gitaly_client/commit_service_spec.rb + - spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb + - spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb + - spec/lib/gitlab/gitaly_client/health_check_service_spec.rb + - spec/lib/gitlab/gitaly_client/ref_service_spec.rb + - spec/lib/gitlab/gitaly_client/remote_service_spec.rb + - spec/lib/gitlab/gitaly_client/repository_service_spec.rb + - spec/lib/gitlab/gitaly_client_spec.rb + - spec/lib/gitlab/github_import/bulk_importing_spec.rb + - spec/lib/gitlab/github_import/client_spec.rb + - spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb + - spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb + - spec/lib/gitlab/github_import/importer/issue_and_label_links_importer_spec.rb + - spec/lib/gitlab/github_import/importer/issue_importer_spec.rb + - spec/lib/gitlab/github_import/importer/issues_importer_spec.rb + - spec/lib/gitlab/github_import/importer/label_links_importer_spec.rb + - spec/lib/gitlab/github_import/importer/labels_importer_spec.rb + - spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb + - spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb + - spec/lib/gitlab/github_import/importer/note_importer_spec.rb + - spec/lib/gitlab/github_import/importer/notes_importer_spec.rb + - spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb + - spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb + - spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb + - spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb + - spec/lib/gitlab/github_import/importer/pull_requests_merged_by_importer_spec.rb + - spec/lib/gitlab/github_import/importer/pull_requests_reviews_importer_spec.rb + - spec/lib/gitlab/github_import/importer/releases_importer_spec.rb + - spec/lib/gitlab/github_import/importer/repository_importer_spec.rb + - spec/lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer_spec.rb + - spec/lib/gitlab/github_import/importer/single_endpoint_issue_notes_importer_spec.rb + - spec/lib/gitlab/github_import/importer/single_endpoint_merge_request_notes_importer_spec.rb + - spec/lib/gitlab/github_import/issuable_finder_spec.rb + - spec/lib/gitlab/github_import/markdown_text_spec.rb + - spec/lib/gitlab/github_import/milestone_finder_spec.rb + - spec/lib/gitlab/github_import/object_counter_spec.rb + - spec/lib/gitlab/github_import/page_counter_spec.rb + - spec/lib/gitlab/github_import/parallel_importer_spec.rb + - spec/lib/gitlab/github_import/parallel_scheduling_spec.rb + - spec/lib/gitlab/github_import/representation/diff_note_spec.rb + - spec/lib/gitlab/github_import/representation/issue_spec.rb + - spec/lib/gitlab/github_import/representation/note_spec.rb + - spec/lib/gitlab/github_import/representation/pull_request_review_spec.rb + - spec/lib/gitlab/github_import/representation/pull_request_spec.rb + - spec/lib/gitlab/github_import/representation/to_hash_spec.rb + - spec/lib/gitlab/github_import/representation/user_spec.rb + - spec/lib/gitlab/github_import/sequential_importer_spec.rb + - spec/lib/gitlab/github_import/user_finder_spec.rb + - spec/lib/gitlab/github_import_spec.rb + - spec/lib/gitlab/gon_helper_spec.rb + - spec/lib/gitlab/gpg/commit_spec.rb + - spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb + - spec/lib/gitlab/gpg_spec.rb + - spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb + - spec/lib/gitlab/grape_logging/loggers/perf_logger_spec.rb + - spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb + - spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb + - spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb + - spec/lib/gitlab/graphql/batch_key_spec.rb + - spec/lib/gitlab/graphql/find_argument_in_parent_spec.rb + - spec/lib/gitlab/graphql/generic_tracing_spec.rb + - spec/lib/gitlab/graphql/lazy_spec.rb + - spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb + - spec/lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition_spec.rb + - spec/lib/gitlab/graphql/pagination/keyset/conditions/null_condition_spec.rb + - spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb + - spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb + - spec/lib/gitlab/graphql/present/field_extension_spec.rb + - spec/lib/gitlab/graphql/timeout_spec.rb + - spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb + - spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb + - spec/lib/gitlab/health_checks/gitaly_check_spec.rb + - spec/lib/gitlab/hook_data/base_builder_spec.rb + - spec/lib/gitlab/hotlinking_detector_spec.rb + - spec/lib/gitlab/import/import_failure_service_spec.rb + - spec/lib/gitlab/import/metrics_spec.rb + - spec/lib/gitlab/import_export/attribute_cleaner_spec.rb + - spec/lib/gitlab/import_export/base/relation_factory_spec.rb + - spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb + - spec/lib/gitlab/import_export/group/relation_factory_spec.rb + - spec/lib/gitlab/import_export/importer_spec.rb + - spec/lib/gitlab/import_export/project/relation_factory_spec.rb + - spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb + - spec/lib/gitlab/import_export/project/tree_saver_spec.rb + - spec/lib/gitlab/issuables_count_for_state_spec.rb + - spec/lib/gitlab/issues/rebalancing/state_spec.rb + - spec/lib/gitlab/jira/middleware_spec.rb + - spec/lib/gitlab/jira_import/issue_serializer_spec.rb + - spec/lib/gitlab/jira_import/labels_importer_spec.rb + - spec/lib/gitlab/jira_import/metadata_collector_spec.rb + - spec/lib/gitlab/jira_import_spec.rb + - spec/lib/gitlab/job_waiter_spec.rb + - spec/lib/gitlab/json_cache_spec.rb + - spec/lib/gitlab/kas/client_spec.rb + - spec/lib/gitlab/kubernetes/config_map_spec.rb + - spec/lib/gitlab/kubernetes/default_namespace_spec.rb + - spec/lib/gitlab/kubernetes/helm/api_spec.rb + - spec/lib/gitlab/kubernetes/namespace_spec.rb + - spec/lib/gitlab/lazy_spec.rb + - spec/lib/gitlab/legacy_github_import/branch_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/comment_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/importer_spec.rb + - spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/release_formatter_spec.rb + - spec/lib/gitlab/legacy_github_import/user_formatter_spec.rb + - spec/lib/gitlab/lets_encrypt/client_spec.rb + - spec/lib/gitlab/mail_room/mail_room_spec.rb + - spec/lib/gitlab/manifest_import/metadata_spec.rb + - spec/lib/gitlab/markdown_cache/field_data_spec.rb + - spec/lib/gitlab/merge_requests/commit_message_generator_spec.rb + - spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb + - spec/lib/gitlab/metrics/boot_time_tracker_spec.rb + - spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb + - spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb + - spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb + - spec/lib/gitlab/metrics/exporter/gc_request_middleware_spec.rb + - spec/lib/gitlab/metrics/exporter/health_checks_middleware_spec.rb + - spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb + - spec/lib/gitlab/metrics/rack_middleware_spec.rb + - spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb + - spec/lib/gitlab/metrics/samplers/database_sampler_spec.rb + - spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb + - spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb + - spec/lib/gitlab/metrics/sli_spec.rb + - spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb + - spec/lib/gitlab/metrics/subscribers/action_view_spec.rb + - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb + - spec/lib/gitlab/metrics/subscribers/external_http_spec.rb + - spec/lib/gitlab/metrics/subscribers/load_balancing_spec.rb + - spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb + - spec/lib/gitlab/metrics/subscribers/rails_cache_spec.rb + - spec/lib/gitlab/metrics/web_transaction_spec.rb + - spec/lib/gitlab/middleware/basic_health_check_spec.rb + - spec/lib/gitlab/middleware/compressed_json_spec.rb + - spec/lib/gitlab/middleware/go_spec.rb + - spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb + - spec/lib/gitlab/middleware/multipart_spec.rb + - spec/lib/gitlab/middleware/query_analyzer_spec.rb + - spec/lib/gitlab/middleware/rails_queue_duration_spec.rb + - spec/lib/gitlab/middleware/release_env_spec.rb + - spec/lib/gitlab/middleware/sidekiq_web_static_spec.rb + - spec/lib/gitlab/middleware/speedscope_spec.rb + - spec/lib/gitlab/middleware/webhook_recursion_detection_spec.rb + - spec/lib/gitlab/octokit/middleware_spec.rb + - spec/lib/gitlab/optimistic_locking_spec.rb + - spec/lib/gitlab/pages/settings_spec.rb + - spec/lib/gitlab/pagination/cursor_based_keyset_spec.rb + - spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb + - spec/lib/gitlab/pagination/keyset/cursor_based_request_context_spec.rb + - spec/lib/gitlab/pagination/keyset/cursor_pager_spec.rb + - spec/lib/gitlab/pagination/keyset/pager_spec.rb + - spec/lib/gitlab/pagination/keyset/request_context_spec.rb + - spec/lib/gitlab/pagination/keyset_spec.rb + - spec/lib/gitlab/pagination/offset_header_builder_spec.rb + - spec/lib/gitlab/pagination/offset_pagination_spec.rb + - spec/lib/gitlab/performance_bar/stats_spec.rb + - spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb + - spec/lib/gitlab/phabricator_import/conduit/response_spec.rb + - spec/lib/gitlab/phabricator_import/conduit/user_spec.rb + - spec/lib/gitlab/polling_interval_spec.rb + - spec/lib/gitlab/popen/runner_spec.rb + - spec/lib/gitlab/process_management_spec.rb + - spec/lib/gitlab/profiler_spec.rb + - spec/lib/gitlab/prometheus/adapter_spec.rb + - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb + - spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb + - spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb + - spec/lib/gitlab/query_limiting/middleware_spec.rb + - spec/lib/gitlab/quick_actions/dsl_spec.rb + - spec/lib/gitlab/repository_cache_spec.rb + - spec/lib/gitlab/routing_spec.rb + - spec/lib/gitlab/runtime_spec.rb + - spec/lib/gitlab/sanitizers/svg_spec.rb + - spec/lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator_spec.rb + - spec/lib/gitlab/search/abuse_validators/no_abusive_term_length_validator_spec.rb + - spec/lib/gitlab/serializer/pagination_spec.rb + - spec/lib/gitlab/sidekiq_config/cli_methods_spec.rb + - spec/lib/gitlab/sidekiq_config/worker_spec.rb + - spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb + - spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb + - spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb + - spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb + - spec/lib/gitlab/sidekiq_middleware_spec.rb + - spec/lib/gitlab/sidekiq_status/client_middleware_spec.rb + - spec/lib/gitlab/sidekiq_status/server_middleware_spec.rb + - spec/lib/gitlab/slash_commands/command_spec.rb + - spec/lib/gitlab/slash_commands/deploy_spec.rb + - spec/lib/gitlab/slash_commands/issue_close_spec.rb + - spec/lib/gitlab/slash_commands/issue_comment_spec.rb + - spec/lib/gitlab/slash_commands/issue_new_spec.rb + - spec/lib/gitlab/slash_commands/issue_search_spec.rb + - spec/lib/gitlab/slash_commands/issue_show_spec.rb + - spec/lib/gitlab/slash_commands/presenters/run_spec.rb + - spec/lib/gitlab/slash_commands/run_spec.rb + - spec/lib/gitlab/spamcheck/client_spec.rb + - spec/lib/gitlab/submodule_links_spec.rb + - spec/lib/gitlab/suggestions/file_suggestion_spec.rb + - spec/lib/gitlab/tab_width_spec.rb + - spec/lib/gitlab/themes_spec.rb + - spec/lib/gitlab/tracking_spec.rb + - spec/lib/gitlab/usage/metric_spec.rb + - spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb + - spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb + - spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb + - spec/lib/gitlab/usage_data_spec.rb + - spec/lib/gitlab/utils/usage_data_spec.rb + - spec/lib/gitlab/verify/job_artifacts_spec.rb + - spec/lib/gitlab/verify/lfs_objects_spec.rb + - spec/lib/gitlab/verify/uploads_spec.rb + - spec/lib/gitlab/view/presenter/base_spec.rb + - spec/lib/gitlab/view/presenter/delegated_spec.rb + - spec/lib/gitlab/view/presenter/simple_spec.rb + - spec/lib/gitlab/workhorse_spec.rb + - spec/lib/gitlab_edition_spec.rb + - spec/lib/gitlab_spec.rb + - spec/lib/google_api/cloud_platform/client_spec.rb + - spec/lib/peek/views/active_record_spec.rb + - spec/lib/peek/views/bullet_detailed_spec.rb + - spec/lib/peek/views/external_http_spec.rb + - spec/lib/safe_zip/entry_spec.rb + - spec/lib/serializers/unsafe_json_spec.rb + - spec/lib/sidebars/projects/menus/analytics_menu_spec.rb + - spec/mailers/emails/service_desk_spec.rb + - spec/mailers/notify_spec.rb + - spec/metrics_server/metrics_server_spec.rb + - spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb + - spec/models/active_session_spec.rb + - spec/models/application_record_spec.rb + - spec/models/badge_spec.rb + - spec/models/badges/project_badge_spec.rb + - spec/models/bulk_imports/export_status_spec.rb + - spec/models/ci/build_spec.rb + - spec/models/ci/build_trace_chunk_spec.rb + - spec/models/ci/commit_with_pipeline_spec.rb + - spec/models/ci/group_spec.rb + - spec/models/ci/pipeline_spec.rb + - spec/models/clusters/applications/runner_spec.rb + - spec/models/clusters/cluster_spec.rb + - spec/models/clusters/platforms/kubernetes_spec.rb + - spec/models/commit_signatures/gpg_signature_spec.rb + - spec/models/commit_spec.rb + - spec/models/commit_status_spec.rb + - spec/models/concerns/atomic_internal_id_spec.rb + - spec/models/concerns/legacy_bulk_insert_spec.rb + - spec/models/concerns/prometheus_adapter_spec.rb + - spec/models/concerns/sha256_attribute_spec.rb + - spec/models/concerns/sha_attribute_spec.rb + - spec/models/concerns/token_authenticatable_strategies/base_spec.rb + - spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb + - spec/models/concerns/triggerable_hooks_spec.rb + - spec/models/concerns/x509_serial_number_attribute_spec.rb + - spec/models/design_management/design_action_spec.rb + - spec/models/design_management/design_at_version_spec.rb + - spec/models/diff_viewer/image_spec.rb + - spec/models/environment_spec.rb + - spec/models/error_tracking/project_error_tracking_setting_spec.rb + - spec/models/event_spec.rb + - spec/models/external_issue_spec.rb + - spec/models/hooks/web_hook_spec.rb + - spec/models/integrations/asana_spec.rb + - spec/models/integrations/chat_message/pipeline_message_spec.rb + - spec/models/integrations/jira_spec.rb + - spec/models/integrations/microsoft_teams_spec.rb + - spec/models/integrations/pipelines_email_spec.rb + - spec/models/issue_spec.rb + - spec/models/key_spec.rb + - spec/models/merge_request_diff_commit_spec.rb + - spec/models/merge_request_spec.rb + - spec/models/packages/package_spec.rb + - spec/models/plan_limits_spec.rb + - spec/models/project_import_state_spec.rb + - spec/models/project_spec.rb + - spec/models/ref_matcher_spec.rb + - spec/models/release_highlight_spec.rb + - spec/models/repository_spec.rb + - spec/models/shard_spec.rb + - spec/models/snippet_spec.rb + - spec/models/ssh_host_key_spec.rb + - spec/models/upload_spec.rb + - spec/models/user_spec.rb + - spec/policies/ci/bridge_policy_spec.rb + - spec/presenters/ci/build_presenter_spec.rb + - spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb + - spec/presenters/group_member_presenter_spec.rb + - spec/presenters/merge_request_presenter_spec.rb + - spec/presenters/packages/nuget/search_results_presenter_spec.rb + - spec/presenters/project_member_presenter_spec.rb + - spec/presenters/project_presenter_spec.rb + - spec/requests/api/avatar_spec.rb + - spec/requests/api/container_registry_event_spec.rb + - spec/requests/api/graphql/mutations/design_management/delete_spec.rb + - spec/requests/api/graphql/mutations/snippets/create_spec.rb + - spec/requests/api/graphql/project/cluster_agents_spec.rb + - spec/requests/api/graphql/project/pipeline_spec.rb + - spec/requests/api/helpers_spec.rb + - spec/requests/api/import_bitbucket_server_spec.rb + - spec/requests/api/import_github_spec.rb + - spec/requests/api/internal/base_spec.rb + - spec/requests/api/maven_packages_spec.rb + - spec/requests/api/project_container_repositories_spec.rb + - spec/requests/api/users_preferences_spec.rb + - spec/requests/jwt_controller_spec.rb + - spec/requests/whats_new_controller_spec.rb + - spec/rubocop/migration_helpers_spec.rb + - spec/scripts/setup/find_jh_branch_spec.rb + - spec/serializers/accessibility_reports_comparer_serializer_spec.rb + - spec/serializers/admin/user_entity_spec.rb + - spec/serializers/base_discussion_entity_spec.rb + - spec/serializers/build_action_entity_spec.rb + - spec/serializers/build_details_entity_spec.rb + - spec/serializers/build_trace_entity_spec.rb + - spec/serializers/ci/dag_job_entity_spec.rb + - spec/serializers/ci/dag_job_group_entity_spec.rb + - spec/serializers/ci/dag_pipeline_entity_spec.rb + - spec/serializers/ci/dag_stage_entity_spec.rb + - spec/serializers/ci/daily_build_group_report_result_entity_spec.rb + - spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb + - spec/serializers/ci/job_entity_spec.rb + - spec/serializers/ci/job_serializer_spec.rb + - spec/serializers/ci/pipeline_entity_spec.rb + - spec/serializers/codequality_reports_comparer_serializer_spec.rb + - spec/serializers/commit_entity_spec.rb + - spec/serializers/container_repositories_serializer_spec.rb + - spec/serializers/container_repository_entity_spec.rb + - spec/serializers/container_tag_entity_spec.rb + - spec/serializers/deployment_cluster_entity_spec.rb + - spec/serializers/deployment_entity_spec.rb + - spec/serializers/detailed_status_entity_spec.rb + - spec/serializers/diff_file_entity_spec.rb + - spec/serializers/diffs_entity_spec.rb + - spec/serializers/diffs_metadata_entity_spec.rb + - spec/serializers/discussion_entity_spec.rb + - spec/serializers/environment_entity_spec.rb + - spec/serializers/environment_serializer_spec.rb + - spec/serializers/environment_status_entity_spec.rb + - spec/serializers/feature_flag_entity_spec.rb + - spec/serializers/feature_flag_summary_entity_spec.rb + - spec/serializers/group_child_entity_spec.rb + - spec/serializers/group_child_serializer_spec.rb + - spec/serializers/import/manifest_provider_repo_entity_spec.rb + - spec/serializers/issuable_sidebar_extras_entity_spec.rb + - spec/serializers/issue_board_entity_spec.rb + - spec/serializers/issue_entity_spec.rb + - spec/serializers/lfs_file_lock_entity_spec.rb + - spec/serializers/linked_project_issue_entity_spec.rb + - spec/serializers/merge_request_poll_cached_widget_entity_spec.rb + - spec/serializers/merge_request_poll_widget_entity_spec.rb + - spec/serializers/merge_request_sidebar_basic_entity_spec.rb + - spec/serializers/merge_request_sidebar_extras_entity_spec.rb + - spec/serializers/merge_request_widget_commit_entity_spec.rb + - spec/serializers/merge_request_widget_entity_spec.rb + - spec/serializers/merge_requests/pipeline_entity_spec.rb + - spec/serializers/note_entity_spec.rb + - spec/serializers/paginated_diff_entity_spec.rb + - spec/serializers/pipeline_details_entity_spec.rb + - spec/serializers/pipeline_serializer_spec.rb + - spec/serializers/project_note_entity_spec.rb + - spec/serializers/prometheus_alert_entity_spec.rb + - spec/serializers/review_app_setup_entity_spec.rb + - spec/serializers/runner_entity_spec.rb + - spec/serializers/service_event_entity_spec.rb + - spec/serializers/service_field_entity_spec.rb + - spec/serializers/stage_entity_spec.rb + - spec/serializers/suggestion_entity_spec.rb + - spec/serializers/test_reports_comparer_serializer_spec.rb + - spec/serializers/test_suite_entity_spec.rb + - spec/serializers/trigger_variable_entity_spec.rb + - spec/services/access_token_validation_service_spec.rb + - spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb + - spec/services/award_emojis/toggle_service_spec.rb + - spec/services/base_count_service_spec.rb + - spec/services/bulk_imports/file_download_service_spec.rb + - spec/services/ci/change_variables_service_spec.rb + - spec/services/ci/create_pipeline_service_spec.rb + - spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb + - spec/services/ci/prepare_build_service_spec.rb + - spec/services/ci/process_pipeline_service_spec.rb + - spec/services/ci/register_job_service_spec.rb + - spec/services/ci/test_failure_history_service_spec.rb + - spec/services/ci/update_build_queue_service_spec.rb + - spec/services/ci/update_build_state_service_spec.rb + - spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb + - spec/services/clusters/applications/create_service_spec.rb + - spec/services/clusters/applications/prometheus_update_service_spec.rb + - spec/services/clusters/applications/update_service_spec.rb + - spec/services/clusters/aws/finalize_creation_service_spec.rb + - spec/services/clusters/aws/provision_service_spec.rb + - spec/services/clusters/aws/verify_provision_status_service_spec.rb + - spec/services/clusters/build_kubernetes_namespace_service_spec.rb + - spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb + - spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb + - spec/services/container_expiration_policies/cleanup_service_spec.rb + - spec/services/deployments/create_service_spec.rb + - spec/services/discussions/capture_diff_note_position_service_spec.rb + - spec/services/error_tracking/base_service_spec.rb + - spec/services/error_tracking/issue_update_service_spec.rb + - spec/services/event_create_service_spec.rb + - spec/services/git/base_hooks_service_spec.rb + - spec/services/git/process_ref_changes_service_spec.rb + - spec/services/git/wiki_push_service/change_spec.rb + - spec/services/ide/schemas_config_service_spec.rb + - spec/services/import/bitbucket_server_service_spec.rb + - spec/services/import/github_service_spec.rb + - spec/services/import/gitlab_projects/create_project_from_remote_file_service_spec.rb + - spec/services/issues/create_service_spec.rb + - spec/services/issues/related_branches_service_spec.rb + - spec/services/jira_connect_subscriptions/create_service_spec.rb + - spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb + - spec/services/merge_requests/approval_service_spec.rb + - spec/services/merge_requests/build_service_spec.rb + - spec/services/merge_requests/close_service_spec.rb + - spec/services/merge_requests/merge_service_spec.rb + - spec/services/merge_requests/post_merge_service_spec.rb + - spec/services/merge_requests/refresh_service_spec.rb + - spec/services/merge_requests/reopen_service_spec.rb + - spec/services/merge_requests/request_review_service_spec.rb + - spec/services/merge_requests/toggle_attention_requested_service_spec.rb + - spec/services/metrics/dashboard/clone_dashboard_service_spec.rb + - spec/services/metrics/dashboard/update_dashboard_service_spec.rb + - spec/services/metrics/users_starred_dashboards/create_service_spec.rb + - spec/services/milestones/update_service_spec.rb + - spec/services/namespaces/in_product_marketing_emails_service_spec.rb + - spec/services/namespaces/invite_team_email_service_spec.rb + - spec/services/notes/create_service_spec.rb + - spec/services/notes/render_service_spec.rb + - spec/services/notification_service_spec.rb + - spec/services/packages/generic/create_package_file_service_spec.rb + - spec/services/packages/maven/find_or_create_package_service_spec.rb + - spec/services/packages/maven/metadata/sync_service_spec.rb + - spec/services/packages/nuget/metadata_extraction_service_spec.rb + - spec/services/pages/zip_directory_service_spec.rb + - spec/services/post_receive_service_spec.rb + - spec/services/projects/after_import_service_spec.rb + - spec/services/projects/branches_by_mode_service_spec.rb + - spec/services/projects/create_service_spec.rb + - spec/services/projects/destroy_service_spec.rb + - spec/services/projects/import_service_spec.rb + - spec/services/projects/operations/update_service_spec.rb + - spec/services/projects/overwrite_project_service_spec.rb + - spec/services/projects/update_pages_service_spec.rb + - spec/services/projects/update_remote_mirror_service_spec.rb + - spec/services/projects/update_repository_storage_service_spec.rb + - spec/services/projects/update_service_spec.rb + - spec/services/repositories/changelog_service_spec.rb + - spec/services/search_service_spec.rb + - spec/services/service_ping/build_payload_service_spec.rb + - spec/services/service_ping/permit_data_categories_service_spec.rb + - spec/services/service_ping/service_ping_settings_spec.rb + - spec/services/service_ping/submit_service_ping_service_spec.rb + - spec/services/snippets/update_repository_storage_service_spec.rb + - spec/services/spam/akismet_mark_as_spam_service_spec.rb + - spec/services/spam/akismet_service_spec.rb + - spec/services/spam/ham_service_spec.rb + - spec/services/spam/spam_action_service_spec.rb + - spec/services/spam/spam_params_spec.rb + - spec/services/static_site_editor/config_service_spec.rb + - spec/services/system_note_service_spec.rb + - spec/services/system_notes/commit_service_spec.rb + - spec/services/system_notes/issuables_service_spec.rb + - spec/services/update_merge_request_metrics_service_spec.rb + - spec/services/users/activity_service_spec.rb + - spec/services/users/create_service_spec.rb + - spec/services/users/refresh_authorized_projects_service_spec.rb + - spec/services/users/update_service_spec.rb + - spec/services/web_hook_service_spec.rb + - spec/services/wiki_pages/base_service_spec.rb + - spec/spam/concerns/has_spam_action_response_fields_spec.rb + - spec/support/helpers/graphql_helpers.rb + - spec/support/helpers/import_spec_helper.rb + - spec/support/helpers/ldap_helpers.rb + - spec/support/helpers/project_forks_helper.rb + - spec/support/helpers/stub_metrics.rb + - spec/support/helpers/stub_spam_services.rb + - spec/support/import_export/common_util.rb + - spec/support/prometheus/additional_metrics_shared_examples.rb + - spec/support/shared_contexts/lib/gitlab/sidekiq_middleware/server_metrics_shared_context.rb + - spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb + - spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb + - spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb + - spec/support/shared_examples/graphql/mutations/http_integrations_shared_examples.rb + - spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb + - spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb + - spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb + - spec/support/shared_examples/metrics/sampler_shared_examples.rb + - spec/support/shared_examples/models/chat_integration_shared_examples.rb + - spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb + - spec/support/shared_examples/models/members_notifications_shared_example.rb + - spec/support/shared_examples/models/project_ci_cd_settings_shared_examples.rb + - spec/support/shared_examples/namespaces/hierarchy_examples.rb + - spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb + - spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb + - spec/support/shared_examples/requests/api/debian_common_shared_examples.rb + - spec/support/shared_examples/requests/api/nuget_endpoints_shared_examples.rb + - spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb + - spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb + - spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb + - spec/support/shared_examples/requests/rack_attack_shared_examples.rb + - spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb + - spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb + - spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb + - spec/support/shared_examples/services/alert_management/alert_processing/notifications_shared_examples.rb + - spec/support/shared_examples/services/alert_management_shared_examples.rb + - spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb + - spec/support/shared_examples/services/check_ingress_ip_address_service_shared_examples.rb + - spec/support/shared_examples/services/jira/requests/base_shared_examples.rb + - spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb + - spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb + - spec/support/shared_examples/services/resource_events/synthetic_notes_builder_shared_examples.rb + - spec/support/shared_examples/workers/background_migration_worker_shared_examples.rb + - spec/support/shared_examples/workers/update_repository_move_shared_examples.rb + - spec/tasks/gettext_rake_spec.rb + - spec/tasks/gitlab/background_migrations_rake_spec.rb + - spec/tasks/gitlab/check_rake_spec.rb + - spec/tasks/gitlab/cleanup_rake_spec.rb + - spec/tasks/gitlab/db_rake_spec.rb + - spec/tasks/gitlab/packages/events_rake_spec.rb + - spec/tasks/gitlab/setup_rake_spec.rb + - spec/tooling/danger/project_helper_spec.rb + - spec/tooling/danger/specs_spec.rb + - spec/tooling/lib/tooling/helm3_client_spec.rb + - spec/tooling/lib/tooling/kubernetes_client_spec.rb + - spec/tooling/rspec_flaky/example_spec.rb + - spec/tooling/rspec_flaky/listener_spec.rb + - spec/uploaders/file_uploader_spec.rb + - spec/uploaders/object_storage_spec.rb + - spec/uploaders/personal_file_uploader_spec.rb + - spec/uploaders/records_uploads_spec.rb + - spec/views/projects/issues/show.html.haml_spec.rb + - spec/views/shared/milestones/_issuables.html.haml_spec.rb + - spec/views/shared/wikis/_sidebar.html.haml_spec.rb + - spec/workers/bulk_imports/export_request_worker_spec.rb + - spec/workers/bulk_imports/pipeline_worker_spec.rb + - spec/workers/chat_notification_worker_spec.rb + - spec/workers/ci/build_prepare_worker_spec.rb + - spec/workers/ci/create_cross_project_pipeline_worker_spec.rb + - spec/workers/ci/create_downstream_pipeline_worker_spec.rb + - spec/workers/ci/pipeline_bridge_status_worker_spec.rb + - spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb + - spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb + - spec/workers/clusters/agents/delete_expired_events_worker_spec.rb + - spec/workers/concerns/application_worker_spec.rb + - spec/workers/concerns/gitlab/github_import/object_importer_spec.rb + - spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb + - spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb + - spec/workers/create_commit_signature_worker_spec.rb + - spec/workers/environments/auto_stop_worker_spec.rb + - spec/workers/error_tracking_issue_link_worker_spec.rb + - spec/workers/gitlab/github_import/advance_stage_worker_spec.rb + - spec/workers/gitlab/github_import/import_diff_note_worker_spec.rb + - spec/workers/gitlab/github_import/import_issue_worker_spec.rb + - spec/workers/gitlab/github_import/import_note_worker_spec.rb + - spec/workers/gitlab/github_import/import_pull_request_worker_spec.rb + - spec/workers/gitlab/github_import/stage/finish_import_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_base_data_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_lfs_objects_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_notes_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_pull_requests_merged_by_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_pull_requests_reviews_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_pull_requests_worker_spec.rb + - spec/workers/gitlab/github_import/stage/import_repository_worker_spec.rb + - spec/workers/gitlab_performance_bar_stats_worker_spec.rb + - spec/workers/invalid_gpg_signature_update_worker_spec.rb + - spec/workers/irker_worker_spec.rb + - spec/workers/issue_rebalancing_worker_spec.rb + - spec/workers/issues/rebalancing_worker_spec.rb + - spec/workers/merge_request_mergeability_check_worker_spec.rb + - spec/workers/new_issue_worker_spec.rb + - spec/workers/new_merge_request_worker_spec.rb + - spec/workers/pages_domain_ssl_renewal_worker_spec.rb + - spec/workers/pages_domain_verification_worker_spec.rb + - spec/workers/post_receive_spec.rb + - spec/workers/project_cache_worker_spec.rb + - spec/workers/propagate_integration_group_worker_spec.rb + - spec/workers/propagate_integration_inherit_descendant_worker_spec.rb + - spec/workers/propagate_integration_inherit_worker_spec.rb + - spec/workers/propagate_integration_project_worker_spec.rb + - spec/workers/purge_dependency_proxy_cache_worker_spec.rb + - spec/workers/repository_import_worker_spec.rb + - spec/workers/system_hook_push_worker_spec.rb + - diff --git a/Gemfile b/Gemfile index 6654d53c44d..f4937d8f275 100644 --- a/Gemfile +++ b/Gemfile @@ -374,7 +374,7 @@ group :development, :test do gem 'spring', '~> 2.1.0' gem 'spring-commands-rspec', '~> 1.0.4' - gem 'gitlab-styles', '~> 6.6.0', require: false + gem 'gitlab-styles', '~> 7.0.0', require: false gem 'haml_lint', '~> 0.36.0', require: false gem 'bundler-audit', '~> 0.7.0.1', require: false diff --git a/Gemfile.lock b/Gemfile.lock index 65ee5af0dba..a946c2cb792 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -501,7 +501,7 @@ GEM openid_connect (~> 1.2) gitlab-sidekiq-fetcher (0.8.0) sidekiq (~> 6.1) - gitlab-styles (6.6.0) + gitlab-styles (7.0.0) rubocop (~> 0.91, >= 0.91.1) rubocop-gitlab-security (~> 0.1.1) rubocop-graphql (~> 0.10) @@ -1115,7 +1115,7 @@ GEM parser (>= 2.7.1.5) rubocop-gitlab-security (0.1.1) rubocop (>= 0.51) - rubocop-graphql (0.10.3) + rubocop-graphql (0.13.0) rubocop (>= 0.87, < 2) rubocop-performance (1.9.2) rubocop (>= 0.90.0, < 2.0) @@ -1489,7 +1489,7 @@ DEPENDENCIES gitlab-net-dns (~> 0.9.1) gitlab-omniauth-openid-connect (~> 0.9.0) gitlab-sidekiq-fetcher (= 0.8.0) - gitlab-styles (~> 6.6.0) + gitlab-styles (~> 7.0.0) gitlab_chronic_duration (~> 0.10.6.2) gitlab_omniauth-ldap (~> 2.1.1) gon (~> 6.4.0) diff --git a/app/models/concerns/spammable.rb b/app/models/concerns/spammable.rb index 54ce62201d7..b475eb79aa3 100644 --- a/app/models/concerns/spammable.rb +++ b/app/models/concerns/spammable.rb @@ -78,8 +78,9 @@ module Spammable end def recaptcha_error! - self.errors.add(:base, "Your #{spammable_entity_type} has been recognized as spam. "\ - "Please, change the content or solve the reCAPTCHA to proceed.") + self.errors.add(:base, _("Your %{spammable_entity_type} has been recognized as spam. "\ + "Please, change the content or solve the reCAPTCHA to proceed.") \ + % { spammable_entity_type: spammable_entity_type }) end def unrecoverable_spam_error! diff --git a/data/deprecations/14-0-nfs-fot-git-repository-storage.yml b/data/deprecations/14-0-nfs-fot-git-repository-storage.yml index fd5db7f8835..9e02524b022 100644 --- a/data/deprecations/14-0-nfs-fot-git-repository-storage.yml +++ b/data/deprecations/14-0-nfs-fot-git-repository-storage.yml @@ -1,10 +1,10 @@ -- name: "NFS for Git repository storage" # The name of the feature to be deprecated - announcement_milestone: "14.0" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-06-22" # The date of the milestone release when this feature was first announced as deprecated - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format - the date of the milestone release when this feature is planned to be removed +- name: "NFS for Git repository storage" # The name of the feature to be deprecated + announcement_milestone: "14.0" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-06-22" # The date of the milestone release when this feature was first announced as deprecated + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format - the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. With the general availability of Gitaly Cluster ([introduced in GitLab 13.0](https://about.gitlab.com/releases/2020/05/22/gitlab-13-0-released/)), we have deprecated development (bugfixes, performance improvements, etc) for NFS for Git repository storage in GitLab 14.0. We will continue to provide technical support for NFS for Git repositories throughout 14.x, but we will remove all support for NFS in GitLab 15.0. Please see our official [Statement of Support](https://about.gitlab.com/support/statement-of-support.html#gitaly-and-nfs) for further information. Gitaly Cluster offers tremendous benefits for our customers such as: @@ -15,9 +15,9 @@ We encourage customers currently using NFS for Git repositories to plan their migration by reviewing our documentation on [migrating to Gitaly Cluster](https://docs.gitlab.com/ee/administration/gitaly/index.html#migrate-to-gitaly-cluster). - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-2-deprecation-release-cli.yml b/data/deprecations/14-2-deprecation-release-cli.yml index 809d8eb1e8b..fe53dea309a 100644 --- a/data/deprecations/14-2-deprecation-release-cli.yml +++ b/data/deprecations/14-2-deprecation-release-cli.yml @@ -1,14 +1,14 @@ -- name: "Release CLI distributed as a generic package" # The name of the feature to be deprecated - announcement_milestone: "14.2" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-08-22" # The date of the milestone release when this feature was first announced as deprecated - removal_milestone: "14.6" # The milestone when this feature is planned to be removed - removal_date: "2021-12-22" # the date of the milestone release when this feature is planned to be removed +- name: "Release CLI distributed as a generic package" # The name of the feature to be deprecated + announcement_milestone: "14.2" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-08-22" # The date of the milestone release when this feature was first announced as deprecated + removal_milestone: "14.6" # The milestone when this feature is planned to be removed + removal_date: "2021-12-22" # the date of the milestone release when this feature is planned to be removed breaking_change: false - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The [release-cli](https://gitlab.com/gitlab-org/release-cli) will be released as a [generic package](https://gitlab.com/gitlab-org/release-cli/-/packages) starting in GitLab 14.2. We will continue to deploy it as a binary to S3 until GitLab 14.5 and stop distributing it in S3 in GitLab 14.6. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-2-deprecation-task-runner.yml b/data/deprecations/14-2-deprecation-task-runner.yml index 8162b5c4d4e..1b72330c5bd 100644 --- a/data/deprecations/14-2-deprecation-task-runner.yml +++ b/data/deprecations/14-2-deprecation-task-runner.yml @@ -1,17 +1,17 @@ -- name: "Rename Task Runner pod to Toolbox" # The name of the feature to be deprecated - announcement_milestone: "14.2" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-08-22" # The date of the milestone release when this feature was first announced as deprecated - removal_milestone: "14.5" # The milestone when this feature is planned to be removed - removal_date: "2021-11-22" # the date of the milestone release when this feature is planned to be removed +- name: "Rename Task Runner pod to Toolbox" # The name of the feature to be deprecated + announcement_milestone: "14.2" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-08-22" # The date of the milestone release when this feature was first announced as deprecated + removal_milestone: "14.5" # The milestone when this feature is planned to be removed + removal_date: "2021-11-22" # the date of the milestone release when this feature is planned to be removed breaking_change: false - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The Task Runner pod is used to execute periodic housekeeping tasks within the GitLab application and is often confused with the GitLab Runner. Thus, [Task Runner will be renamed to Toolbox](https://gitlab.com/groups/gitlab-org/charts/-/epics/25). This will result in the rename of the sub-chart: `gitlab/task-runner` to `gitlab/toolbox`. Resulting pods will be named along the lines of `{{ .Release.Name }}-toolbox`, which will often be `gitlab-toolbox`. They will be locatable with the label `app=toolbox`. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-3-database-deprecate-legacy-database-conf.yml b/data/deprecations/14-3-database-deprecate-legacy-database-conf.yml index 29e55337261..3644b681da0 100644 --- a/data/deprecations/14-3-database-deprecate-legacy-database-conf.yml +++ b/data/deprecations/14-3-database-deprecate-legacy-database-conf.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.3" announcement_date: "2021-09-22" removal_milestone: "15.0" - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true body: | The syntax of [GitLabs database](https://docs.gitlab.com/omnibus/settings/database.html) diff --git a/data/deprecations/14-3-deprecation_omniauth-kerberos_gem.yml b/data/deprecations/14-3-deprecation_omniauth-kerberos_gem.yml index 17c6cbc8e7a..ba7c07eaf83 100644 --- a/data/deprecations/14-3-deprecation_omniauth-kerberos_gem.yml +++ b/data/deprecations/14-3-deprecation_omniauth-kerberos_gem.yml @@ -4,7 +4,7 @@ removal_milestone: "15.0" removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The `omniauth-kerberos` gem will be removed in our next major release, GitLab 15.0. This gem has not been maintained and has very little usage. We therefore plan to remove support for this authentication method and recommend using the Kerberos [SPNEGO](https://en.wikipedia.org/wiki/SPNEGO) integration instead. You can follow the [upgrade instructions](https://docs.gitlab.com/ee/integration/kerberos.html#upgrading-from-password-based-to-ticket-based-kerberos-sign-ins) to upgrade from the `omniauth-kerberos` integration to the supported one. @@ -14,4 +14,3 @@ tiers: [Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/337384 documentation_url: https://docs.gitlab.com/ee/integration/kerberos.html#upgrading-from-password-based-to-ticket-based-kerberos-sign-ins - diff --git a/data/deprecations/14-3-repository-push-audit-events.yml b/data/deprecations/14-3-repository-push-audit-events.yml index 97a7a01b593..587dc98d03c 100644 --- a/data/deprecations/14-3-repository-push-audit-events.yml +++ b/data/deprecations/14-3-repository-push-audit-events.yml @@ -1,10 +1,10 @@ - name: "Audit events for repository push events" - announcement_milestone: "14.3" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-09-22" # https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69024 - removal_milestone: "15.0" # the milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + announcement_milestone: "14.3" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-09-22" # https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69024 + removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. Audit events for [repository events](https://docs.gitlab.com/ee/administration/audit_events.html#repository-push-deprecated) are now deprecated and will be removed in GitLab 15.0. These events have always been disabled by default and had to be manually enabled with a diff --git a/data/deprecations/14-5-certificate-based-integration-with-kubernetes.yml b/data/deprecations/14-5-certificate-based-integration-with-kubernetes.yml index 22ee8ac2942..5cf9354cd05 100644 --- a/data/deprecations/14-5-certificate-based-integration-with-kubernetes.yml +++ b/data/deprecations/14-5-certificate-based-integration-with-kubernetes.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.5" announcement_date: "2021-11-15" removal_milestone: "15.6" - removal_date: "2022-11-22" # the date of the milestone release when this feature is planned to be removed + removal_date: "2022-11-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true body: | [The certificate-based integration with Kubernetes will be deprecated and removed](https://about.gitlab.com/blog/2021/11/15/deprecating-the-cert-based-kubernetes-integration/). @@ -17,8 +17,8 @@ If you use GitLab.com, certificate-based integrations will cease functioning in 15.0. For a more robust, secure, forthcoming, and reliable integration with Kubernetes, we recommend you use the - [agent for Kubernetes](https://docs.gitlab.com/ee/user/clusters/agent/) to connect Kubernetes clusters with GitLab. - See the documentation for [how to migrate](https://docs.gitlab.com/ee/user/infrastructure/clusters/migrate_to_gitlab_agent.html). + [agent for Kubernetes](https://docs.gitlab.com/ee/user/clusters/agent/) to connect Kubernetes clusters with GitLab. + See the documentation for [how to migrate](https://docs.gitlab.com/ee/user/infrastructure/clusters/migrate_to_gitlab_agent.html). For updates and details about this deprecation, follow [this epic](https://gitlab.com/groups/gitlab-org/configure/-/epics/8). stage: Configure diff --git a/data/deprecations/14-5-deprecate-convert-instance-runner-to-project.yml b/data/deprecations/14-5-deprecate-convert-instance-runner-to-project.yml index 9cf806da021..9b45454fef8 100644 --- a/data/deprecations/14-5-deprecate-convert-instance-runner-to-project.yml +++ b/data/deprecations/14-5-deprecate-convert-instance-runner-to-project.yml @@ -1,10 +1,10 @@ - name: "Converting an instance (shared) runner to a project (specific) runner" - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-11-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In GitLab 15.0, we will remove the feature that enables you to convert an instance (shared) runner to a project (specific) runner. Users who need to add a runner to only a particular project can register a runner to the project directly. stage: Verify diff --git a/data/deprecations/14-5-deprecate-defaultMergeCommitMessageWithDescription-graphql.yml b/data/deprecations/14-5-deprecate-defaultMergeCommitMessageWithDescription-graphql.yml index af172f47ed1..2dfc20ae14e 100644 --- a/data/deprecations/14-5-deprecate-defaultMergeCommitMessageWithDescription-graphql.yml +++ b/data/deprecations/14-5-deprecate-defaultMergeCommitMessageWithDescription-graphql.yml @@ -1,15 +1,15 @@ -- name: "`defaultMergeCommitMessageWithDescription` GraphQL API field" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed +- name: "`defaultMergeCommitMessageWithDescription` GraphQL API field" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The GraphQL API field `defaultMergeCommitMessageWithDescription` has been deprecated and will be removed in GitLab 15.0. For projects with a commit message template set, it will ignore the template. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-5-deprecate-opensuse-15-2.yml b/data/deprecations/14-5-deprecate-opensuse-15-2.yml index f95a80e6eac..877fcf7e3a6 100644 --- a/data/deprecations/14-5-deprecate-opensuse-15-2.yml +++ b/data/deprecations/14-5-deprecate-opensuse-15-2.yml @@ -1,10 +1,10 @@ -- name: "openSUSE Leap 15.2 packages" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "14.8" # The milestone when this feature is planned to be removed - removal_date: "2022-02-22" # the date of the milestone release when this feature is planned to be removed +- name: "openSUSE Leap 15.2 packages" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "14.8" # The milestone when this feature is planned to be removed + removal_date: "2022-02-22" # the date of the milestone release when this feature is planned to be removed breaking_change: false - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. Distribution support and security updates for openSUSE Leap 15.2 are [ending December 2021](https://en.opensuse.org/Lifetime#openSUSE_Leap). Starting in 14.5 we are providing packages for openSUSE Leap 15.3, and will stop providing packages for openSUSE Leap 15.2 in the 14.8 milestone. diff --git a/data/deprecations/14-5-deprecate-sles-12sp2.yml b/data/deprecations/14-5-deprecate-sles-12sp2.yml index 9c6d1f6da52..69f8eb73bfd 100644 --- a/data/deprecations/14-5-deprecate-sles-12sp2.yml +++ b/data/deprecations/14-5-deprecate-sles-12sp2.yml @@ -1,8 +1,8 @@ -- name: "Support for SLES 12 SP2" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. +- name: "Support for SLES 12 SP2" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-11-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. Long term service and support (LTSS) for SUSE Linux Enterprise Server (SLES) 12 SP2 [ended on March 31, 2021](https://www.suse.com/lifecycle/). The CA certificates on SP2 include the expired DST root certificate, and it's not getting new CA certificate package updates. We have implemented some [workarounds](https://gitlab.com/gitlab-org/gitlab-omnibus-builder/-/merge_requests/191), but we will not be able to continue to keep the build running properly. diff --git a/data/deprecations/14-5-deprecation-versions-packagetype.yml b/data/deprecations/14-5-deprecation-versions-packagetype.yml index 92188b1b21d..da6e705b94f 100644 --- a/data/deprecations/14-5-deprecation-versions-packagetype.yml +++ b/data/deprecations/14-5-deprecation-versions-packagetype.yml @@ -1,10 +1,10 @@ - name: "`Versions` on base `PackageType`" - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. As part of the work to create a [Package Registry GraphQL API](https://gitlab.com/groups/gitlab-org/-/epics/6318), the Package group deprecated the `Version` type for the basic `PackageType` type and moved it to [`PackageDetailsType`](https://docs.gitlab.com/ee/api/graphql/reference/index.html#packagedetailstype). In milestone 15.0, we will completely remove `Version` from `PackageType`. diff --git a/data/deprecations/14-5-deprecation-vsa-announce-deprecation-of-vsa-filtering-calculation.yml b/data/deprecations/14-5-deprecation-vsa-announce-deprecation-of-vsa-filtering-calculation.yml index 2c16aca5df6..ebbfdf7358a 100644 --- a/data/deprecations/14-5-deprecation-vsa-announce-deprecation-of-vsa-filtering-calculation.yml +++ b/data/deprecations/14-5-deprecation-vsa-announce-deprecation-of-vsa-filtering-calculation.yml @@ -1,15 +1,15 @@ -- name: "Value Stream Analytics filtering calculation change" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed +- name: "Value Stream Analytics filtering calculation change" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. We are changing how the date filter works in Value Stream Analytics. Instead of filtering by the time that the issue or merge request was created, the date filter will filter by the end event time of the given stage. This will result in completely different figures after this change has rolled out. If you monitor Value Stream Analytics metrics and rely on the date filter, to avoid losing data, you must save the data prior to this change. stage: manage # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/343210' # (optional) This is a link to the deprecation issue in GitLab - documentation_url: "https://docs.gitlab.com/ee/user/analytics/value_stream_analytics.html#filter-value-stream-analytics-data" # (optional) This is a link to the current documentation page - image_url: "vsa_warning.png" # (optional) This is a link to a thumbnail image depicting the feature + documentation_url: "https://docs.gitlab.com/ee/user/analytics/value_stream_analytics.html#filter-value-stream-analytics-data" # (optional) This is a link to the current documentation page + image_url: "vsa_warning.png" # (optional) This is a link to a thumbnail image depicting the feature diff --git a/data/deprecations/14-5-disable_strict_host_key_checking.yml b/data/deprecations/14-5-disable_strict_host_key_checking.yml index a3a6a3bf223..b2091578ff4 100644 --- a/data/deprecations/14-5-disable_strict_host_key_checking.yml +++ b/data/deprecations/14-5-disable_strict_host_key_checking.yml @@ -1,10 +1,10 @@ - name: "Known host required for GitLab Runner SSH executor" - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-11-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In [GitLab 14.3](https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/3074), we added a configuration setting in the GitLab Runner `config.toml` file. This setting, [`[runners.ssh.disable_strict_host_key_checking]`](https://docs.gitlab.com/runner/executors/ssh.html#security), controls whether or not to use strict host key checking with the SSH executor. In GitLab 15.0 and later, the default value for this configuration option will change from `true` to `false`. This means that strict host key checking will be enforced when using the GitLab Runner SSH executor. diff --git a/data/deprecations/14-5-geo-deprecate-promote-db.yml b/data/deprecations/14-5-geo-deprecate-promote-db.yml index 81a2d10e35b..0dbd785c1a0 100644 --- a/data/deprecations/14-5-geo-deprecate-promote-db.yml +++ b/data/deprecations/14-5-geo-deprecate-promote-db.yml @@ -1,14 +1,14 @@ -- name: "`promote-db` command from `gitlab-ctl`" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "`promote-db` command from `gitlab-ctl`" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In GitLab 14.5, we introduced the command `gitlab-ctl promote` to promote any Geo secondary node to a primary during a failover. This command replaces `gitlab-ctl promote-db` which is used to promote database nodes in multi-node Geo secondary sites. `gitlab-ctl promote-db` will continue to function as-is and be available until GitLab 15.0. We recommend that Geo customers begin testing the new `gitlab-ctl promote` command in their staging environments and incorporating the new command in their failover procedures. stage: "Enablement" tiers: [Premium, Ultimate] issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/345207" - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-5-geo-deprecate-promote-to-primary-node.yml b/data/deprecations/14-5-geo-deprecate-promote-to-primary-node.yml index bbecfcd65ec..69034bcd33d 100644 --- a/data/deprecations/14-5-geo-deprecate-promote-to-primary-node.yml +++ b/data/deprecations/14-5-geo-deprecate-promote-to-primary-node.yml @@ -1,14 +1,14 @@ -- name: "`promote-to-primary-node` command from `gitlab-ctl`" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "`promote-to-primary-node` command from `gitlab-ctl`" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In GitLab 14.5, we introduced the command `gitlab-ctl promote` to promote any Geo secondary node to a primary during a failover. This command replaces `gitlab-ctl promote-to-primary-node` which was only usable for single-node Geo sites. `gitlab-ctl promote-to-primary-node` will continue to function as-is and be available until GitLab 15.0. We recommend that Geo customers begin testing the new `gitlab-ctl promote` command in their staging environments and incorporating the new command in their failover procedures. stage: "Enablement" tiers: [Premium, Ultimate] issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/345207" - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-5-package-container-registry-api-group-update.yml b/data/deprecations/14-5-package-container-registry-api-group-update.yml index 951de288d90..67e3557cae3 100644 --- a/data/deprecations/14-5-package-container-registry-api-group-update.yml +++ b/data/deprecations/14-5-package-container-registry-api-group-update.yml @@ -1,10 +1,10 @@ - name: "Update to the Container Registry group-level API" - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-11-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In milestone 15.0, support for the `tags` and `tags_count` parameters will be removed from the Container Registry API that [gets registry repositories from a group](../api/container_registry.md#within-a-group). The `GET /groups/:id/registry/repositories` endpoint will remain, but won't return any info about tags. To get the info about tags, you can use the existing `GET /registry/repositories/:id` endpoint, which will continue to support the `tags` and `tag_count` options as it does today. The latter must be called once per image repository. diff --git a/data/deprecations/14-5-remove-dependency-proxy-permissions-flag.yml b/data/deprecations/14-5-remove-dependency-proxy-permissions-flag.yml index 098be766942..2229637f527 100644 --- a/data/deprecations/14-5-remove-dependency-proxy-permissions-flag.yml +++ b/data/deprecations/14-5-remove-dependency-proxy-permissions-flag.yml @@ -1,10 +1,10 @@ -- name: "`dependency_proxy_for_private_groups` feature flag" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed +- name: "`dependency_proxy_for_private_groups` feature flag" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. We added a feature flag because [GitLab-#11582](https://gitlab.com/gitlab-org/gitlab/-/issues/11582) changed how public groups use the Dependency Proxy. Prior to this change, you could use the Dependency Proxy without authentication. The change requires authentication to use the Dependency Proxy. In milestone 15.0, we will remove the feature flag entirely. Moving forward, you must authenticate when using the Dependency Proxy. diff --git a/data/deprecations/14-5-remove-package-pipelines-api.yml b/data/deprecations/14-5-remove-package-pipelines-api.yml index 46ef1213da8..392636f90a0 100644 --- a/data/deprecations/14-5-remove-package-pipelines-api.yml +++ b/data/deprecations/14-5-remove-package-pipelines-api.yml @@ -1,10 +1,10 @@ -- name: "Package pipelines in API payload is paginated" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed +- name: "Package pipelines in API payload is paginated" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. A request to the API for `/api/v4/projects/:id/packages` returns a paginated result of packages. Each package lists all of its pipelines in this response. This is a performance concern, as it's possible for a package to have hundreds or thousands of associated pipelines. In milestone 15.0, we will remove the `pipelines` attribute from the API response. diff --git a/data/deprecations/14-5-remove-pipelines-from-version-field.yml b/data/deprecations/14-5-remove-pipelines-from-version-field.yml index fc8ec519fa7..98174daa26c 100644 --- a/data/deprecations/14-5-remove-pipelines-from-version-field.yml +++ b/data/deprecations/14-5-remove-pipelines-from-version-field.yml @@ -1,10 +1,10 @@ -- name: "`pipelines` field from the `version` field" # The name of the feature to be deprecated - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed +- name: "`pipelines` field from the `version` field" # The name of the feature to be deprecated + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-11-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In GraphQL, there are two `pipelines` fields that you can use in a [`PackageDetailsType`](https://docs.gitlab.com/ee/api/graphql/reference/#packagedetailstype) to get the pipelines for package versions: - The `versions` field's `pipelines` field. This returns all the pipelines associated with all the package's versions, which can pull an unbounded number of objects in memory and create performance concerns. diff --git a/data/deprecations/14-5-runner-api-status-does-contain-paused.yml b/data/deprecations/14-5-runner-api-status-does-contain-paused.yml index c3fbe553706..46f1ef89b53 100644 --- a/data/deprecations/14-5-runner-api-status-does-contain-paused.yml +++ b/data/deprecations/14-5-runner-api-status-does-contain-paused.yml @@ -1,10 +1,10 @@ - name: "REST and GraphQL API Runner status will not return `paused`" - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-11-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The GitLab Runner REST and GraphQL API endpoints will not return `paused` or `active` as a status in GitLab 15.0. A runner's status will only relate to runner contact status, such as: diff --git a/data/deprecations/14-5-runner-s3-authenticationtype-nonexplicit-config-deprecation.yml b/data/deprecations/14-5-runner-s3-authenticationtype-nonexplicit-config-deprecation.yml index d957b79e450..7026438f649 100644 --- a/data/deprecations/14-5-runner-s3-authenticationtype-nonexplicit-config-deprecation.yml +++ b/data/deprecations/14-5-runner-s3-authenticationtype-nonexplicit-config-deprecation.yml @@ -1,10 +1,10 @@ - name: "Must explicitly assign `AuthenticationType` for `[runners.cache.s3]`" - announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.5" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-11-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In GitLab 15.0 and later, to access the AWS S3 cache, you must specify the `AuthenticationType` for [`[runners.cache.s3]`](https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnerscaches3-section). The `AuthenticationType` must be `IAM` or `credentials`. Prior to 14.5, if you did not define the `AuthenticationType`, GitLab Runner chose a type for you. diff --git a/data/deprecations/14-6-Enforce-validation-of-security-schemas.yml b/data/deprecations/14-6-Enforce-validation-of-security-schemas.yml index 42de723ee99..5e8d300e9f2 100644 --- a/data/deprecations/14-6-Enforce-validation-of-security-schemas.yml +++ b/data/deprecations/14-6-Enforce-validation-of-security-schemas.yml @@ -1,9 +1,9 @@ -- name: "Enforced validation of security report schemas" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "Enforced validation of security report schemas" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [Security report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) versions earlier than 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported in GitLab 15.0. @@ -21,6 +21,6 @@ stage: Secure # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: [Core, Premium, Ultimate] # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/groups/gitlab-org/-/epics/6968 # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-container-scanning-schemas-below-14.yml b/data/deprecations/14-6-container-scanning-schemas-below-14.yml index b79418d5765..9427c9f0e88 100644 --- a/data/deprecations/14-6-container-scanning-schemas-below-14.yml +++ b/data/deprecations/14-6-container-scanning-schemas-below-14.yml @@ -1,9 +1,9 @@ -- name: "Container scanning schemas below 14.0.0" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "Container scanning schemas below 14.0.0" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [Container scanning report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) versions earlier than 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported in GitLab 15.0. @@ -15,9 +15,9 @@ [warning](https://gitlab.com/gitlab-org/gitlab/-/issues/335789#note_672853791) in the Vulnerability Report. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-coverage-fuzzing-schemas-below-14.yml b/data/deprecations/14-6-coverage-fuzzing-schemas-below-14.yml index 13babcc26ba..78d076294ed 100644 --- a/data/deprecations/14-6-coverage-fuzzing-schemas-below-14.yml +++ b/data/deprecations/14-6-coverage-fuzzing-schemas-below-14.yml @@ -1,9 +1,9 @@ -- name: "Coverage guided fuzzing schemas below 14.0.0" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "Coverage guided fuzzing schemas below 14.0.0" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [Coverage guided fuzzing report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) below version 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported in GitLab 15.0. @@ -18,9 +18,9 @@ [warning](https://gitlab.com/gitlab-org/gitlab/-/issues/335789#note_672853791) in the Vulnerability Report. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-dast-schemas-below-14.yml b/data/deprecations/14-6-dast-schemas-below-14.yml index afd27a1fa7a..305cf9469f9 100644 --- a/data/deprecations/14-6-dast-schemas-below-14.yml +++ b/data/deprecations/14-6-dast-schemas-below-14.yml @@ -1,9 +1,9 @@ -- name: "DAST schemas below 14.0.0" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "DAST schemas below 14.0.0" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [DAST report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) versions earlier than 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported as of GitLab 15.0. @@ -18,9 +18,9 @@ [warning to be displayed](https://gitlab.com/gitlab-org/gitlab/-/issues/335789#note_672853791) in the Vulnerability Report. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-dependency-scanning-schemas-below-14.yml b/data/deprecations/14-6-dependency-scanning-schemas-below-14.yml index 226cffc3afc..f04130bc68f 100644 --- a/data/deprecations/14-6-dependency-scanning-schemas-below-14.yml +++ b/data/deprecations/14-6-dependency-scanning-schemas-below-14.yml @@ -1,9 +1,9 @@ -- name: "Dependency scanning schemas below 14.0.0" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "Dependency scanning schemas below 14.0.0" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [Dependency scanning report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) versions earlier than 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported as of GitLab 15.0. @@ -18,9 +18,9 @@ [warning to be displayed](https://gitlab.com/gitlab-org/gitlab/-/issues/335789#note_672853791) in the Vulnerability Report. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-deprecate-types.yml b/data/deprecations/14-6-deprecate-types.yml index f8886eeef37..3db9f574d38 100644 --- a/data/deprecations/14-6-deprecate-types.yml +++ b/data/deprecations/14-6-deprecate-types.yml @@ -1,15 +1,15 @@ -- name: "`type` and `types` keyword in CI/CD configuration" # The name of the feature to be deprecated - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed +- name: "`type` and `types` keyword in CI/CD configuration" # The name of the feature to be deprecated + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The `type` and `types` CI/CD keywords will be removed in GitLab 15.0. Pipelines that use these keywords will stop working, so you must switch to `stage` and `stages`, which have the same behavior. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-deprecation-license-compliance-api-terms.yml b/data/deprecations/14-6-deprecation-license-compliance-api-terms.yml index e09205f2d9b..fd45a54d8bd 100644 --- a/data/deprecations/14-6-deprecation-license-compliance-api-terms.yml +++ b/data/deprecations/14-6-deprecation-license-compliance-api-terms.yml @@ -1,9 +1,9 @@ -- name: "Legacy approval status names from License Compliance API" # The name of the feature to be deprecated - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "Legacy approval status names from License Compliance API" # The name of the feature to be deprecated + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. We deprecated legacy names for approval status of license policy (blacklisted, approved) in the `managed_licenses` API but they are still used in our API queries and responses. They will be removed in 15.0. If you are using our License Compliance API you should stop using the `approved` and `blacklisted` query parameters, they are now `allowed` and `denied`. In 15.0 the responses will also stop using `approved` and `blacklisted` so you need to adjust any of your custom tools to use the old and new values so they do not break with the 15.0 release. @@ -11,7 +11,7 @@ stage: secure # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: ultimate # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/335707 # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg - removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format. This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format. This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed diff --git a/data/deprecations/14-6-deprecation-secure-dependency-scanning-bundler-audit.yml b/data/deprecations/14-6-deprecation-secure-dependency-scanning-bundler-audit.yml index 4f4a2ad8a7d..7f9377c295e 100644 --- a/data/deprecations/14-6-deprecation-secure-dependency-scanning-bundler-audit.yml +++ b/data/deprecations/14-6-deprecation-secure-dependency-scanning-bundler-audit.yml @@ -1,9 +1,9 @@ -- name: "bundler-audit Dependency Scanning tool" # The name of the feature to be deprecated - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "bundler-audit Dependency Scanning tool" # The name of the feature to be deprecated + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. As of 14.6 bundler-audit is being deprecated from Dependency Scanning. It will continue to be in our CI/CD template while deprecated. We are removing bundler-audit from Dependency Scanning on May 22, 2022 in 15.0. After this removal Ruby scanning functionality will not be affected as it is still being covered by Gemnasium. If you have explicitly excluded bundler-audit using DS_EXCLUDED_ANALYZERS you will need to clean up (remove the reference) in 15.0. If you have customized your pipeline's Dependency Scanning configuration, for example to edit the `bundler-audit-dependency_scanning` job, you will want to switch to gemnasium-dependency_scanning before removal in 15.0, to prevent your pipeline from failing. If you have not used the DS_EXCLUDED_ANALYZERS to reference bundler-audit, or customized your template specifically for bundler-audit, you will not need to take action. @@ -12,6 +12,6 @@ tiers: ultimate # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/289832 # (optional) This is a link to the deprecation issue in GitLab documentation_url: https://docs.gitlab.com/ee/user/application_security/dependency_scanning/analyzers.html # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg - removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format. This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format. This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed diff --git a/data/deprecations/14-6-job_char_limit.yml b/data/deprecations/14-6-job_char_limit.yml index 6570b1b8e81..edfbd855652 100644 --- a/data/deprecations/14-6-job_char_limit.yml +++ b/data/deprecations/14-6-job_char_limit.yml @@ -1,15 +1,15 @@ -- name: "CI/CD job name length limit" # The name of the feature to be deprecated - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format - the date of the milestone release when this feature is planned to be removed +- name: "CI/CD job name length limit" # The name of the feature to be deprecated + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format - the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. In GitLab 15.0 we are going to limit the number of characters in CI/CD job names to 255. Any pipeline with job names that exceed the 255 character limit will stop working after the 15.0 release. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/342800 # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-pipeline-fields-package-deprecation.yml b/data/deprecations/14-6-pipeline-fields-package-deprecation.yml index 897886d2d0b..14892d2bbae 100644 --- a/data/deprecations/14-6-pipeline-fields-package-deprecation.yml +++ b/data/deprecations/14-6-pipeline-fields-package-deprecation.yml @@ -1,10 +1,10 @@ - name: "`pipelines` fields in the Package GraphQL types" - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-12-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. As part of the work to create a [Package Registry GraphQL API](https://gitlab.com/groups/gitlab-org/-/epics/6318), the Package group deprecated the `pipelines` fields in all Package-related GraphQL types. As of GitLab 14.6, the `pipelines` field is deprecated in [`Package`](https://docs.gitlab.com/ee/api/graphql/reference/index.html#package) and [`PackageDetailsType`](https://docs.gitlab.com/ee/api/graphql/reference/index.html#packagedetailstype) due to scalability and performance concerns. In milestone 15.0, we will completely remove `pipelines` from `Package` and `PackageDetailsType`. You can follow and contribute to work on a replacement in the epic [GitLab-#7214](https://gitlab.com/groups/gitlab-org/-/epics/7214). diff --git a/data/deprecations/14-6-runner-api-status-renames-not_connected.yml b/data/deprecations/14-6-runner-api-status-renames-not_connected.yml index a535cfbf7a7..a2aba7cadbe 100644 --- a/data/deprecations/14-6-runner-api-status-renames-not_connected.yml +++ b/data/deprecations/14-6-runner-api-status-renames-not_connected.yml @@ -1,9 +1,9 @@ - name: "Runner status `not_connected` API value" - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. - removal_milestone: "15.0" # the milestone when this feature is planned to be removed + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + removal_milestone: "15.0" # the milestone when this feature is planned to be removed removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The GitLab Runner REST and GraphQL [API](https://docs.gitlab.com/ee/api/runners.html#runners-api) endpoints will return `never_contacted` instead of `not_connected` as the status values in 15.0. diff --git a/data/deprecations/14-6-runner_api_new_stale_status_breaking_change.yml b/data/deprecations/14-6-runner_api_new_stale_status_breaking_change.yml index 3cf6ed69354..0f21318d329 100644 --- a/data/deprecations/14-6-runner_api_new_stale_status_breaking_change.yml +++ b/data/deprecations/14-6-runner_api_new_stale_status_breaking_change.yml @@ -1,10 +1,10 @@ - name: "API: `stale` status returned instead of `offline` or `not_connected`" - announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.6" # The milestone when this feature was first announced as deprecated. announcement_date: "2021-12-22" - removal_milestone: "15.0" # the milestone when this feature is planned to be removed + removal_milestone: "15.0" # the milestone when this feature is planned to be removed removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. A breaking change will occur for the Runner [API](https://docs.gitlab.com/ee/api/runners.html#runners-api) endpoints in 15.0. Instead of the GitLab Runner API endpoints returning `offline` and `not_connected` for runners that have not contacted the GitLab instance in the past three months, the API endpoints will return the `stale` value, which was introduced in 14.6. diff --git a/data/deprecations/14-6-sast-schemas-below-14.yml b/data/deprecations/14-6-sast-schemas-below-14.yml index 02e112ec4b8..635eaa3624b 100644 --- a/data/deprecations/14-6-sast-schemas-below-14.yml +++ b/data/deprecations/14-6-sast-schemas-below-14.yml @@ -1,9 +1,9 @@ -- name: "SAST schemas below 14.0.0" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "SAST schemas below 14.0.0" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [SAST report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) versions earlier than 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported as of GitLab 15.0. @@ -18,9 +18,9 @@ [warning](https://gitlab.com/gitlab-org/gitlab/-/issues/335789#note_672853791) in the Vulnerability Report. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-6-secret-detection-schemas-below-14.yml b/data/deprecations/14-6-secret-detection-schemas-below-14.yml index d366e08a8c0..16af233df44 100644 --- a/data/deprecations/14-6-secret-detection-schemas-below-14.yml +++ b/data/deprecations/14-6-secret-detection-schemas-below-14.yml @@ -1,9 +1,9 @@ -- name: "Secret detection schemas below 14.0.0" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed - body: | # Do not modify this line, instead modify the lines below. +- name: "Secret detection schemas below 14.0.0" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed + body: | # Do not modify this line, instead modify the lines below. [Secret detection report schemas](https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/releases) versions earlier than 14.0.0 will no longer be supported in GitLab 15.0. Reports that do not pass validation against the schema version declared in the report will also no longer be supported as of GitLab 15.0. @@ -18,9 +18,9 @@ [warning](https://gitlab.com/gitlab-org/gitlab/-/issues/335789#note_672853791) in the Vulnerability Report. # The following items are not published on the docs page, but may be used in the future. - stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # (optional) This is a link to the deprecation issue in GitLab + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-7-deprecate-godep-support-in-license-compliance.yml b/data/deprecations/14-7-deprecate-godep-support-in-license-compliance.yml index cf986341884..9d0e2aa91dc 100644 --- a/data/deprecations/14-7-deprecate-godep-support-in-license-compliance.yml +++ b/data/deprecations/14-7-deprecate-godep-support-in-license-compliance.yml @@ -1,9 +1,9 @@ -- name: "Godep support in License Compliance" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. - body: | # Do not modify this line, instead modify the lines below. +- name: "Godep support in License Compliance" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. + body: | # Do not modify this line, instead modify the lines below. The Godep dependency manager for Golang was deprecated in 2020 by Go and has been replaced with Go modules. To reduce our maintenance cost we are deprecating License Compliance for Godep projects as of 14.7 diff --git a/data/deprecations/14-7-deprecate-merged_by-api-field.yml b/data/deprecations/14-7-deprecate-merged_by-api-field.yml index e2ecef1aa6a..fc187d08d46 100644 --- a/data/deprecations/14-7-deprecate-merged_by-api-field.yml +++ b/data/deprecations/14-7-deprecate-merged_by-api-field.yml @@ -10,18 +10,18 @@ # # Please delete this line and above before submitting your merge request. -- name: "merged_by API field" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed +- name: "merged_by API field" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # the date of the milestone release when this feature is planned to be removed breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The `merged_by` field in the [merge request API](https://docs.gitlab.com/ee/api/merge_requests.html#list-merge-requests) is being deprecated and will be removed in GitLab 15.0. This field is being replaced with the `merge_user` field (already present in GraphQL) which more correctly identifies who merged a merge request when performing actions (merge when pipeline succeeds, add to merge train) other than a simple merge. # The following items are not published on the docs page, but may be used in the future. stage: create # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350534 # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-7-deprecate-static-site-editor.yml b/data/deprecations/14-7-deprecate-static-site-editor.yml index e522699e823..2c45a7d3bf5 100644 --- a/data/deprecations/14-7-deprecate-static-site-editor.yml +++ b/data/deprecations/14-7-deprecate-static-site-editor.yml @@ -1,14 +1,14 @@ -- name: "Static Site Editor" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. - body: | # Do not modify this line, instead modify the lines below. +- name: "Static Site Editor" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. + body: | # Do not modify this line, instead modify the lines below. The Static Site Editor will no longer be available starting in GitLab 15.0. Improvements to the Markdown editing experience across GitLab will deliver smiliar benefit but with a wider reach. Incoming requests to the Static Site Editor will be redirected to the Web IDE. Current users of the Static Site Editor can view the [documentation](https://docs.gitlab.com/ee/user/project/static_site_editor/) for more information, including how to remove the configuration files from existing projects. # The following items are not published on the docs page, but may be used in the future. stage: Create # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: [Free, Premium, Ultimate] # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/347137 # (optional) This is a link to the deprecation issue in GitLab documentation_url: https://docs.gitlab.com/ee/user/project/static_site_editor/ # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-7-pseudonymizer.yml b/data/deprecations/14-7-pseudonymizer.yml index bd8cb215496..f278cd506e2 100644 --- a/data/deprecations/14-7-pseudonymizer.yml +++ b/data/deprecations/14-7-pseudonymizer.yml @@ -1,9 +1,9 @@ -- name: "Pseudonymizer" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. - body: | # Do not modify this line, instead modify the lines below. +- name: "Pseudonymizer" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. + body: | # Do not modify this line, instead modify the lines below. The Pseudonymizer feature is generally unused, can cause production issues with large databases, and can interfere with object storage development. diff --git a/data/deprecations/14-7-sidekiq-metrics-health-check-donfig.yml b/data/deprecations/14-7-sidekiq-metrics-health-check-donfig.yml index 34c262b1539..1faec65e9ef 100644 --- a/data/deprecations/14-7-sidekiq-metrics-health-check-donfig.yml +++ b/data/deprecations/14-7-sidekiq-metrics-health-check-donfig.yml @@ -4,7 +4,7 @@ removal_milestone: "15.0" removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. Exporting Sidekiq metrics and health checks using a single process and port is deprecated. Support will be removed in 15.0. diff --git a/data/deprecations/14-8-Elasticsearch-6-8.yml b/data/deprecations/14-8-Elasticsearch-6-8.yml index 20f32966f24..28a25803d41 100644 --- a/data/deprecations/14-8-Elasticsearch-6-8.yml +++ b/data/deprecations/14-8-Elasticsearch-6-8.yml @@ -2,17 +2,16 @@ announcement_milestone: "14.8" announcement_date: "2022-02-22" removal_milestone: "15.0" - removal_date: "2022-05-22" - breaking_change: true - body: | + removal_date: "2022-05-22" + breaking_change: true + body: | Elasticsearch 6.8 is deprecated in GitLab 14.8 and scheduled for removal in GitLab 15.0. Customers using Elasticsearch 6.8 need to upgrade their Elasticsearch version to 7.x prior to upgrading to GitLab 15.0. We recommend using the latest version of Elasticsearch 7 to benefit from all Elasticsearch improvements. Elasticsearch 6.8 is also incompatible with Amazon OpenSearch, which we [plan to support in GitLab 15.0](https://gitlab.com/gitlab-org/gitlab/-/issues/327560). - stage: Enablement - tiers: [Premium, Ultimate] + stage: Enablement + tiers: [Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350275 documentation_url: https://docs.gitlab.com/ee/integration/elasticsearch.html#version-requirements - diff --git a/data/deprecations/14-8-compliance-required-pipeline-configuration-premium.yml b/data/deprecations/14-8-compliance-required-pipeline-configuration-premium.yml index 73ba7d8011a..104dbc5f72d 100644 --- a/data/deprecations/14-8-compliance-required-pipeline-configuration-premium.yml +++ b/data/deprecations/14-8-compliance-required-pipeline-configuration-premium.yml @@ -5,7 +5,7 @@ removal_date: "2022-05-22" breaking_change: true reporter: sam.white - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The [required pipeline configuration](https://docs.gitlab.com/ee/user/admin_area/settings/continuous_integration.html#required-pipeline-configuration) feature is deprecated in GitLab 14.8 for Premium customers and is scheduled for removal in GitLab 15.0. This feature is not deprecated for GitLab Ultimate customers. This change to move the feature to GitLab's Ultimate tier is intended to help our features better align with our [pricing philosophy](https://about.gitlab.com/company/pricing/#three-tiers) as we see demand for this feature originating primarily from executives. diff --git a/data/deprecations/14-8-compliance-status-check-api-field.yml b/data/deprecations/14-8-compliance-status-check-api-field.yml index f32a8379481..5ad653c8fce 100644 --- a/data/deprecations/14-8-compliance-status-check-api-field.yml +++ b/data/deprecations/14-8-compliance-status-check-api-field.yml @@ -5,7 +5,7 @@ removal_date: "2022-05-22" breaking_change: true reporter: sam.white - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The [external status check API](https://docs.gitlab.com/ee/api/status_checks.html) was originally implemented to support pass-by-default requests to mark a status check as passing. Pass-by-default requests are now deprecated. Specifically, the following are deprecated: diff --git a/data/deprecations/14-8-deprecate-projectFingerprint-from-PipelineSecurityReportFinding-GraphQL.yml b/data/deprecations/14-8-deprecate-projectFingerprint-from-PipelineSecurityReportFinding-GraphQL.yml index ea75e70afe3..0638f86968a 100644 --- a/data/deprecations/14-8-deprecate-projectFingerprint-from-PipelineSecurityReportFinding-GraphQL.yml +++ b/data/deprecations/14-8-deprecate-projectFingerprint-from-PipelineSecurityReportFinding-GraphQL.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true reporter: matt_wilson # GitLab username of the person reporting the deprecation body: | # Do not modify this line, instead modify the lines below. diff --git a/data/deprecations/14-8-deprecation-secure-dependency-scanning-retire-js.yml b/data/deprecations/14-8-deprecation-secure-dependency-scanning-retire-js.yml index a5e5ce6e9ea..e5e158909ba 100644 --- a/data/deprecations/14-8-deprecation-secure-dependency-scanning-retire-js.yml +++ b/data/deprecations/14-8-deprecation-secure-dependency-scanning-retire-js.yml @@ -1,9 +1,9 @@ -- name: "Retire-JS Dependency Scanning tool" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "Retire-JS Dependency Scanning tool" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. As of 14.8 the retire.js job is being deprecated from Dependency Scanning. It will continue to be included in our CI/CD template while deprecated. We are removing retire.js from Dependency Scanning on May 22, 2022 in GitLab 15.0. JavaScript scanning functionality will not be affected as it is still being covered by Gemnasium. If you have explicitly excluded retire.js using DS_EXCLUDED_ANALYZERS you will need to clean up (remove the reference) in 15.0. If you have customized your pipeline's Dependency Scanning configuration related to the `retire-js-dependency_scanning` job you will want to switch to gemnasium-dependency_scanning before the removal in 15.0, to prevent your pipeline from failing. If you have not used the DS_EXCLUDED_ANALYZERS to reference retire.js, or customized your template specifically for retire.js, you will not need to take action. @@ -12,6 +12,6 @@ tiers: ultimate # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350510 # (optional) This is a link to the deprecation issue in GitLab documentation_url: https://docs.gitlab.com/ee/user/application_security/dependency_scanning/analyzers.html # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg - removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format. This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + removal_date: "2022-05-22" # (optional - may be required in the future) YYYY-MM-DD format. This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed diff --git a/data/deprecations/14-8-enforce-pat-expiration.yml b/data/deprecations/14-8-enforce-pat-expiration.yml index 6c6fdf31fe6..e42de41254a 100644 --- a/data/deprecations/14-8-enforce-pat-expiration.yml +++ b/data/deprecations/14-8-enforce-pat-expiration.yml @@ -1,13 +1,13 @@ -- name: "Optional enforcement of PAT expiration" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. +- name: "Optional enforcement of PAT expiration" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true reporter: djensen # GitLab username of the person reporting the deprecation - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The feature to disable enforcement of PAT expiration is unusual from a security perspective. We have become concerned that this unusual feature could create unexpected behavior for users. Unexpected behavior in a security feature is inherently dangerous, so we have decided to remove this feature. - issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351962" # (optional) This is a link to the deprecation issue in GitLab - documentation_url: "https://docs.gitlab.com/ee/user/admin_area/settings/account_and_limit_settings.html#allow-expired-personal-access-tokens-to-be-used-deprecated" # (optional) This is a link to the current documentation page + issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351962" # (optional) This is a link to the deprecation issue in GitLab + documentation_url: "https://docs.gitlab.com/ee/user/admin_area/settings/account_and_limit_settings.html#allow-expired-personal-access-tokens-to-be-used-deprecated" # (optional) This is a link to the current documentation page diff --git a/data/deprecations/14-8-enforce-ssh-expiration.yml b/data/deprecations/14-8-enforce-ssh-expiration.yml index 815d592a2a9..3cdcaad193e 100644 --- a/data/deprecations/14-8-enforce-ssh-expiration.yml +++ b/data/deprecations/14-8-enforce-ssh-expiration.yml @@ -1,13 +1,13 @@ -- name: "Optional enforcement of SSH expiration" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. +- name: "Optional enforcement of SSH expiration" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true reporter: djensen # GitLab username of the person reporting the deprecation - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The feature to disable enforcement of SSH expiration is unusual from a security perspective. We have become concerned that this unusual feature could create unexpected behavior for users. Unexpected behavior in a security feature is inherently dangerous, so we have decided to remove this feature. - issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351963" # (optional) This is a link to the deprecation issue in GitLab - documentation_url: "https://docs.gitlab.com/ee/user/admin_area/settings/account_and_limit_settings.html#allow-expired-ssh-keys-to-be-used-deprecated" # (optional) This is a link to the current documentation page + issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351963" # (optional) This is a link to the deprecation issue in GitLab + documentation_url: "https://docs.gitlab.com/ee/user/admin_area/settings/account_and_limit_settings.html#allow-expired-ssh-keys-to-be-used-deprecated" # (optional) This is a link to the current documentation page diff --git a/data/deprecations/14-8-geo-deprecate-db-rake-tasks.yml b/data/deprecations/14-8-geo-deprecate-db-rake-tasks.yml index 137ae01f63b..d38e579e3e6 100644 --- a/data/deprecations/14-8-geo-deprecate-db-rake-tasks.yml +++ b/data/deprecations/14-8-geo-deprecate-db-rake-tasks.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.8" announcement_date: "2022-02-22" removal_milestone: "15.0" - removal_date: "2022-05-22" + removal_date: "2022-05-22" breaking_change: false reporter: nhxnguyen body: | @@ -28,7 +28,7 @@ - `geo:db:test:purge` -> `db:test:purge:geo` stage: "Enablement" tiers: ["Premium", "Ultimate"] - issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351945" + issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351945" documentation_url: # (optional) This is a link to the current documentation page image_url: # (optional) This is a link to a thumbnail image depicting the feature video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-geo-deprecate-replication-detail-routes.yml b/data/deprecations/14-8-geo-deprecate-replication-detail-routes.yml index 94a026edd81..c28dc849f72 100644 --- a/data/deprecations/14-8-geo-deprecate-replication-detail-routes.yml +++ b/data/deprecations/14-8-geo-deprecate-replication-detail-routes.yml @@ -10,6 +10,6 @@ stage: "Enablement" tiers: ["Premium", "Ultimate"] issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/351345" - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-gitaly-remove-per-repository-election.yml b/data/deprecations/14-8-gitaly-remove-per-repository-election.yml index 334da51c4a0..7edaff9821f 100644 --- a/data/deprecations/14-8-gitaly-remove-per-repository-election.yml +++ b/data/deprecations/14-8-gitaly-remove-per-repository-election.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "14.9" # The milestone when this feature is planned to be removed - removal_date: "2022-03-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_date: "2022-03-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: false # If this deprecation is a breaking change, set this value to true reporter: mjwood # GitLab username of the person reporting the deprecation body: | # Do not modify this line, instead modify the lines below. @@ -13,7 +13,7 @@ # The following items are not published on the docs page, but may be used in the future. stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/352612" # (optional) This is a link to the deprecation issue in GitLab + issue_url: "https://gitlab.com/gitlab-org/gitlab/-/issues/352612" # (optional) This is a link to the deprecation issue in GitLab documentation_url: # (optional) This is a link to the current documentation page image_url: # (optional) This is a link to a thumbnail image depicting the feature video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-graphql-ids.yml b/data/deprecations/14-8-graphql-ids.yml index dd73f310335..67ff418c51a 100644 --- a/data/deprecations/14-8-graphql-ids.yml +++ b/data/deprecations/14-8-graphql-ids.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.8" announcement_date: "2022-02-22" removal_milestone: "15.0" - removal_date: "2022-04-22" + removal_date: "2022-04-22" breaking_change: true reporter: alexkalderimis body: | # Do not modify this line, instead modify the lines below. @@ -52,7 +52,7 @@ } } ``` - + This query works now, and will continue to work after GitLab 15.0. You should convert any queries in the first form (using `ID` as a named type in the signature) to one of the other two forms (using the correct appropriate type in the signature, or using @@ -60,7 +60,7 @@ # The following items are not published on the docs page, but may be used in the future. stage: # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/257883' + issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/257883' documentation_url: # (optional) This is a link to the current documentation page image_url: # (optional) This is a link to a thumbnail image depicting the feature video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-iteration-started-field.yml b/data/deprecations/14-8-iteration-started-field.yml index 590c9800db6..8c67996e2c5 100644 --- a/data/deprecations/14-8-iteration-started-field.yml +++ b/data/deprecations/14-8-iteration-started-field.yml @@ -1,15 +1,15 @@ -- name: "`started` iterations API field" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. +- name: "`started` iterations API field" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The `started` field in the [iterations API](https://docs.gitlab.com/ee/api/iterations.html#list-project-iterations) is being deprecated and will be removed in GitLab 15.0. This field is being replaced with the `current` field (already available) which aligns with the naming for other time-based entities, such as milestones. # The following items are not published on the docs page, but may be used in the future. stage: plan - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/334018 - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-protect-cns-chs.yml b/data/deprecations/14-8-protect-cns-chs.yml index b3a4cc8c1e8..8ea76d1b371 100644 --- a/data/deprecations/14-8-protect-cns-chs.yml +++ b/data/deprecations/14-8-protect-cns-chs.yml @@ -5,7 +5,7 @@ removal_date: "2022-05-22" breaking_change: true reporter: sam.white - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. All functionality related to GitLab's Container Network Security and Container Host Security categories is deprecated in GitLab 14.8 and scheduled for removal in GitLab 15.0. Users who need a replacement for this functionality are encouraged to evaluate the following open source projects as potential solutions that can be installed and managed outside of GitLab: [AppArmor](https://gitlab.com/apparmor/apparmor), [Cilium](https://github.com/cilium/cilium), [Falco](https://github.com/falcosecurity/falco), [FluentD](https://github.com/fluent/fluentd), [Pod Security Admission](https://kubernetes.io/docs/concepts/security/pod-security-admission/). To integrate these technologies into GitLab, add the desired Helm charts into your copy of the [Cluster Management Project Template](https://docs.gitlab.com/ee/user/clusters/management_project_template.html). Deploy these Helm charts in production by calling commands through the GitLab [Secure CI/CD Tunnel](https://docs.gitlab.com/ee/user/clusters/agent/repository.html#run-kubectl-commands-using-the-cicd-tunnel). As part of this change, the following specific capabilities within GitLab are now deprecated, and are scheduled for removal in GitLab 15.0: diff --git a/data/deprecations/14-8-protect-vulnerability-check.yml b/data/deprecations/14-8-protect-vulnerability-check.yml index 0f8fb44081a..ddb296886b2 100644 --- a/data/deprecations/14-8-protect-vulnerability-check.yml +++ b/data/deprecations/14-8-protect-vulnerability-check.yml @@ -5,7 +5,7 @@ removal_date: "2022-05-22" breaking_change: true reporter: sam.white - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The vulnerability check feature is deprecated in GitLab 14.8 and scheduled for removal in GitLab 15.0. We encourage you to migrate to the new security approvals feature instead. You can do so by navigating to **Security & Compliance > Policies** and creating a new Scan Result Policy. The new security approvals feature is similar to vulnerability check. For example, both can require approvals for MRs that contain security vulnerabilities. However, security approvals improve the previous experience in several ways: diff --git a/data/deprecations/14-8-remove-support-for-fixup-in-commit-message-triggering-draft-status.yml b/data/deprecations/14-8-remove-support-for-fixup-in-commit-message-triggering-draft-status.yml index cda67e53b8e..f738b71f1b7 100644 --- a/data/deprecations/14-8-remove-support-for-fixup-in-commit-message-triggering-draft-status.yml +++ b/data/deprecations/14-8-remove-support-for-fixup-in-commit-message-triggering-draft-status.yml @@ -1,9 +1,9 @@ -- name: "`fixup!` commit messages setting draft status of associated Merge Request" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-06-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. - body: | # Do not modify this line, instead modify the lines below. +- name: "`fixup!` commit messages setting draft status of associated Merge Request" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-06-22" # This should almost always be the 22nd of a month (YYYY-MM-22), the date of the milestone release when this feature is planned to be removed. + body: | # Do not modify this line, instead modify the lines below. The use of `fixup!` as a commit message to trigger draft status of the associated Merge Request is generally unused, and can cause confusion with other uses of the term. "Draft" is the preferred diff --git a/data/deprecations/14-8-remove_ff_push_rules_supersede_code_owners.yml b/data/deprecations/14-8-remove_ff_push_rules_supersede_code_owners.yml index b93b25c00d0..19a44a419b4 100644 --- a/data/deprecations/14-8-remove_ff_push_rules_supersede_code_owners.yml +++ b/data/deprecations/14-8-remove_ff_push_rules_supersede_code_owners.yml @@ -2,15 +2,15 @@ announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true reporter: sarahwaldner # GitLab username of the person reporting the deprecation body: | # Do not modify this line, instead modify the lines below. The feature flag `PUSH_RULES_SUPERSEDE_CODE_OWNERS` is being removed in GitLab 15.0. Upon its removal, push rules will supersede CODEOWNERS. The CODEOWNERS feature will no longer be available for access control. # The following items are not published on the docs page, but may be used in the future. - stage: create # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth + stage: create # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262019 # (optional) This is a link to the deprecation issue in GitLab + issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262019 # (optional) This is a link to the deprecation issue in GitLab documentation_url: # (optional) This is a link to the current documentation page image_url: # (optional) This is a link to a thumbnail image depicting the feature video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-request-profiling.yml b/data/deprecations/14-8-request-profiling.yml index 8b549a6002f..82d2aadd149 100644 --- a/data/deprecations/14-8-request-profiling.yml +++ b/data/deprecations/14-8-request-profiling.yml @@ -1,11 +1,11 @@ - name: "Request profiling" announcement_milestone: "14.8" announcement_date: "2021-02-22" - removal_milestone: "15.0" + removal_milestone: "15.0" removal_date: "2022-05-22" breaking_change: true reporter: iroussos - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. [Request profiling](https://docs.gitlab.com/ee/administration/monitoring/performance/request_profiling.html) is deprecated in GitLab 14.8 and scheduled for removal in GitLab 15.0. We're working on [consolidating our profiling tools](https://gitlab.com/groups/gitlab-org/-/epics/7327) and making them more easily accessible. diff --git a/data/deprecations/14-8-runner-api-active-field-replaced-with-paused-breaking-change.yml b/data/deprecations/14-8-runner-api-active-field-replaced-with-paused-breaking-change.yml index 63178061aae..0300641e540 100644 --- a/data/deprecations/14-8-runner-api-active-field-replaced-with-paused-breaking-change.yml +++ b/data/deprecations/14-8-runner-api-active-field-replaced-with-paused-breaking-change.yml @@ -29,5 +29,5 @@ tiers: [Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/347211 documentation_url: https://docs.gitlab.com/ee/api/runners.html - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-runner-api-project_type-breaking-change.yml b/data/deprecations/14-8-runner-api-project_type-breaking-change.yml index 67cd854aa89..d965d830c58 100644 --- a/data/deprecations/14-8-runner-api-project_type-breaking-change.yml +++ b/data/deprecations/14-8-runner-api-project_type-breaking-change.yml @@ -11,5 +11,5 @@ tiers: [Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/351466 documentation_url: https://docs.gitlab.com/ee/api/runners.html - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/14-8-runner-api-status-filter-does-accept-active-or-paused.yml b/data/deprecations/14-8-runner-api-status-filter-does-accept-active-or-paused.yml index 51472b3cd28..8f706840f0d 100644 --- a/data/deprecations/14-8-runner-api-status-filter-does-accept-active-or-paused.yml +++ b/data/deprecations/14-8-runner-api-status-filter-does-accept-active-or-paused.yml @@ -1,10 +1,10 @@ - name: "REST API Runner will not accept `status` filter values of `active` or `paused`" - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. announcement_date: "2022-02-22" removal_milestone: "16.0" removal_date: "2023-04-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The GitLab Runner REST endpoints will stop accepting `paused` or `active` as a status value in GitLab 16.0. A runner's status will only relate to runner contact status, such as: `online`, `offline`. diff --git a/data/deprecations/14-8-sast-secret-analyzer-image.yml b/data/deprecations/14-8-sast-secret-analyzer-image.yml index b1cb5c82764..cc7e559722d 100644 --- a/data/deprecations/14-8-sast-secret-analyzer-image.yml +++ b/data/deprecations/14-8-sast-secret-analyzer-image.yml @@ -12,7 +12,7 @@ Starting in GitLab 14.8, new versions of GitLab Secure and Protect analyzers are published to a new registry location under `registry.gitlab.com/security-products`. We will update the default value of [GitLab-managed CI/CD templates](https://gitlab.com/gitlab-org/gitlab/-/tree/master/lib/gitlab/ci/templates/Security) to reflect this change: - + - For all analyzers except Container Scanning, we will update the variable `SECURE_ANALYZERS_PREFIX` to the new image registry location. - For Container Scanning, the default image address is already updated. There is no `SECURE_ANALYZERS_PREFIX` variable for Container Scanning. diff --git a/data/deprecations/14-8-secure-and-protect-analyzer-bump.yml b/data/deprecations/14-8-secure-and-protect-analyzer-bump.yml index 4adfb35cbb8..bbfa552d3ad 100644 --- a/data/deprecations/14-8-secure-and-protect-analyzer-bump.yml +++ b/data/deprecations/14-8-secure-and-protect-analyzer-bump.yml @@ -2,7 +2,7 @@ announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true reporter: NicoleSchwartz # GitLab username of the person reporting the deprecation body: | # Do not modify this line, instead modify the lines below. diff --git a/data/deprecations/14-8-secure-ca-python-deprecation.yml b/data/deprecations/14-8-secure-ca-python-deprecation.yml index c4b5c2e36b7..0a081370906 100644 --- a/data/deprecations/14-8-secure-ca-python-deprecation.yml +++ b/data/deprecations/14-8-secure-ca-python-deprecation.yml @@ -1,10 +1,10 @@ -- name: "Dependency Scanning Python 3.9 and 3.6 image deprecation" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "Dependency Scanning Python 3.9 and 3.6 image deprecation" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed removal_date: 2021-05-22 # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. For those using Dependency Scanning for Python projects, we are deprecating the default `gemnasium-python:2` image which uses Python 3.6 as well as the custom `gemnasium-python:2-python-3.9` image which uses Python 3.9. The new default image as of GitLab 15.0 will be for Python 3.9 as it is a [supported version](https://endoflife.date/python) and 3.6 [is no longer supported](https://endoflife.date/python). For users using Python 3.9 or 3.9-compatible projects, you should not need to take action and dependency scanning should begin to work in GitLab 15.0. If you wish to test the new container now please run a test pipeline in your project with this container (which will be removed in 15.0). Use the Python 3.9 image: @@ -17,7 +17,7 @@ For users using Python 3.6, as of GitLab 15.0 you will no longer be able to use the default template for dependency scanning. You will need to switch to use the deprecated `gemnasium-python:2` analyzer image. If you are impacted by this please comment in [this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/351503) so we can extend the removal if needed. - For users using the 3.9 special exception image, you must instead use the default value and no longer override your container. To verify if you are using the 3.9 special exception image, check your `.gitlab-ci.yml` file for the following reference: + For users using the 3.9 special exception image, you must instead use the default value and no longer override your container. To verify if you are using the 3.9 special exception image, check your `.gitlab-ci.yml` file for the following reference: ```yaml gemnasium-python-dependency_scanning: @@ -28,6 +28,6 @@ stage: secure # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: ultimate # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/334060 # (optional) This is a link to the deprecation issue in GitLab - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/15-0-deprecate-monitor-logging.yml b/data/deprecations/15-0-deprecate-monitor-logging.yml index facb66e4ee8..bac04d245d3 100644 --- a/data/deprecations/15-0-deprecate-monitor-logging.yml +++ b/data/deprecations/15-0-deprecate-monitor-logging.yml @@ -1,16 +1,15 @@ -- name: "Logging in GitLab" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. +- name: "Logging in GitLab" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The logging features in GitLab allow users to install the ELK stack (Elasticsearch, Logstash, and Kibana) to aggregate and manage application logs. Users can search for relevant logs in GitLab. However, since deprecating certificate-based integration with Kubernetes clusters and GitLab Managed Apps, we don't have a recommended solution for logging within GitLab. For more information, you can follow the issue for [integrating Opstrace with GitLab](https://gitlab.com/groups/gitlab-org/-/epics/6976). # The following items are not published on the docs page, but may be used in the future. stage: Monitor # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: [Free] # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/346485 # (optional) This is a link to the deprecation issue in GitLab documentation_url: https://docs.gitlab.com/ee/operations/#aggregate-and-store-logs-deprecated # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg - + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/15-0-deprecate-monitor-metrics.yml b/data/deprecations/15-0-deprecate-monitor-metrics.yml index 0a28785105f..b8b1ab30ced 100644 --- a/data/deprecations/15-0-deprecate-monitor-metrics.yml +++ b/data/deprecations/15-0-deprecate-monitor-metrics.yml @@ -1,10 +1,10 @@ -- name: "Monitor performance metrics through Prometheus" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. +- name: "Monitor performance metrics through Prometheus" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. By displaying data stored in a Prometheus instance, GitLab allows users to view performance metrics. GitLab also displays visualizations of these metrics in dashboards. The user can connect to a previously-configured external Prometheus instance, or set up Prometheus as a GitLab Managed App. However, since certificate-based integration with Kubernetes clusters is deprecated in GitLab, the metrics functionality in GitLab that relies on Prometheus is also deprecated. This includes the metrics visualizations in dashboards. GitLab is working to develop a single user experience based on [Opstrace](https://about.gitlab.com/press/releases/2021-12-14-gitlab-acquires-opstrace-to-expand-its-devops-platform-with-open-source-observability-solution.html). An [issue exists](https://gitlab.com/groups/gitlab-org/-/epics/6976) for you to follow work on the Opstrace integration. # The following items are not published on the docs page, but may be used in the future. @@ -12,6 +12,5 @@ tiers: [Free] # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/346541 # (optional) This is a link to the deprecation issue in GitLab documentation_url: https://docs.gitlab.com/ee/operations/metrics/dashboards/ # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg - + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/15-0-deprecate-monitor-tracing.yml b/data/deprecations/15-0-deprecate-monitor-tracing.yml index 448404a5c70..26373fb78ad 100644 --- a/data/deprecations/15-0-deprecate-monitor-tracing.yml +++ b/data/deprecations/15-0-deprecate-monitor-tracing.yml @@ -1,15 +1,15 @@ -- name: "Tracing in GitLab" # The name of the feature to be deprecated - announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed - removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. +- name: "Tracing in GitLab" # The name of the feature to be deprecated + announcement_milestone: "14.7" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-01-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed + removal_date: "2022-05-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. Tracing in GitLab is an integration with Jaeger, an open-source end-to-end distributed tracing system. GitLab users can navigate to their Jaeger instance to gain insight into the performance of a deployed application, tracking each function or microservice that handles a given request. Tracing in GitLab is deprecated in GitLab 14.7, and scheduled for removal in 15.0. To track work on a possible replacement, see the issue for [Opstrace integration with GitLab](https://gitlab.com/groups/gitlab-org/-/epics/6976). # The following items are not published on the docs page, but may be used in the future. stage: Monitor # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth tiers: [Free] # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/346540 # (optional) This is a link to the deprecation issue in GitLab documentation_url: https://docs.gitlab.com/ee/operations/tracing.html#tracing # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/15-0-instance-statistics-graphql-node-removal.yml b/data/deprecations/15-0-instance-statistics-graphql-node-removal.yml index c617a6cc478..113ccdc66ea 100644 --- a/data/deprecations/15-0-instance-statistics-graphql-node-removal.yml +++ b/data/deprecations/15-0-instance-statistics-graphql-node-removal.yml @@ -4,7 +4,7 @@ removal_milestone: "15.0" removal_date: "2022-05-22" breaking_change: true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The `instanceStatisticsMeasurements` GraphQL node has been renamed to `usageTrendsMeasurements` in 13.10 and the old field name has been marked as deprecated. To fix the existing GraphQL queries, replace `instanceStatisticsMeasurements` with `usageTrendsMeasurements`. # The following items are not published on the docs page, but may be used in the future. stage: Manage diff --git a/data/deprecations/15-0-oauth-noexpiry.yml b/data/deprecations/15-0-oauth-noexpiry.yml index 2e1e4a35f7b..56d654fe8ba 100644 --- a/data/deprecations/15-0-oauth-noexpiry.yml +++ b/data/deprecations/15-0-oauth-noexpiry.yml @@ -1,10 +1,10 @@ -- name: "OAuth tokens without expiration" # The name of the feature to be deprecated - announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. - announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "OAuth tokens without expiration" # The name of the feature to be deprecated + announcement_milestone: "14.8" # The milestone when this feature was first announced as deprecated. + announcement_date: "2022-02-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed removal_date: 2022-05-22 # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: true # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. By default, all new applications expire access tokens after 2 hours. In GitLab 14.2 and earlier, OAuth access tokens had no expiration. In GitLab 15.0, an expiry will be automatically generated for any existing token that does not already have one. @@ -16,9 +16,9 @@ 1. Select **Expire access tokens** to enable them. Tokens must be revoked or they don’t expire. # The following items are not published on the docs page, but may be used in the future. - stage: # Manage - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # https://gitlab.com/gitlab-org/gitlab/-/issues/21745 - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # Manage + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # https://gitlab.com/gitlab-org/gitlab/-/issues/21745 + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/deprecations/15-0-oauth.yml b/data/deprecations/15-0-oauth.yml index 5ca30d9f330..f0f185bb024 100644 --- a/data/deprecations/15-0-oauth.yml +++ b/data/deprecations/15-0-oauth.yml @@ -1,15 +1,15 @@ -- name: "OAuth implicit grant" # The name of the feature to be deprecated - announcement_milestone: "14.0" # The milestone when this feature was first announced as deprecated. - announcement_date: "2021-06-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. - removal_milestone: "15.0" # The milestone when this feature is planned to be removed +- name: "OAuth implicit grant" # The name of the feature to be deprecated + announcement_milestone: "14.0" # The milestone when this feature was first announced as deprecated. + announcement_date: "2021-06-22" # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. + removal_milestone: "15.0" # The milestone when this feature is planned to be removed removal_date: 2022-05-22 # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post. breaking_change: yes # If this deprecation is a breaking change, set this value to true - body: | # Do not modify this line, instead modify the lines below. + body: | # Do not modify this line, instead modify the lines below. The OAuth implicit grant authorization flow will be removed in our next major release, GitLab 15.0. Any applications that use OAuth implicit grant should switch to alternative [supported OAuth flows](https://docs.gitlab.com/ee/api/oauth2.html). # The following items are not published on the docs page, but may be used in the future. - stage: # Manage - tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - issue_url: # https://gitlab.com/gitlab-org/gitlab/-/issues/344609 - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg + stage: # Manage + tiers: # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] + issue_url: # https://gitlab.com/gitlab-org/gitlab/-/issues/344609 + documentation_url: # (optional) This is a link to the current documentation page + image_url: # (optional) This is a link to a thumbnail image depicting the feature + video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/data/removals/14_0/deprecation_bump_terraform_template_version.yml b/data/removals/14_0/deprecation_bump_terraform_template_version.yml index 253dd81e9ea..5bc8d7d66c9 100644 --- a/data/removals/14_0/deprecation_bump_terraform_template_version.yml +++ b/data/removals/14_0/deprecation_bump_terraform_template_version.yml @@ -1,6 +1,6 @@ - name: "Terraform template version" removal_date: "2021-06-22" - removal_milestone: "14.0" # example + removal_milestone: "14.0" # example issue_url: "" reporter: nagyv-gitlab breaking_change: true diff --git a/data/removals/14_0/removal-sidekiq_experimental_queue_selector.yml b/data/removals/14_0/removal-sidekiq_experimental_queue_selector.yml index 9995e5a2b55..d53e7744e3a 100644 --- a/data/removals/14_0/removal-sidekiq_experimental_queue_selector.yml +++ b/data/removals/14_0/removal-sidekiq_experimental_queue_selector.yml @@ -7,5 +7,3 @@ GitLab supports a [queue selector](https://docs.gitlab.com/ee/administration/operations/extra_sidekiq_processes.html#queue-selector) to run only a subset of background jobs for a given process. When it was introduced, this option had an 'experimental' prefix (`experimental_queue_selector` in Omnibus, `experimentalQueueSelector` in Helm charts). As announced in the [13.6 release post](https://about.gitlab.com/releases/2020/11/22/gitlab-13-6-released/#sidekiq-cluster-queue-selector-configuration-option-has-been-renamed), the 'experimental' prefix is no longer supported. Instead, `queue_selector` for Omnibus and `queueSelector` in Helm charts should be used. - - diff --git a/data/removals/14_0/removal_ci_project_config_path.yml b/data/removals/14_0/removal_ci_project_config_path.yml index 64fe187c505..d71fbbb78f3 100644 --- a/data/removals/14_0/removal_ci_project_config_path.yml +++ b/data/removals/14_0/removal_ci_project_config_path.yml @@ -9,4 +9,3 @@ If you are using `CI_PROJECT_CONFIG_PATH` in your pipeline configurations, please update them to use `CI_CONFIG_PATH` instead. - diff --git a/data/removals/14_0/removal_enablement_pg11.yml b/data/removals/14_0/removal_enablement_pg11.yml index 7c5738b7ff9..6f9c7718268 100644 --- a/data/removals/14_0/removal_enablement_pg11.yml +++ b/data/removals/14_0/removal_enablement_pg11.yml @@ -7,5 +7,3 @@ PostgreSQL 12 will be the minimum required version in GitLab 14.0. It offers [significant improvements](https://www.postgresql.org/about/news/postgresql-12-released-1976/) to indexing, partitioning, and general performance benefits. Starting in GitLab 13.7, all new installations default to version 12. From GitLab 13.8, single-node instances are automatically upgraded as well. If you aren't ready to upgrade, you can [opt out of automatic upgrades](https://docs.gitlab.com/omnibus/settings/database.html#opt-out-of-automatic-postgresql-upgrades). - - diff --git a/data/removals/14_0/removal_enablement_ubuntu_16.yml b/data/removals/14_0/removal_enablement_ubuntu_16.yml index 593bac720c1..e67829de7ab 100644 --- a/data/removals/14_0/removal_enablement_ubuntu_16.yml +++ b/data/removals/14_0/removal_enablement_ubuntu_16.yml @@ -7,6 +7,3 @@ Ubuntu 16.04 [reached end-of-life in April 2021](https://ubuntu.com/about/release-cycle), and no longer receives maintenance updates. We strongly recommend users to upgrade to a newer release, such as 20.04. GitLab 13.12 will be the last release with Ubuntu 16.04 support. - - - diff --git a/data/removals/14_0/removal_runner_25555.yml b/data/removals/14_0/removal_runner_25555.yml index 706614618ce..f775bd977bf 100644 --- a/data/removals/14_0/removal_runner_25555.yml +++ b/data/removals/14_0/removal_runner_25555.yml @@ -5,4 +5,3 @@ breaking_change: true body: | In GitLab Runner 13.0, [issue #5069](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/5069), we introduced new timing options for the GitLab Docker Machine executor. In GitLab Runner 14.0, we have removed the old configuration option, [off peak time mode](https://docs.gitlab.com/runner/configuration/autoscale.html#off-peak-time-mode-configuration-deprecated). - diff --git a/data/removals/14_0/verify-ci-removal-parametertrace.yml b/data/removals/14_0/verify-ci-removal-parametertrace.yml index 67d52827485..8822abaf357 100644 --- a/data/removals/14_0/verify-ci-removal-parametertrace.yml +++ b/data/removals/14_0/verify-ci-removal-parametertrace.yml @@ -5,5 +5,3 @@ breaking_change: true body: | GitLab Runner was updated in GitLab 13.4 to internally stop passing the `trace` parameter to the `/api/jobs/:id` endpoint. GitLab 14.0 deprecates the `trace` parameter entirely for all other requests of this endpoint. Make sure your [GitLab Runner version matches your GitLab version](https://docs.gitlab.com/runner/#gitlab-runner-versions) to ensure consistent behavior. - - diff --git a/data/removals/14_3/removal-limit-tags-to-50.yml b/data/removals/14_3/removal-limit-tags-to-50.yml index 3395fc9b6ce..24dcddf6955 100644 --- a/data/removals/14_3/removal-limit-tags-to-50.yml +++ b/data/removals/14_3/removal-limit-tags-to-50.yml @@ -1,5 +1,5 @@ - name: "Introduced limit of 50 tags for jobs" - removal_date: September 22nd, 2021 + removal_date: September 22nd, 2021 removal_milestone: "14.3" reporter: jreporter breaking_change: false diff --git a/data/removals/14_3/removal-verify-pe-pipelinefindername.yml b/data/removals/14_3/removal-verify-pe-pipelinefindername.yml index df39a6cec38..e3ad364ce29 100644 --- a/data/removals/14_3/removal-verify-pe-pipelinefindername.yml +++ b/data/removals/14_3/removal-verify-pe-pipelinefindername.yml @@ -1,7 +1,7 @@ - name: "List project pipelines API endpoint removes `name` support in 14.3" - removal_date: September 22, 2021 # day the removal was released + removal_date: September 22, 2021 # day the removal was released removal_milestone: "14.3" - reporter: jreporter # GitLab username of the person reporting the removal + reporter: jreporter # GitLab username of the person reporting the removal breaking_change: false body: | In GitLab 14.3, we will remove the ability to filter by `name` in the [list project pipelines API endpoint](https://docs.gitlab.com/ee/api/pipelines.html#list-project-pipelines) to improve performance. If you currently use this parameter with this endpoint, you must switch to `username`. diff --git a/data/removals/14_3/removal_legacy_storage_setting.yml b/data/removals/14_3/removal_legacy_storage_setting.yml index 5241861bf5a..b7d14f38f9a 100644 --- a/data/removals/14_3/removal_legacy_storage_setting.yml +++ b/data/removals/14_3/removal_legacy_storage_setting.yml @@ -1,7 +1,7 @@ - name: Use of legacy storage setting - removal_date: September 22nd, 2021 # day the removal was released + removal_date: September 22nd, 2021 # day the removal was released removal_milestone: "14.3" - reporter: dorrino # GitLab username of the person reporting the removal + reporter: dorrino # GitLab username of the person reporting the removal breaking_change: false body: | # example (supports markdown) The support for [`gitlab_pages['use_legacy_storage']` setting](https://docs.gitlab.com/ee/administration/pages/index.html#domain-source-configuration-before-140) in Omnibus installations has been removed. diff --git a/db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb b/db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb new file mode 100644 index 00000000000..1f36132c578 --- /dev/null +++ b/db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb @@ -0,0 +1,27 @@ +# frozen_string_literal: true + +class RerunConvertStringifiedRawMetadataHashToJson < Gitlab::Database::Migration[1.0] + MIGRATION_CLASS = Gitlab::BackgroundMigration::FixVulnerabilityOccurrencesWithHashesAsRawMetadata + MODEL_CLASS = MIGRATION_CLASS::Finding + DELAY_INTERVAL = 2.minutes + BATCH_SIZE = 500 + + disable_ddl_transaction! + + def up + queue_background_migration_jobs_by_range_at_intervals( + MODEL_CLASS.by_api_report_types, + MIGRATION_CLASS.name.demodulize, + DELAY_INTERVAL, + batch_size: BATCH_SIZE, + track_jobs: true + ) + end + + def down + # no-op + + # up fixes invalid data by updating columns in-place. + # It is a backwards-compatible change, and reversing it in a downgrade would not be desirable. + end +end diff --git a/db/post_migrate/20220223112304_schedule_nullify_orphan_runner_id_on_ci_builds.rb b/db/post_migrate/20220223112304_schedule_nullify_orphan_runner_id_on_ci_builds.rb new file mode 100644 index 00000000000..08a7c869eb1 --- /dev/null +++ b/db/post_migrate/20220223112304_schedule_nullify_orphan_runner_id_on_ci_builds.rb @@ -0,0 +1,27 @@ +# frozen_string_literal: true + +class ScheduleNullifyOrphanRunnerIdOnCiBuilds < Gitlab::Database::Migration[1.0] + MIGRATION = 'NullifyOrphanRunnerIdOnCiBuilds' + INTERVAL = 2.minutes + BATCH_SIZE = 100_000 + MAX_BATCH_SIZE = 25_000 # 100k * 25k = 2.5B ci_builds + SUB_BATCH_SIZE = 1_000 + + def up + queue_batched_background_migration( + MIGRATION, + :ci_builds, + :id, + job_interval: INTERVAL, + batch_size: BATCH_SIZE, + max_batch_size: MAX_BATCH_SIZE, + sub_batch_size: SUB_BATCH_SIZE + ) + end + + def down + Gitlab::Database::BackgroundMigration::BatchedMigration + .for_configuration(MIGRATION, :ci_builds, :id, []) + .delete_all + end +end diff --git a/db/schema_migrations/20220215190020 b/db/schema_migrations/20220215190020 new file mode 100644 index 00000000000..1d5be90ca1f --- /dev/null +++ b/db/schema_migrations/20220215190020 @@ -0,0 +1 @@ +aa92afc5f74f051132aeb73889d7360bbd6258b27c0aedb4fea6a44ccce597b3 \ No newline at end of file diff --git a/db/schema_migrations/20220223112304 b/db/schema_migrations/20220223112304 new file mode 100644 index 00000000000..bfcbf9c1225 --- /dev/null +++ b/db/schema_migrations/20220223112304 @@ -0,0 +1 @@ +57dc23bb2a9faddefe20c1e30a8879ebb1f6f32f17e3cc381acc1d06ad3b598a \ No newline at end of file diff --git a/doc/api/users.md b/doc/api/users.md index 925563aeb1f..1ab42a0c28b 100644 --- a/doc/api/users.md +++ b/doc/api/users.md @@ -958,6 +958,32 @@ Parameters: } ``` +## Single SSH key for given user + +> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/81790) in GitLab 14.9. + +Get a single key for a given user. + +```plaintext +GET /users/:id/keys/:key_id +``` + +Parameters: + +| Attribute | Type | Required | Description | +|-----------|---------|----------|----------------------| +| `id` | integer | yes | ID of specified user | +| `key_id` | integer | yes | SSH key ID | + +```json +{ + "id": 1, + "title": "Public key", + "key": "ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=", + "created_at": "2014-08-01T14:47:39.080Z" +} +``` + ## Add SSH key Creates a new key owned by the currently authenticated user. diff --git a/doc/ci/pipelines/cicd_minutes.md b/doc/ci/pipelines/cicd_minutes.md index 8b10a74bd78..828d8d0d8fc 100644 --- a/doc/ci/pipelines/cicd_minutes.md +++ b/doc/ci/pipelines/cicd_minutes.md @@ -223,3 +223,25 @@ On GitLab SaaS an email notification is sent to the namespace owners when: - The available CI/CD minutes are below 30% of the quota. - The available CI/CD minutes are below 5% of the quota. - All CI/CD minutes have been used. + +## Reduce consumption of CI/CD minutes + +If your project consumes too many CI/CD minutes, there are some strategies you can +use to reduce your CI/CD minutes usage: + +- If you are using project mirrors, ensure that [pipelines for mirror updates](../../user/project/repository/mirror/pull.md#trigger-pipelines-for-mirror-updates) + is disabled. +- Reduce the frequency of [pipeline schedules](schedules.md#pipeline-schedules). +- [Skip pipelines](index.md#skip-a-pipeline) when not needed. +- Use [interruptible](../yaml/index.md#interruptible) jobs which can be auto-canceled + if a new pipeline starts. +- If a job doesn't have to run in every pipeline, use [`rules`](../jobs/job_control.md) + to make it only run when it's needed. +- [Use private runners](../runners/runners_scope.md#group-runners) for some jobs. +- If you are working from a fork and you submit a merge request to the parent project, + you can ask a maintainer to run a pipeline [in the parent project](merge_request_pipelines.md#run-pipelines-in-the-parent-project). + +If you manage an open source project, these improvements can also reduce CI/CD minutes +consumption for contributor fork projects, enabling more contributions. + +See our [pipeline efficiency guide](pipeline_efficiency.md) for more details. diff --git a/doc/development/adding_database_indexes.md b/doc/development/adding_database_indexes.md index 0e8e8289464..d263d9b5eb5 100644 --- a/doc/development/adding_database_indexes.md +++ b/doc/development/adding_database_indexes.md @@ -275,11 +275,11 @@ You can verify if the MR was deployed to GitLab.com by executing `/chatops run auto_deploy status `. To verify existence of the index, you can: -- Use a meta-command in #database-lab, such as: `\d ` - - Ensure that the index is not [`invalid`](https://www.postgresql.org/docs/12/sql-createindex.html#:~:text=The%20psql%20%5Cd%20command%20will%20report%20such%20an%20index%20as%20INVALID) -- Ask someone in #database to check if the index exists +- Use a meta-command in #database-lab, such as: `\d `. + - Ensure that the index is not [`invalid`](https://www.postgresql.org/docs/12/sql-createindex.html#:~:text=The%20psql%20%5Cd%20command%20will%20report%20such%20an%20index%20as%20INVALID). +- Ask someone in #database to check if the index exists. - With proper access, you can also verify directly on production or in a -production clone +production clone. ### Add a migration to create the index synchronously diff --git a/doc/development/service_ping/implement.md b/doc/development/service_ping/implement.md index c14d798a846..54f3f2ca618 100644 --- a/doc/development/service_ping/implement.md +++ b/doc/development/service_ping/implement.md @@ -26,13 +26,12 @@ To implement a new metric in Service Ping, follow these steps: 1. [Verify your metric](#verify-your-metric) 1. [Set up and test Service Ping locally](#set-up-and-test-service-ping-locally) -NOTE: -When you add or change a Service Metric, you must migrate metrics to [instrumentation classes](metrics_instrumentation.md). -For information about the progress on migrating Service ping metrics, see this [epic](https://gitlab.com/groups/gitlab-org/-/epics/5547). - ## Instrumentation classes -Implementing metrics direct in `usage_data.rb` is deprecated, we recommend you use [instrumentation classes](metrics_instrumentation.md). +NOTE: +Implementing metrics directly in `usage_data.rb` is deprecated. +When you add or change a Service Ping Metric, you must migrate metrics to [instrumentation classes](metrics_instrumentation.md). +For information about the progress on migrating Service Ping metrics, see this [epic](https://gitlab.com/groups/gitlab-org/-/epics/5547). For example, we have the following instrumentation class: `lib/gitlab/usage/metrics/instrumentations/count_boards_metric.rb`. diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md index cb2ccf562e4..e96784c8d3e 100644 --- a/doc/update/deprecations.md +++ b/doc/update/deprecations.md @@ -100,7 +100,7 @@ gemnasium-python-dependency_scanning: For users using Python 3.6, as of GitLab 15.0 you will no longer be able to use the default template for dependency scanning. You will need to switch to use the deprecated `gemnasium-python:2` analyzer image. If you are impacted by this please comment in [this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/351503) so we can extend the removal if needed. -For users using the 3.9 special exception image, you must instead use the default value and no longer override your container. To verify if you are using the 3.9 special exception image, check your `.gitlab-ci.yml` file for the following reference: +For users using the 3.9 special exception image, you must instead use the default value and no longer override your container. To verify if you are using the 3.9 special exception image, check your `.gitlab-ci.yml` file for the following reference: ```yaml gemnasium-python-dependency_scanning: @@ -584,7 +584,7 @@ Each analyzer is distributed as a container image. Starting in GitLab 14.8, new versions of GitLab Secure and Protect analyzers are published to a new registry location under `registry.gitlab.com/security-products`. We will update the default value of [GitLab-managed CI/CD templates](https://gitlab.com/gitlab-org/gitlab/-/tree/master/lib/gitlab/ci/templates/Security) to reflect this change: - + - For all analyzers except Container Scanning, we will update the variable `SECURE_ANALYZERS_PREFIX` to the new image registry location. - For Container Scanning, the default image address is already updated. There is no `SECURE_ANALYZERS_PREFIX` variable for Container Scanning. @@ -1118,8 +1118,8 @@ GitLab will continue to fix security and critical issues. If you use GitLab.com, certificate-based integrations will cease functioning in 15.0. For a more robust, secure, forthcoming, and reliable integration with Kubernetes, we recommend you use the -[agent for Kubernetes](https://docs.gitlab.com/ee/user/clusters/agent/) to connect Kubernetes clusters with GitLab. -See the documentation for [how to migrate](https://docs.gitlab.com/ee/user/infrastructure/clusters/migrate_to_gitlab_agent.html). +[agent for Kubernetes](https://docs.gitlab.com/ee/user/clusters/agent/) to connect Kubernetes clusters with GitLab. +See the documentation for [how to migrate](https://docs.gitlab.com/ee/user/infrastructure/clusters/migrate_to_gitlab_agent.html). For updates and details about this deprecation, follow [this epic](https://gitlab.com/groups/gitlab-org/configure/-/epics/8). diff --git a/doc/user/admin_area/license.md b/doc/user/admin_area/license.md index 22133e30aa0..2fcb5daad8a 100644 --- a/doc/user/admin_area/license.md +++ b/doc/user/admin_area/license.md @@ -56,7 +56,7 @@ Otherwise, to upload your license: 1. Sign in to GitLab as an administrator. 1. On the top bar, select **Menu > Admin**. -1. On the left sidebar, select **Settings**. +1. On the left sidebar, select **Settings > General**. 1. In the **License file** area, select **Upload a license**. 1. Upload a license: - For a file, either: diff --git a/lib/api/users.rb b/lib/api/users.rb index 6d4f12d80f8..ee804cc4757 100644 --- a/lib/api/users.rb +++ b/lib/api/users.rb @@ -383,6 +383,23 @@ module API present paginate(keys), with: Entities::SSHKey end + desc 'Get a SSH key of a specified user.' do + success Entities::SSHKey + end + params do + requires :id, type: Integer, desc: 'The ID of the user' + requires :key_id, type: Integer, desc: 'The ID of the SSH key' + end + get ':id/keys/:key_id', requirements: API::USER_REQUIREMENTS, feature_category: :authentication_and_authorization do + user = find_user(params[:id]) + not_found!('User') unless user && can?(current_user, :read_user, user) + + key = user.keys.find_by(id: params[:key_id]) # rubocop: disable CodeReuse/ActiveRecord + not_found!('Key') unless key + + present key, with: Entities::SSHKey + end + desc 'Delete an existing SSH key from a specified user. Available only for admins.' do success Entities::SSHKey end diff --git a/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb b/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb index 2b049ea2d2f..a34e923545c 100644 --- a/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb +++ b/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb @@ -59,7 +59,7 @@ module Gitlab private def mark_job_as_succeeded(*arguments) - Gitlab::Database::BackgroundMigrationJob.mark_all_as_succeeded( + ::Gitlab::Database::BackgroundMigrationJob.mark_all_as_succeeded( 'FixVulnerabilityOccurrencesWithHashesAsRawMetadata', arguments ) diff --git a/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb b/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb new file mode 100644 index 00000000000..78e897d9ae1 --- /dev/null +++ b/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb @@ -0,0 +1,40 @@ +# frozen_string_literal: true + +module Gitlab + module BackgroundMigration + # A job to nullify orphan runner_id on ci_builds table + class NullifyOrphanRunnerIdOnCiBuilds + include Gitlab::Database::DynamicModelHelpers + + def perform(start_id, end_id, batch_table, batch_column, sub_batch_size, pause_ms) + pause_ms = 0 if pause_ms < 0 + + batch_relation = relation_scoped_to_range(batch_table, batch_column, start_id, end_id) + batch_relation.each_batch(column: batch_column, of: sub_batch_size, order_hint: :type) do |sub_batch| + batch_metrics.time_operation(:update_all) do + sub_batch.update_all(runner_id: nil) + end + + sleep(pause_ms * 0.001) + end + end + + def batch_metrics + @batch_metrics ||= Gitlab::Database::BackgroundMigration::BatchMetrics.new + end + + private + + def connection + ActiveRecord::Base.connection + end + + def relation_scoped_to_range(source_table, source_key_column, start_id, stop_id) + define_batchable_model(source_table, connection: connection) + .joins('LEFT OUTER JOIN ci_runners ON ci_runners.id = ci_builds.runner_id') + .where('ci_builds.runner_id IS NOT NULL AND ci_runners.id IS NULL') + .where(source_key_column => start_id..stop_id) + end + end + end +end diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 45c07834520..6566c0a7aae 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -42389,6 +42389,9 @@ msgstr "" msgid "Your %{plan} subscription expires on %{expiry_date}" msgstr "" +msgid "Your %{spammable_entity_type} has been recognized as spam. Please, change the content or solve the reCAPTCHA to proceed." +msgstr "" + msgid "Your %{strong}%{plan_name}%{strong_close} subscription expires on %{strong}%{expires_on}%{strong_close}. After that date, you cannot create issues or merge requests, or use many other features." msgstr "" diff --git a/rubocop/cop/database/multiple_databases.rb b/rubocop/cop/database/multiple_databases.rb index fb6e81f9845..f20348d9d1f 100644 --- a/rubocop/cop/database/multiple_databases.rb +++ b/rubocop/cop/database/multiple_databases.rb @@ -17,6 +17,10 @@ module RuboCop https://docs.gitlab.com/ee/development/database/transaction_guidelines.html EOF + ALLOWED_METHODS = %i[ + no_touching + ].freeze + def_node_matcher :active_record_base_method_is_used?, <<~PATTERN (send (const (const nil? :ActiveRecord) :Base) $_) PATTERN @@ -24,8 +28,17 @@ module RuboCop def on_send(node) return unless active_record_base_method_is_used?(node) + active_record_base_method = node.children[1] + return if method_is_allowed?(active_record_base_method) + add_offense(node, location: :expression, message: AR_BASE_MESSAGE) end + + private + + def method_is_allowed?(method_name) + ALLOWED_METHODS.include?(method_name.to_sym) + end end end end diff --git a/spec/controllers/confirmations_controller_spec.rb b/spec/controllers/confirmations_controller_spec.rb index 1c7f8de32bb..3b5afbcebca 100644 --- a/spec/controllers/confirmations_controller_spec.rb +++ b/spec/controllers/confirmations_controller_spec.rb @@ -152,7 +152,7 @@ RSpec.describe ConfirmationsController do perform_request expect(response).to render_template(:new) - expect(flash[:alert]).to include 'There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.' + expect(flash[:alert]).to include _('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.') end it 'successfully sends password reset when reCAPTCHA is solved' do diff --git a/spec/controllers/passwords_controller_spec.rb b/spec/controllers/passwords_controller_spec.rb index 01c032d9e3b..82014282c6e 100644 --- a/spec/controllers/passwords_controller_spec.rb +++ b/spec/controllers/passwords_controller_spec.rb @@ -121,7 +121,7 @@ RSpec.describe PasswordsController do perform_request expect(response).to render_template(:new) - expect(flash[:alert]).to include 'There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.' + expect(flash[:alert]).to include _('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.') end it 'successfully sends password reset when reCAPTCHA is solved' do diff --git a/spec/controllers/sessions_controller_spec.rb b/spec/controllers/sessions_controller_spec.rb index 31de00dd8bd..03d053e6f97 100644 --- a/spec/controllers/sessions_controller_spec.rb +++ b/spec/controllers/sessions_controller_spec.rb @@ -235,7 +235,7 @@ RSpec.describe SessionsController do unsuccesful_login(user_params) expect(response).to render_template(:new) - expect(flash[:alert]).to include 'There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.' + expect(flash[:alert]).to include _('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.') expect(subject.current_user).to be_nil end @@ -259,7 +259,7 @@ RSpec.describe SessionsController do unsuccesful_login(user_params, sesion_params: { failed_login_attempts: 6 }) expect(response).to render_template(:new) - expect(flash[:alert]).to include 'There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.' + expect(flash[:alert]).to include _('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.') expect(subject.current_user).to be_nil end @@ -279,7 +279,7 @@ RSpec.describe SessionsController do unsuccesful_login(user_params) expect(response).to render_template(:new) - expect(flash[:alert]).to include 'There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.' + expect(flash[:alert]).to include _('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.') expect(subject.current_user).to be_nil end diff --git a/spec/features/users/signup_spec.rb b/spec/features/users/signup_spec.rb index a651a6c09c6..013942a1fb3 100644 --- a/spec/features/users/signup_spec.rb +++ b/spec/features/users/signup_spec.rb @@ -324,7 +324,7 @@ RSpec.describe 'Signup' do fill_in_signup_form expect { click_button 'Register' }.not_to change { User.count } - expect(page).to have_content('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.') + expect(page).to have_content(_('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.')) end end diff --git a/spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb b/spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb new file mode 100644 index 00000000000..90dd3e14606 --- /dev/null +++ b/spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb @@ -0,0 +1,49 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Gitlab::BackgroundMigration::NullifyOrphanRunnerIdOnCiBuilds, :migration, schema: 20220223112304 do + let(:namespaces) { table(:namespaces) } + let(:projects) { table(:projects) } + let(:ci_runners) { table(:ci_runners) } + let(:ci_pipelines) { table(:ci_pipelines) } + let(:ci_builds) { table(:ci_builds) } + + subject { described_class.new } + + let(:helpers) do + ActiveRecord::Migration.new.extend(Gitlab::Database::MigrationHelpers) + end + + before do + helpers.remove_foreign_key_if_exists(:ci_builds, column: :runner_id) + end + + after do + helpers.add_concurrent_foreign_key(:ci_builds, :ci_runners, column: :runner_id, on_delete: :nullify, validate: false) + end + + describe '#perform' do + let(:namespace) { namespaces.create!(name: 'test', path: 'test', type: 'Group') } + let(:project) { projects.create!(namespace_id: namespace.id, name: 'test') } + let(:pipeline) { ci_pipelines.create!(project_id: project.id, ref: 'master', sha: 'adf43c3a', status: 'success') } + + it 'nullifies runner_id for orphan ci_builds in range' do + ci_runners.create!(id: 2, runner_type: 'project_type') + + ci_builds.create!(id: 5, type: 'Ci::Build', commit_id: pipeline.id, runner_id: 2) + ci_builds.create!(id: 7, type: 'Ci::Build', commit_id: pipeline.id, runner_id: 4) + ci_builds.create!(id: 8, type: 'Ci::Build', commit_id: pipeline.id, runner_id: 5) + ci_builds.create!(id: 9, type: 'Ci::Build', commit_id: pipeline.id, runner_id: 6) + + subject.perform(4, 8, :ci_builds, :id, 10, 0) + + expect(ci_builds.all).to contain_exactly( + an_object_having_attributes(id: 5, runner_id: 2), + an_object_having_attributes(id: 7, runner_id: nil), + an_object_having_attributes(id: 8, runner_id: nil), + an_object_having_attributes(id: 9, runner_id: 6) + ) + end + end +end diff --git a/spec/models/concerns/spammable_spec.rb b/spec/models/concerns/spammable_spec.rb index 5edaab56e2d..baa2d75705a 100644 --- a/spec/models/concerns/spammable_spec.rb +++ b/spec/models/concerns/spammable_spec.rb @@ -55,7 +55,7 @@ RSpec.describe Spammable do subject { invalidate_if_spam(needs_recaptcha: true) } it 'has an error related to spam on the model' do - expect(subject.errors.messages[:base]).to match_array /solve the reCAPTCHA/ + expect(subject.errors.messages[:base]).to match_array /content or solve the/ end end @@ -63,7 +63,7 @@ RSpec.describe Spammable do subject { invalidate_if_spam(is_spam: true, needs_recaptcha: true) } it 'has an error related to spam on the model' do - expect(subject.errors.messages[:base]).to match_array /solve the reCAPTCHA/ + expect(subject.errors.messages[:base]).to match_array /content or solve the/ end end diff --git a/spec/requests/api/users_spec.rb b/spec/requests/api/users_spec.rb index 985e07bf174..970000b5a82 100644 --- a/spec/requests/api/users_spec.rb +++ b/spec/requests/api/users_spec.rb @@ -1735,6 +1735,33 @@ RSpec.describe API::Users do end end + describe 'GET /user/:id/keys/:key_id' do + it 'gets existing key', :aggregate_failures do + user.keys << key + + get api("/users/#{user.id}/keys/#{key.id}") + + expect(response).to have_gitlab_http_status(:ok) + expect(json_response['title']).to eq(key.title) + end + + it 'returns 404 error if user not found', :aggregate_failures do + user.keys << key + + get api("/users/0/keys/#{key.id}") + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 User Not Found') + end + + it 'returns 404 error if key not found', :aggregate_failures do + get api("/users/#{user.id}/keys/#{non_existing_record_id}") + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Key Not Found') + end + end + describe 'DELETE /user/:id/keys/:key_id' do context 'when unauthenticated' do it 'returns authentication error' do diff --git a/spec/rubocop/cop/database/multiple_databases_spec.rb b/spec/rubocop/cop/database/multiple_databases_spec.rb index 16b916d61db..8bcd4710305 100644 --- a/spec/rubocop/cop/database/multiple_databases_spec.rb +++ b/spec/rubocop/cop/database/multiple_databases_spec.rb @@ -12,4 +12,14 @@ RSpec.describe RuboCop::Cop::Database::MultipleDatabases do ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use methods from ActiveRecord::Base, [...] SOURCE end + + described_class::ALLOWED_METHODS.each do |method_name| + it "does not flag use of ActiveRecord::Base.#{method_name}" do + expect_no_offenses(<<~SOURCE) + ActiveRecord::Base.#{method_name} do + Project.save + end + SOURCE + end + end end