kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Removes the duplicated search icon in emoji menu 

The search emojis title had the same class as the search input which
caused a duplicated icon.

Closes #30416
This commit is contained in:
Phil Hughes 2017-04-05 10:56:40 +01:00
parent 65ea732cfe
commit ab79c76d0c
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/awards_handler.js
View File

@ -476,10 +476,10 @@ AwardsHandler.prototype.setupSearch = function setupSearch() {
this.registerEventListener('on', $('input.emoji-search'), 'input', (e) => {
const term = $(e.target).val().trim();
// Clean previous search results
$('ul.emoji-menu-search, h5.emoji-search').remove();
$('ul.emoji-menu-search, h5.emoji-search-title').remove();
if (term.length > 0) {
// Generate a search result block
const h5 = $('<h5 class="emoji-search" />').text('Search results');
const h5 = $('<h5 class="emoji-search-title"/>').text('Search results');
const foundEmojis = this.searchEmojis(term).show();
const ul = $('<ul>').addClass('emoji-menu-list emoji-menu-search').append(foundEmojis);
$('.emoji-menu-content ul, .emoji-menu-content h5').hide();

4
changelogs/unreleased/emoji-menu-duplicated-search-icon.yml Normal file
View File

@ -0,0 +1,4 @@
---
title: Removed the duplicated search icon in the award emoji menu
merge_request:
author: