Make subgroup_creation_level default to maintainer at SQL level
- Migration updates existing groups to "owner", then sets default to "maintainer" so that new groups will default to that - Update spec examples
This commit is contained in:
parent
b51ffa2e0c
commit
ac759aaaca
|
@ -5,7 +5,6 @@ FactoryBot.define do
|
||||||
type 'Group'
|
type 'Group'
|
||||||
owner nil
|
owner nil
|
||||||
project_creation_level ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS
|
project_creation_level ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS
|
||||||
subgroup_creation_level ::Gitlab::Access::OWNER_SUBGROUP_ACCESS
|
|
||||||
|
|
||||||
after(:create) do |group|
|
after(:create) do |group|
|
||||||
if group.owner
|
if group.owner
|
||||||
|
|
|
@ -803,10 +803,10 @@ describe API::Groups do
|
||||||
group2.add_maintainer(user1)
|
group2.add_maintainer(user1)
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'cannot create subgroups' do
|
it 'can create subgroups' do
|
||||||
post api("/groups", user1), params: { parent_id: group2.id, name: 'foo', path: 'foo' }
|
post api("/groups", user1), params: { parent_id: group2.id, name: 'foo', path: 'foo' }
|
||||||
|
|
||||||
expect(response).to have_gitlab_http_status(403)
|
expect(response).to have_gitlab_http_status(201)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in New Issue