kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Few code improvements for spec/lib/gitlab/plugin_spec.rb

Browse source 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
This commit is contained in:
Dmitriy Zaporozhets 2018-02-27 14:33:32 +02:00
parent 79d911204c
commit ac8a0fa061
No known key found for this signature in database
GPG key ID: 627C5F589F467F17
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
spec/lib/gitlab/plugin_spec.rb
View file

@ -4,7 +4,7 @@ describe Gitlab::Plugin do
describe '.execute' do
let(:data) { Gitlab::DataBuilder::Push::SAMPLE_DATA }
let(:plugin) { Rails.root.join('plugins', 'test.rb') }
let(:tmp_file) { Tempfile.new('plugin-dump').path }
let(:tmp_file) { Tempfile.new('plugin-dump') }
before do
File.write(plugin, plugin_source)
@ -13,7 +13,7 @@ describe Gitlab::Plugin do
after do
FileUtils.rm(plugin)
FileUtils.rm(tmp_file)
tmp_file.close!
end
subject { described_class.execute(plugin.to_s, data) }
@ -23,17 +23,17 @@ describe Gitlab::Plugin do
it 'ensures plugin received data via stdin' do
subject
expect(File.read(tmp_file)).to eq(data.to_json)
expect(File.read(tmp_file.path)).to eq(data.to_json)
end
end
private
def plugin_source
<<-EOS
#!/usr/bin/env ruby
x = STDIN.read
File.write('#{tmp_file}', x)
<<~EOS
#!/usr/bin/env ruby
x = STDIN.read
File.write('#{tmp_file.path}', x)
EOS
end
end