kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix static anylysy

Browse source
This commit is contained in:
Shinya Maeda 2018-01-05 15:22:45 +09:00
parent b8a275d3e4
commit acfb8464be
2 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
db/post_migrate/20171124104327_migrate_kubernetes_service_to_new_clusters_architectures.rb
View file

@ -85,9 +85,10 @@ class MigrateKubernetesServiceToNewClustersArchitectures < ActiveRecord::Migrati
unique_iid = 0 unique_iid = 0
# If it's still conflicted, finding an unique environment scope incrementaly # If it's still conflicted, finding an unique environment scope incrementaly
while true loop do
candidate = "migrated#{unique_iid}/*" candidate = "migrated#{unique_iid}/*"
return candidate if environment_scopes.exclude?(candidate) return candidate if environment_scopes.exclude?(candidate)
unique_iid += 1 unique_iid += 1
end end
end end

14
spec/migrations/migrate_kubernetes_service_to_new_clusters_architectures_spec.rb
View file

@ -19,7 +19,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
end end
it 'migrates the KubernetesService to Platform::Kubernetes' do it 'migrates the KubernetesService to Platform::Kubernetes' do
expect{ migrate! }.to change { Clusters::Cluster.count }.by(sample_num) expect { migrate! }.to change { Clusters::Cluster.count }.by(sample_num)
projects.each do |project| projects.each do |project|
project.clusters.last.tap do |cluster| project.clusters.last.tap do |cluster|
@ -76,7 +76,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
end end
it 'migrates the KubernetesService to Platform::Kubernetes without template' do it 'migrates the KubernetesService to Platform::Kubernetes without template' do
expect{ migrate! }.to change { Clusters::Cluster.count }.by(sample_num) expect { migrate! }.to change { Clusters::Cluster.count }.by(sample_num)
projects.each do |project| projects.each do |project|
project.clusters.last.tap do |cluster| project.clusters.last.tap do |cluster|
@ -104,7 +104,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
end end
it 'does not migrate the KubernetesService and disables the kubernetes_service' do # Because the corresponding Platform::Kubernetes already exists it 'does not migrate the KubernetesService and disables the kubernetes_service' do # Because the corresponding Platform::Kubernetes already exists
expect{ migrate! }.not_to change { Clusters::Cluster.count } expect { migrate! }.not_to change { Clusters::Cluster.count }
kubernetes_service.reload kubernetes_service.reload
expect(kubernetes_service).not_to be_active expect(kubernetes_service).not_to be_active
@ -117,7 +117,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) } let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) }
it 'migrates the KubernetesService to Platform::Kubernetes' do it 'migrates the KubernetesService to Platform::Kubernetes' do
expect{ migrate! }.to change { Clusters::Cluster.count }.by(1) expect { migrate! }.to change { Clusters::Cluster.count }.by(1)
kubernetes_service.reload kubernetes_service.reload
project.clusters.last.tap do |cluster| project.clusters.last.tap do |cluster|
@ -136,7 +136,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) } let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) }
it 'migrates the KubernetesService to Platform::Kubernetes with dedicated environment_scope' do # Because environment_scope is duplicated it 'migrates the KubernetesService to Platform::Kubernetes with dedicated environment_scope' do # Because environment_scope is duplicated
expect{ migrate! }.to change { Clusters::Cluster.count }.by(1) expect { migrate! }.to change { Clusters::Cluster.count }.by(1)
kubernetes_service.reload kubernetes_service.reload
project.clusters.last.tap do |cluster| project.clusters.last.tap do |cluster|
@ -156,7 +156,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) } let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) }
it 'migrates the KubernetesService to Platform::Kubernetes with dedicated environment_scope' do # Because environment_scope is duplicated it 'migrates the KubernetesService to Platform::Kubernetes with dedicated environment_scope' do # Because environment_scope is duplicated
expect{ migrate! }.to change { Clusters::Cluster.count }.by(1) expect { migrate! }.to change { Clusters::Cluster.count }.by(1)
kubernetes_service.reload kubernetes_service.reload
project.clusters.last.tap do |cluster| project.clusters.last.tap do |cluster|
@ -173,7 +173,7 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
let!(:project) { create(:project) } let!(:project) { create(:project) }
it 'does not migrate the KubernetesService' do it 'does not migrate the KubernetesService' do
expect{ migrate! }.not_to change { Clusters::Cluster.count } expect { migrate! }.not_to change { Clusters::Cluster.count }
end end
end end
end end