kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Skip dead jobs queue for web hooks and project services

Browse source 
These jobs may legitimately fail because the endpoint just isn't there any
more. We don't want them cluttering up the Sidekiq morgue in that case - it's
currently full on GitLab.com.
This commit is contained in:
Sean McGivern 2017-07-17 16:38:02 +01:00
parent 05329d4a36
commit ae10151b42
3 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/workers/project_service_worker.rb
View file

@ -2,6 +2,8 @@ class ProjectServiceWorker
include Sidekiq::Worker include Sidekiq::Worker
include DedicatedSidekiqQueue include DedicatedSidekiqQueue
sidekiq_options dead: false
def perform(hook_id, data) def perform(hook_id, data)
data = data.with_indifferent_access data = data.with_indifferent_access
Service.find(hook_id).execute(data) Service.find(hook_id).execute(data)

2
app/workers/web_hook_worker.rb
View file

@ -2,7 +2,7 @@ class WebHookWorker
include Sidekiq::Worker include Sidekiq::Worker
include DedicatedSidekiqQueue include DedicatedSidekiqQueue
sidekiq_options retry: 4 sidekiq_options retry: 4, dead: false
def perform(hook_id, data, hook_name) def perform(hook_id, data, hook_name)
hook = WebHook.find(hook_id) hook = WebHook.find(hook_id)

5
changelogs/unreleased/31571-don-t-let-webhooks-jobs-go-to-the-dead-jobs-queue.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Prevent web hook and project service background jobs from going to the dead
jobs queue
merge_request:
author: