From af0c69170695f43b15db9c93ae2f2b8ebaaa96b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Wed, 7 Jun 2017 22:21:05 +0200 Subject: [PATCH] Improve the JS for the `p b` shortcut and fix its CSS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- app/assets/javascripts/shortcuts.js | 7 ++++--- vendor/assets/stylesheets/peek.scss | 5 ----- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/shortcuts.js b/app/assets/javascripts/shortcuts.js index 09cb914e884..a4a7f3fa944 100644 --- a/app/assets/javascripts/shortcuts.js +++ b/app/assets/javascripts/shortcuts.js @@ -58,10 +58,11 @@ import findAndFollowLink from './shortcuts_dashboard_navigation'; Shortcuts.prototype.onTogglePerfBar = function(e) { e.preventDefault(); - if (Cookies.get('perf_bar_enabled') === 'true') { - Cookies.remove('perf_bar_enabled', { path: '/' }); + const performanceBarCookieName = 'perf_bar_enabled'; + if (Cookies.get(performanceBarCookieName) === 'true') { + Cookies.remove(performanceBarCookieName, { path: '/' }); } else { - Cookies.set('perf_bar_enabled', true, { path: '/' }); + Cookies.set(performanceBarCookieName, true, { path: '/' }); } gl.utils.refreshCurrentPage(); }; diff --git a/vendor/assets/stylesheets/peek.scss b/vendor/assets/stylesheets/peek.scss index 3508f2e2450..f1845fb9044 100644 --- a/vendor/assets/stylesheets/peek.scss +++ b/vendor/assets/stylesheets/peek.scss @@ -6,12 +6,7 @@ header.navbar-gitlab.with-peek { } #peek { - position: fixed; - top: 0; - left: 0; - width: 100%; height: 35px; - z-index: 400; background: #000; line-height: 35px; color: #999;