kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

clean up component tests

This commit is contained in:
Dennis Tang 2018-05-11 10:20:48 +02:00
parent 918077a0b6
commit af3dd04361
3 changed files with 20 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spec/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown_spec.js
View File

@ -84,10 +84,10 @@ describe('GkeMachineTypeDropdown', () => {
expect(vm.$el.querySelector('input').value).toBe('');
vm.$store.commit(SET_MACHINE_TYPES, gapiMachineTypesResponseMock.items);
vm.$nextTick(() => {
return vm.$nextTick().then(() => {
vm.$el.querySelector('.dropdown-content button').click();
vm.$nextTick(() => {
return vm.$nextTick().then(() => {
expect(vm.$el.querySelector('input').value).toBe(selectedMachineTypeMock);
done();
});

39
spec/javascripts/projects/gke_cluster_dropdowns/components/gke_project_id_dropdown_spec.js
View File

@ -43,34 +43,28 @@ describe('GkeProjectIdDropdown', () => {
});
it('returns default toggle text', done => {
vm.$nextTick(() => {
vm.$nextTick(() => {
vm.setItem(emptyProjectMock);
return vm.$nextTick().then(() => {
vm.setItem(emptyProjectMock);
expect(vm.toggleText).toBe(LABELS.DEFAULT);
done();
});
expect(vm.toggleText).toBe(LABELS.DEFAULT);
done();
});
});
it('returns project name if project selected', done => {
vm.$nextTick(() => {
vm.$nextTick(() => {
expect(vm.toggleText).toBe(selectedProjectMock.name);
done();
});
return vm.$nextTick().then(() => {
expect(vm.toggleText).toBe(selectedProjectMock.name);
done();
});
});
it('returns empty toggle text', done => {
vm.$nextTick(() => {
return vm.$nextTick().then(() => {
vm.$store.commit(SET_PROJECTS, []);
vm.setItem(emptyProjectMock);
vm.$nextTick(() => {
expect(vm.toggleText).toBe(LABELS.EMPTY);
done();
});
expect(vm.toggleText).toBe(LABELS.EMPTY);
done();
});
});
});
@ -79,13 +73,12 @@ describe('GkeProjectIdDropdown', () => {
it('reflects new value when dropdown item is clicked', done => {
expect(vm.$el.querySelector('input').value).toBe('');
vm.$nextTick(() => {
vm.$nextTick(() => {
vm.$el.querySelector('.dropdown-content button').click();
vm.$nextTick(() => {
expect(vm.$el.querySelector('input').value).toBe(selectedProjectMock.projectId);
done();
});
return vm.$nextTick().then(() => {
vm.$el.querySelector('.dropdown-content button').click();
return vm.$nextTick().then(() => {
expect(vm.$el.querySelector('input').value).toBe(selectedProjectMock.projectId);
done();
});
});
});

4
spec/javascripts/projects/gke_cluster_dropdowns/components/gke_zone_dropdown_spec.js
View File

@ -66,10 +66,10 @@ describe('GkeZoneDropdown', () => {
expect(vm.$el.querySelector('input').value).toBe('');
vm.$store.commit(SET_ZONES, gapiZonesResponseMock.items);
vm.$nextTick(() => {
return vm.$nextTick().then(() => {
vm.$el.querySelector('.dropdown-content button').click();
vm.$nextTick(() => {
return vm.$nextTick().then(() => {
expect(vm.$el.querySelector('input').value).toBe(selectedZoneMock);
done();
});