diff --git a/.rubocop_todo/graphql/ordered_arguments.yml b/.rubocop_todo/graphql/ordered_arguments.yml index c153d52afc6..8477a07d6ef 100644 --- a/.rubocop_todo/graphql/ordered_arguments.yml +++ b/.rubocop_todo/graphql/ordered_arguments.yml @@ -3,9 +3,6 @@ GraphQL/OrderedArguments: Exclude: - app/graphql/mutations/jira_import/start.rb - app/graphql/mutations/merge_requests/accept.rb - - app/graphql/resolvers/base_issues_resolver.rb - - app/graphql/resolvers/design_management/designs_resolver.rb - - app/graphql/resolvers/design_management/version/design_at_version_resolver.rb - app/graphql/resolvers/design_management/version/designs_at_version_resolver.rb - app/graphql/resolvers/design_management/version_in_collection_resolver.rb - app/graphql/resolvers/group_milestones_resolver.rb diff --git a/.rubocop_todo/performance/active_record_subtransaction_methods.yml b/.rubocop_todo/performance/active_record_subtransaction_methods.yml index 0fcedb3ffc6..ada27f99eb9 100644 --- a/.rubocop_todo/performance/active_record_subtransaction_methods.yml +++ b/.rubocop_todo/performance/active_record_subtransaction_methods.yml @@ -10,7 +10,6 @@ Performance/ActiveRecordSubtransactionMethods: - app/models/design_management/design_collection.rb - app/models/error_tracking/error.rb - app/models/external_pull_request.rb - - app/models/gpg_signature.rb - app/models/merge_request.rb - app/models/plan.rb - app/models/project.rb @@ -18,6 +17,7 @@ Performance/ActiveRecordSubtransactionMethods: - app/models/x509_certificate.rb - app/models/x509_commit_signature.rb - app/models/x509_issuer.rb + - app/models/concerns/commit_signature.rb - app/services/bulk_imports/relation_export_service.rb - app/services/ci/update_build_state_service.rb - app/services/event_create_service.rb diff --git a/.rubocop_todo/rails/save_bang.yml b/.rubocop_todo/rails/save_bang.yml index 9f9d7129bb9..b4acd62a4e2 100644 --- a/.rubocop_todo/rails/save_bang.yml +++ b/.rubocop_todo/rails/save_bang.yml @@ -3,9 +3,6 @@ Rails/SaveBang: Exclude: - ee/spec/initializers/fog_google_https_private_urls_spec.rb - ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb - - ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb - - ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb - - ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - ee/spec/lib/gitlab/auth/o_auth/user_spec.rb - ee/spec/lib/gitlab/auth/saml/user_spec.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 4c61a482397..ad5290c80a3 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -27dddad834d99e9901b4a9b137748b850e71849a +9aa8e36d420402b19210dcf861f7bf619ff39089 diff --git a/GITLAB_ELASTICSEARCH_INDEXER_VERSION b/GITLAB_ELASTICSEARCH_INDEXER_VERSION index 75249069675..d76bd2ba3ef 100644 --- a/GITLAB_ELASTICSEARCH_INDEXER_VERSION +++ b/GITLAB_ELASTICSEARCH_INDEXER_VERSION @@ -1 +1 @@ -2.16.0 +2.17.0 diff --git a/Gemfile b/Gemfile index 8dd01dc9141..97b1fe2696d 100644 --- a/Gemfile +++ b/Gemfile @@ -194,7 +194,7 @@ end gem 'state_machines-activerecord', '~> 0.8.0' # Issue tags -gem 'acts-as-taggable-on', '~> 7.0' +gem 'acts-as-taggable-on', '~> 8.1' # Background jobs gem 'sidekiq', '~> 6.3' diff --git a/Gemfile.lock b/Gemfile.lock index ba93e7ce6df..de948ac7d19 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -73,7 +73,7 @@ GEM minitest (>= 5.1) tzinfo (~> 2.0) zeitwerk (~> 2.3) - acts-as-taggable-on (7.0.0) + acts-as-taggable-on (8.1.0) activerecord (>= 5.0, < 6.2) addressable (2.8.0) public_suffix (>= 2.0.2, < 5.0) @@ -1390,7 +1390,7 @@ DEPENDENCIES RedCloth (~> 4.3.2) acme-client (~> 2.0, >= 2.0.6) activerecord-explain-analyze (~> 0.1) - acts-as-taggable-on (~> 7.0) + acts-as-taggable-on (~> 8.1) addressable (~> 2.8) akismet (~> 3.0) apollo_upload_server (~> 2.1.0) diff --git a/app/assets/javascripts/header_search/store/getters.js b/app/assets/javascripts/header_search/store/getters.js index 85112a317cf..a1348a8aa3f 100644 --- a/app/assets/javascripts/header_search/store/getters.js +++ b/app/assets/javascripts/header_search/store/getters.js @@ -1,3 +1,4 @@ +import { omitBy, isNil } from 'lodash'; import { objectToQuery } from '~/lib/utils/url_utility'; import { @@ -12,23 +13,29 @@ import { } from '../constants'; export const searchQuery = (state) => { - const query = { - search: state.search, - nav_source: 'navbar', - project_id: state.searchContext.project?.id, - group_id: state.searchContext.group?.id, - scope: state.searchContext.scope, - }; + const query = omitBy( + { + search: state.search, + nav_source: 'navbar', + project_id: state.searchContext.project?.id, + group_id: state.searchContext.group?.id, + scope: state.searchContext?.scope, + }, + isNil, + ); return `${state.searchPath}?${objectToQuery(query)}`; }; export const autocompleteQuery = (state) => { - const query = { - term: state.search, - project_id: state.searchContext.project?.id, - project_ref: state.searchContext.ref, - }; + const query = omitBy( + { + term: state.search, + project_id: state.searchContext.project?.id, + project_ref: state.searchContext?.ref, + }, + isNil, + ); return `${state.autocompletePath}?${objectToQuery(query)}`; }; @@ -82,42 +89,43 @@ export const defaultSearchOptions = (state, getters) => { }; export const projectUrl = (state) => { - if (!state.searchContext.project || !state.searchContext.group) { - return null; - } - - const query = { - search: state.search, - nav_source: 'navbar', - project_id: state.searchContext.project.id, - group_id: state.searchContext.group.id, - scope: state.searchContext.scope, - }; + const query = omitBy( + { + search: state.search, + nav_source: 'navbar', + project_id: state.searchContext?.project?.id, + group_id: state.searchContext?.group?.id, + scope: state.searchContext?.scope, + }, + isNil, + ); return `${state.searchPath}?${objectToQuery(query)}`; }; export const groupUrl = (state) => { - if (!state.searchContext.group) { - return null; - } - - const query = { - search: state.search, - nav_source: 'navbar', - group_id: state.searchContext.group.id, - scope: state.searchContext.scope, - }; + const query = omitBy( + { + search: state.search, + nav_source: 'navbar', + group_id: state.searchContext?.group?.id, + scope: state.searchContext?.scope, + }, + isNil, + ); return `${state.searchPath}?${objectToQuery(query)}`; }; export const allUrl = (state) => { - const query = { - search: state.search, - nav_source: 'navbar', - scope: state.searchContext.scope, - }; + const query = omitBy( + { + search: state.search, + nav_source: 'navbar', + scope: state.searchContext?.scope, + }, + isNil, + ); return `${state.searchPath}?${objectToQuery(query)}`; }; diff --git a/app/assets/javascripts/integrations/edit/components/jira_issues_fields.vue b/app/assets/javascripts/integrations/edit/components/jira_issues_fields.vue index cd0624d6b5c..99498501f6c 100644 --- a/app/assets/javascripts/integrations/edit/components/jira_issues_fields.vue +++ b/app/assets/javascripts/integrations/edit/components/jira_issues_fields.vue @@ -117,7 +117,11 @@ export default {