diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index c083116cc27..334eb4b1430 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -499,6 +499,7 @@ .review:rules:review-gcp-cleanup: rules: - <<: *if-dot-com-gitlab-org-merge-request + changes: *code-qa-patterns when: manual - <<: *if-dot-com-gitlab-org-schedule when: on_success diff --git a/.rubocop.yml b/.rubocop.yml index 2544675eea3..5e2cde935b2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -422,7 +422,6 @@ RSpec/RepeatedExample: - 'spec/services/notification_service_spec.rb' - 'spec/services/web_hook_service_spec.rb' - 'ee/spec/models/group_spec.rb' - - 'ee/spec/models/user_spec.rb' - 'ee/spec/requests/api/merge_request_approvals_spec.rb' - 'ee/spec/services/boards/lists/update_service_spec.rb' - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' diff --git a/app/assets/javascripts/diffs/components/diff_file_header.vue b/app/assets/javascripts/diffs/components/diff_file_header.vue index d4270960f57..c51f711fb81 100644 --- a/app/assets/javascripts/diffs/components/diff_file_header.vue +++ b/app/assets/javascripts/diffs/components/diff_file_header.vue @@ -172,7 +172,6 @@ export default { /> @@ -29,8 +26,8 @@ export default {
- - + +
diff --git a/app/assets/javascripts/snippets/components/snippet_description_edit.vue b/app/assets/javascripts/snippets/components/snippet_description_edit.vue index 5b70ac5b715..68810f8ab3f 100644 --- a/app/assets/javascripts/snippets/components/snippet_description_edit.vue +++ b/app/assets/javascripts/snippets/components/snippet_description_edit.vue @@ -9,11 +9,6 @@ export default { MarkdownField, }, props: { - description: { - type: String, - default: '', - required: false, - }, markdownPreviewPath: { type: String, required: true, @@ -22,11 +17,11 @@ export default { type: String, required: true, }, - }, - data() { - return { - text: this.description, - }; + value: { + type: String, + required: false, + default: '', + }, }, mounted() { setupCollapsibleInputs(); @@ -37,7 +32,7 @@ export default {
-
+
diff --git a/app/assets/javascripts/snippets/components/snippet_visibility_edit.vue b/app/assets/javascripts/snippets/components/snippet_visibility_edit.vue index 93cd2b58c11..80710a88bb2 100644 --- a/app/assets/javascripts/snippets/components/snippet_visibility_edit.vue +++ b/app/assets/javascripts/snippets/components/snippet_visibility_edit.vue @@ -1,6 +1,6 @@