From b1bf2d535a931b74e12bda5d158e8de9744a4fef Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Wed, 27 Sep 2017 12:10:01 +0100 Subject: [PATCH] Changes after review --- .../registry/components/collapsible_container.vue | 11 ++++++----- .../registry/components/table_registry.vue | 3 +-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/assets/javascripts/registry/components/collapsible_container.vue b/app/assets/javascripts/registry/components/collapsible_container.vue index 170070ff92c..255834a9a12 100644 --- a/app/assets/javascripts/registry/components/collapsible_container.vue +++ b/app/assets/javascripts/registry/components/collapsible_container.vue @@ -29,6 +29,11 @@ isOpen: false, }; }, + computed: { + clipboardText() { + return `docker pull ${this.repo.location}`; + }, + }, methods: { ...mapActions([ 'fetchRepos', @@ -51,10 +56,6 @@ .catch(() => this.showError(errorMessagesTypes.DELETE_REPO)); }, - clipboardText(text) { - return `docker pull ${text}`; - }, - showError(message) { Flash((errorMessages[message])); }, @@ -83,7 +84,7 @@ diff --git a/app/assets/javascripts/registry/components/table_registry.vue b/app/assets/javascripts/registry/components/table_registry.vue index ba2dd856e0c..3ab771de8d4 100644 --- a/app/assets/javascripts/registry/components/table_registry.vue +++ b/app/assets/javascripts/registry/components/table_registry.vue @@ -38,8 +38,7 @@ ]), layers(item) { - const pluralize = n__('layer', 'layers', item.layers); - return `${item.layers} ${pluralize}`; + return n__('%d layer', '%d layers', item.layers); }, handleDeleteRegistry(registry) {