diff --git a/.gitlab/ci/review.gitlab-ci.yml b/.gitlab/ci/review.gitlab-ci.yml index 682ed12e199..c15c7c2ab5d 100644 --- a/.gitlab/ci/review.gitlab-ci.yml +++ b/.gitlab/ci/review.gitlab-ci.yml @@ -126,7 +126,6 @@ review-build-cng: - .default-tags - .default-retry image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base - dependencies: [] variables: HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}" DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}" @@ -142,6 +141,9 @@ review-deploy: - .review-workflow-base - .review:rules:mr-and-schedule stage: review + needs: + - job: review-build-cng + artifacts: false allow_failure: true before_script: - '[[ ! -d "ee/" ]] || export GITLAB_EDITION="ee"' @@ -169,6 +171,7 @@ review-deploy: extends: .review-workflow-base environment: action: stop + dependencies: [] variables: # We're cloning the repo instead of downloading the script for now # because some repos are private and CI_JOB_TOKEN cannot access files. diff --git a/app/assets/javascripts/diffs/components/diff_file_row.vue b/app/assets/javascripts/diffs/components/diff_file_row.vue index f41337762fd..5aaed0d40db 100644 --- a/app/assets/javascripts/diffs/components/diff_file_row.vue +++ b/app/assets/javascripts/diffs/components/diff_file_row.vue @@ -4,14 +4,34 @@ * https://gitlab.com/gitlab-org/gitlab/-/merge_requests/23720 */ import FileRow from '~/vue_shared/components/file_row.vue'; +import FileRowStats from './file_row_stats.vue'; export default { + name: 'DiffFileRow', components: { FileRow, + FileRowStats, + }, + props: { + file: { + type: Object, + required: true, + }, + hideFileStats: { + type: Boolean, + required: true, + }, + }, + computed: { + showFileRowStats() { + return !this.hideFileStats && this.file.type === 'blob'; + }, }, }; diff --git a/app/assets/javascripts/diffs/components/tree_list.vue b/app/assets/javascripts/diffs/components/tree_list.vue index 18c3002825e..1eac3430a20 100644 --- a/app/assets/javascripts/diffs/components/tree_list.vue +++ b/app/assets/javascripts/diffs/components/tree_list.vue @@ -5,7 +5,6 @@ import { s__, sprintf } from '~/locale'; import Icon from '~/vue_shared/components/icon.vue'; import FileTree from '~/vue_shared/components/file_tree.vue'; import DiffFileRow from './diff_file_row.vue'; -import FileRowStats from './file_row_stats.vue'; export default { directives: { @@ -49,9 +48,6 @@ export default { return acc; }, []); }, - fileRowExtraComponent() { - return this.hideFileStats ? null : FileRowStats; - }, }, methods: { ...mapActions('diffs', ['toggleTreeOpen', 'scrollToFile']), @@ -98,8 +94,8 @@ export default { :key="file.key" :file="file" :level="0" + :hide-file-stats="hideFileStats" :hide-extra-on-tree="true" - :extra-component="fileRowExtraComponent" :show-changed-icon="true" :file-row-component="$options.DiffFileRow" @toggleTreeOpen="toggleTreeOpen" diff --git a/app/assets/javascripts/gfm_auto_complete.js b/app/assets/javascripts/gfm_auto_complete.js index 6f486e1a539..fa2e3f94f87 100644 --- a/app/assets/javascripts/gfm_auto_complete.js +++ b/app/assets/javascripts/gfm_auto_complete.js @@ -719,7 +719,7 @@ GfmAutoComplete.Milestones = { }; GfmAutoComplete.Loading = { template: - '
  • Loading...
  • ', + '
  • Loading...
  • ', }; export default GfmAutoComplete; diff --git a/app/assets/javascripts/ide/components/ide_file_row.vue b/app/assets/javascripts/ide/components/ide_file_row.vue index f41337762fd..b777d89f0bb 100644 --- a/app/assets/javascripts/ide/components/ide_file_row.vue +++ b/app/assets/javascripts/ide/components/ide_file_row.vue @@ -4,14 +4,35 @@ * https://gitlab.com/gitlab-org/gitlab/-/merge_requests/23720 */ import FileRow from '~/vue_shared/components/file_row.vue'; +import FileRowExtra from './file_row_extra.vue'; export default { + name: 'IdeFileRow', components: { FileRow, + FileRowExtra, + }, + props: { + file: { + type: Object, + required: true, + }, + }, + data() { + return { + dropdownOpen: false, + }; + }, + methods: { + toggleDropdown(val) { + this.dropdownOpen = val; + }, }, }; diff --git a/app/assets/javascripts/ide/components/ide_tree_list.vue b/app/assets/javascripts/ide/components/ide_tree_list.vue index 151f7f0c421..36e8951bea3 100644 --- a/app/assets/javascripts/ide/components/ide_tree_list.vue +++ b/app/assets/javascripts/ide/components/ide_tree_list.vue @@ -4,7 +4,6 @@ import { GlSkeletonLoading } from '@gitlab/ui'; import FileTree from '~/vue_shared/components/file_tree.vue'; import IdeFileRow from './ide_file_row.vue'; import NavDropdown from './nav_dropdown.vue'; -import FileRowExtra from './file_row_extra.vue'; export default { components: { @@ -36,7 +35,6 @@ export default { methods: { ...mapActions(['updateViewer', 'toggleTreeOpen']), }, - FileRowExtra, IdeFileRow, }; @@ -60,7 +58,6 @@ export default { :key="file.key" :file="file" :level="0" - :extra-component="$options.FileRowExtra" :file-row-component="$options.IdeFileRow" @toggleTreeOpen="toggleTreeOpen" /> diff --git a/app/assets/javascripts/main.js b/app/assets/javascripts/main.js index 8fb973b1c1f..5b645b032ed 100644 --- a/app/assets/javascripts/main.js +++ b/app/assets/javascripts/main.js @@ -201,9 +201,15 @@ document.addEventListener('DOMContentLoaded', () => { }); if (bootstrapBreakpoint === 'sm' || bootstrapBreakpoint === 'xs') { - const $rightSidebar = $('aside.right-sidebar, .layout-page'); + const $rightSidebar = $('aside.right-sidebar'); + const $layoutPage = $('.layout-page'); - $rightSidebar.removeClass('right-sidebar-expanded').addClass('right-sidebar-collapsed'); + if ($rightSidebar.length > 0) { + $rightSidebar.removeClass('right-sidebar-expanded').addClass('right-sidebar-collapsed'); + $layoutPage.removeClass('right-sidebar-expanded').addClass('right-sidebar-collapsed'); + } else { + $layoutPage.removeClass('right-sidebar-expanded right-sidebar-collapsed'); + } } // prevent default action for disabled buttons diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue index 2aaba6e1c8a..7c71463c949 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue @@ -77,7 +77,7 @@ export default { };