Merge branch 'add-test-for-snippet-download' into 'master'
Adds test for feature in this MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6720 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6720 See merge request !6854
This commit is contained in:
commit
b33e04f9b2
1 changed files with 100 additions and 90 deletions
|
@ -116,31 +116,100 @@ describe SnippetsController do
|
|||
end
|
||||
end
|
||||
|
||||
describe 'GET #raw' do
|
||||
let(:user) { create(:user) }
|
||||
%w(raw download).each do |action|
|
||||
describe "GET #{action}" do
|
||||
context 'when the personal snippet is private' do
|
||||
let(:personal_snippet) { create(:personal_snippet, :private, author: user) }
|
||||
|
||||
context 'when the personal snippet is private' do
|
||||
let(:personal_snippet) { create(:personal_snippet, :private, author: user) }
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
context 'when signed in user is not the author' do
|
||||
let(:other_author) { create(:author) }
|
||||
let(:other_personal_snippet) { create(:personal_snippet, :private, author: other_author) }
|
||||
|
||||
context 'when signed in user is not the author' do
|
||||
let(:other_author) { create(:author) }
|
||||
let(:other_personal_snippet) { create(:personal_snippet, :private, author: other_author) }
|
||||
it 'responds with status 404' do
|
||||
get action, id: other_personal_snippet.to_param
|
||||
|
||||
it 'responds with status 404' do
|
||||
get :raw, id: other_personal_snippet.to_param
|
||||
expect(response).to have_http_status(404)
|
||||
end
|
||||
end
|
||||
|
||||
expect(response).to have_http_status(404)
|
||||
context 'when signed in user is the author' do
|
||||
before { get action, id: personal_snippet.to_param }
|
||||
|
||||
it 'responds with status 200' do
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
end
|
||||
|
||||
it 'has expected headers' do
|
||||
expect(response.header['Content-Type']).to eq('text/plain; charset=utf-8')
|
||||
|
||||
if action == :download
|
||||
expect(response.header['Content-Disposition']).to match(/attachment/)
|
||||
elsif action == :raw
|
||||
expect(response.header['Content-Disposition']).to match(/inline/)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when signed in user is the author' do
|
||||
it 'renders the raw snippet' do
|
||||
get :raw, id: personal_snippet.to_param
|
||||
context 'when not signed in' do
|
||||
it 'redirects to the sign in page' do
|
||||
get action, id: personal_snippet.to_param
|
||||
|
||||
expect(response).to redirect_to(new_user_session_path)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the personal snippet is internal' do
|
||||
let(:personal_snippet) { create(:personal_snippet, :internal, author: user) }
|
||||
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
it 'responds with status 200' do
|
||||
get action, id: personal_snippet.to_param
|
||||
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when not signed in' do
|
||||
it 'redirects to the sign in page' do
|
||||
get action, id: personal_snippet.to_param
|
||||
|
||||
expect(response).to redirect_to(new_user_session_path)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the personal snippet is public' do
|
||||
let(:personal_snippet) { create(:personal_snippet, :public, author: user) }
|
||||
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
it 'responds with status 200' do
|
||||
get action, id: personal_snippet.to_param
|
||||
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when not signed in' do
|
||||
it 'responds with status 200' do
|
||||
get action, id: personal_snippet.to_param
|
||||
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
|
@ -148,84 +217,25 @@ describe SnippetsController do
|
|||
end
|
||||
end
|
||||
|
||||
context 'when not signed in' do
|
||||
it 'redirects to the sign in page' do
|
||||
get :raw, id: personal_snippet.to_param
|
||||
context 'when the personal snippet does not exist' do
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
expect(response).to redirect_to(new_user_session_path)
|
||||
end
|
||||
end
|
||||
end
|
||||
it 'responds with status 404' do
|
||||
get action, id: 'doesntexist'
|
||||
|
||||
context 'when the personal snippet is internal' do
|
||||
let(:personal_snippet) { create(:personal_snippet, :internal, author: user) }
|
||||
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
expect(response).to have_http_status(404)
|
||||
end
|
||||
end
|
||||
|
||||
it 'renders the raw snippet' do
|
||||
get :raw, id: personal_snippet.to_param
|
||||
context 'when not signed in' do
|
||||
it 'responds with status 404' do
|
||||
get action, id: 'doesntexist'
|
||||
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when not signed in' do
|
||||
it 'redirects to the sign in page' do
|
||||
get :raw, id: personal_snippet.to_param
|
||||
|
||||
expect(response).to redirect_to(new_user_session_path)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the personal snippet is public' do
|
||||
let(:personal_snippet) { create(:personal_snippet, :public, author: user) }
|
||||
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
it 'renders the raw snippet' do
|
||||
get :raw, id: personal_snippet.to_param
|
||||
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when not signed in' do
|
||||
it 'renders the raw snippet' do
|
||||
get :raw, id: personal_snippet.to_param
|
||||
|
||||
expect(assigns(:snippet)).to eq(personal_snippet)
|
||||
expect(response).to have_http_status(200)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the personal snippet does not exist' do
|
||||
context 'when signed in' do
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
it 'responds with status 404' do
|
||||
get :raw, id: 'doesntexist'
|
||||
|
||||
expect(response).to have_http_status(404)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when not signed in' do
|
||||
it 'responds with status 404' do
|
||||
get :raw, id: 'doesntexist'
|
||||
|
||||
expect(response).to have_http_status(404)
|
||||
expect(response).to have_http_status(404)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue