kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Do not expose internal artifacts hash in build entity

Browse source
This commit is contained in:
Grzegorz Bizon 2017-06-13 11:05:48 +02:00
parent 6f5a68f528
commit b3a1961a43
2 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/serializers/build_details_entity.rb
View file

@ -1,18 +1,15 @@
class BuildDetailsEntity < BuildEntity class BuildDetailsEntity < BuildEntity
expose :coverage, :erased_at, :duration expose :coverage, :erased_at, :duration
expose :tag_list, as: :tags expose :tag_list, as: :tags
expose :user, using: UserEntity expose :user, using: UserEntity
expose :runner, using: RunnerEntity
expose :pipeline, using: PipelineEntity
expose :erased_by, if: -> (*) { build.erased? }, using: UserEntity expose :erased_by, if: -> (*) { build.erased? }, using: UserEntity
expose :erase_path, if: -> (*) { build.erasable? && can?(current_user, :update_build, project) } do |build| expose :erase_path, if: -> (*) { build.erasable? && can?(current_user, :update_build, project) } do |build|
erase_namespace_project_job_path(project.namespace, project, build) erase_namespace_project_job_path(project.namespace, project, build)
end end
expose :artifacts, using: BuildArtifactEntity
expose :runner, using: RunnerEntity
expose :pipeline, using: PipelineEntity
expose :merge_request, if: -> (*) { can?(current_user, :read_merge_request, build.merge_request) } do expose :merge_request, if: -> (*) { can?(current_user, :read_merge_request, build.merge_request) } do
expose :iid do |build| expose :iid do |build|
build.merge_request.iid build.merge_request.iid

2
spec/serializers/build_details_entity_spec.rb
View file

@ -29,7 +29,7 @@ describe BuildDetailsEntity do
it 'contains the needed key value pairs' do it 'contains the needed key value pairs' do
expect(subject).to include(:coverage, :erased_at, :duration) expect(subject).to include(:coverage, :erased_at, :duration)
expect(subject).to include(:artifacts, :runner, :pipeline) expect(subject).to include(:runner, :pipeline)
expect(subject).to include(:raw_path, :merge_request) expect(subject).to include(:raw_path, :merge_request)
expect(subject).to include(:new_issue_path) expect(subject).to include(:new_issue_path)
end end