kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Changed validation error message on wrong milestone dates

Browse source
This commit is contained in:
Xurxo Méndez Pérez 2017-11-18 19:22:11 +01:00
parent 6675bab599
commit b3a5abe4ae
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/milestone.rb
View file

@ -256,7 +256,7 @@ class Milestone < ActiveRecord::Base
def start_date_should_be_less_than_due_date def start_date_should_be_less_than_due_date
if due_date <= start_date if due_date <= start_date
errors.add(:start_date, "Can't be greater than due date") errors.add(:due_date, "must be greater than start date")
end end
end end

5
changelogs/unreleased/38393-Milestone-duration-error-message-is-not-accurate-enough.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Changed validation error message on wrong milestone dates
merge_request:
author: Xurxo Méndez Pérez
type: fixed

2
spec/models/milestone_spec.rb
View file

@ -11,7 +11,7 @@ describe Milestone do
milestone = build(:milestone, start_date: Date.tomorrow, due_date: Date.yesterday) milestone = build(:milestone, start_date: Date.tomorrow, due_date: Date.yesterday)
expect(milestone).not_to be_valid expect(milestone).not_to be_valid
expect(milestone.errors[:start_date]).to include("Can't be greater than due date") expect(milestone.errors[:due_date]).to include("must be greater than start date")
end end
end end
end end