diff --git a/GITLAB_WORKHORSE_VERSION b/GITLAB_WORKHORSE_VERSION index a35ebc6eaa7..13afb01d493 100644 --- a/GITLAB_WORKHORSE_VERSION +++ b/GITLAB_WORKHORSE_VERSION @@ -1 +1 @@ -8.34.0 +8.35.0 diff --git a/app/assets/javascripts/boards/components/board_content.vue b/app/assets/javascripts/boards/components/board_content.vue new file mode 100644 index 00000000000..9c3a88845f6 --- /dev/null +++ b/app/assets/javascripts/boards/components/board_content.vue @@ -0,0 +1,70 @@ + + + diff --git a/app/assets/javascripts/boards/index.js b/app/assets/javascripts/boards/index.js index 49ccabe54fd..a882cd1cdfa 100644 --- a/app/assets/javascripts/boards/index.js +++ b/app/assets/javascripts/boards/index.js @@ -1,8 +1,10 @@ import $ from 'jquery'; import Vue from 'vue'; +import { mapActions } from 'vuex'; import 'ee_else_ce/boards/models/issue'; import 'ee_else_ce/boards/models/list'; +import BoardContent from '~/boards/components/board_content.vue'; import BoardSidebar from 'ee_else_ce/boards/components/board_sidebar'; import initNewListDropdown from 'ee_else_ce/boards/components/new_list_dropdown'; import boardConfigToggle from 'ee_else_ce/boards/config_toggle'; @@ -77,6 +79,7 @@ export default () => { issueBoardsApp = new Vue({ el: $boardApp, components: { + BoardContent, Board: () => window?.gon?.features?.sfcIssueBoards ? import('ee_else_ce/boards/components/board_column.vue') @@ -115,14 +118,16 @@ export default () => { }, }, created() { - boardsStore.setEndpoints({ + const endpoints = { boardsEndpoint: this.boardsEndpoint, recentBoardsEndpoint: this.recentBoardsEndpoint, listsEndpoint: this.listsEndpoint, bulkUpdatePath: this.bulkUpdatePath, boardId: this.boardId, fullPath: $boardApp.dataset.fullPath, - }); + }; + this.setEndpoints(endpoints); + boardsStore.setEndpoints(endpoints); boardsStore.rootPath = this.boardsEndpoint; eventHub.$on('updateTokens', this.updateTokens); @@ -193,6 +198,7 @@ export default () => { } }, methods: { + ...mapActions(['setEndpoints']), updateTokens() { this.filterManager.updateTokens(); }, diff --git a/app/assets/javascripts/boards/stores/actions.js b/app/assets/javascripts/boards/stores/actions.js index 34598d66f45..08fedb14dff 100644 --- a/app/assets/javascripts/boards/stores/actions.js +++ b/app/assets/javascripts/boards/stores/actions.js @@ -1,11 +1,13 @@ +import * as types from './mutation_types'; + const notImplemented = () => { /* eslint-disable-next-line @gitlab/require-i18n-strings */ throw new Error('Not implemented!'); }; export default { - setEndpoints: () => { - notImplemented(); + setEndpoints: ({ commit }, endpoints) => { + commit(types.SET_ENDPOINTS, endpoints); }, fetchLists: () => { diff --git a/app/assets/javascripts/boards/stores/mutations.js b/app/assets/javascripts/boards/stores/mutations.js index 7a287400265..e4459cdcc07 100644 --- a/app/assets/javascripts/boards/stores/mutations.js +++ b/app/assets/javascripts/boards/stores/mutations.js @@ -6,8 +6,8 @@ const notImplemented = () => { }; export default { - [mutationTypes.SET_ENDPOINTS]: () => { - notImplemented(); + [mutationTypes.SET_ENDPOINTS]: (state, endpoints) => { + state.endpoints = endpoints; }, [mutationTypes.REQUEST_ADD_LIST]: () => { diff --git a/app/assets/javascripts/boards/stores/state.js b/app/assets/javascripts/boards/stores/state.js index 10aac2f649e..aca93c4d7c6 100644 --- a/app/assets/javascripts/boards/stores/state.js +++ b/app/assets/javascripts/boards/stores/state.js @@ -1,6 +1,7 @@ import { inactiveListId } from '~/boards/constants'; export default () => ({ + endpoints: {}, isShowingLabels: true, activeListId: inactiveListId, }); diff --git a/app/assets/javascripts/error_tracking/components/error_details.vue b/app/assets/javascripts/error_tracking/components/error_details.vue index 7e3b5210085..f77e1f0d539 100644 --- a/app/assets/javascripts/error_tracking/components/error_details.vue +++ b/app/assets/javascripts/error_tracking/components/error_details.vue @@ -233,8 +233,8 @@ export default { Tracking.event(category, action); }, trackStatusUpdate(status) { - const { category, action, label } = trackErrorStatusUpdateOptions; - Tracking.event(category, action, { label, property: status }); + const { category, action } = trackErrorStatusUpdateOptions(status); + Tracking.event(category, action); }, }, }; diff --git a/app/assets/javascripts/error_tracking/components/error_tracking_list.vue b/app/assets/javascripts/error_tracking/components/error_tracking_list.vue index 111b5ad60a5..62a73e21096 100644 --- a/app/assets/javascripts/error_tracking/components/error_tracking_list.vue +++ b/app/assets/javascripts/error_tracking/components/error_tracking_list.vue @@ -218,8 +218,8 @@ export default { Tracking.event(category, action); }, trackStatusUpdate(status) { - const { category, action, label } = trackErrorStatusUpdateOptions; - Tracking.event(category, action, { label, property: status }); + const { category, action } = trackErrorStatusUpdateOptions(status); + Tracking.event(category, action); }, }, }; diff --git a/app/assets/javascripts/error_tracking/utils.js b/app/assets/javascripts/error_tracking/utils.js index e519b8ebfe5..5b705cc5510 100644 --- a/app/assets/javascripts/error_tracking/utils.js +++ b/app/assets/javascripts/error_tracking/utils.js @@ -30,8 +30,7 @@ export const trackErrorDetailsViewsOptions = { /** * Tracks snowplow event when error status is updated */ -export const trackErrorStatusUpdateOptions = { +export const trackErrorStatusUpdateOptions = status => ({ category: 'Error Tracking', - action: 'update_error_status', - label: 'Status', -}; + action: `update_${status}_status`, +}); diff --git a/app/assets/javascripts/ide/components/branches/item.vue b/app/assets/javascripts/ide/components/branches/item.vue index 58a0631ee0d..e7f4cd796b5 100644 --- a/app/assets/javascripts/ide/components/branches/item.vue +++ b/app/assets/javascripts/ide/components/branches/item.vue @@ -2,7 +2,6 @@ /* eslint-disable @gitlab/vue-require-i18n-strings */ import Icon from '~/vue_shared/components/icon.vue'; import Timeago from '~/vue_shared/components/time_ago_tooltip.vue'; -import router from '../../ide_router'; export default { components: { @@ -26,7 +25,7 @@ export default { }, computed: { branchHref() { - return router.resolve(`/project/${this.projectId}/edit/${this.item.name}`).href; + return this.$router.resolve(`/project/${this.projectId}/edit/${this.item.name}`).href; }, }, }; diff --git a/app/assets/javascripts/ide/components/merge_requests/item.vue b/app/assets/javascripts/ide/components/merge_requests/item.vue index 60889c893cf..3f060392686 100644 --- a/app/assets/javascripts/ide/components/merge_requests/item.vue +++ b/app/assets/javascripts/ide/components/merge_requests/item.vue @@ -1,6 +1,5 @@