From b3ce1ce45218454cc3f8b719d7748f8a467f36a3 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 4 Jun 2020 09:08:01 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITLAB_WORKHORSE_VERSION | 2 +- .../boards/components/board_content.vue | 70 ++++ app/assets/javascripts/boards/index.js | 10 +- .../javascripts/boards/stores/actions.js | 6 +- .../javascripts/boards/stores/mutations.js | 4 +- app/assets/javascripts/boards/stores/state.js | 1 + .../components/error_details.vue | 4 +- .../components/error_tracking_list.vue | 4 +- .../javascripts/error_tracking/utils.js | 7 +- .../ide/components/branches/item.vue | 3 +- .../ide/components/merge_requests/item.vue | 3 +- .../javascripts/ide/components/repo_tabs.vue | 3 +- .../ide/stores/modules/router/actions.js | 6 + .../ide/stores/modules/router/index.js | 10 + .../stores/modules/router/mutation_types.js | 2 + .../ide/stores/modules/router/mutations.js | 7 + .../ide/stores/modules/router/state.js | 3 + .../javascripts/ide/sync_router_and_store.js | 55 ++++ .../monitoring/components/charts/column.vue | 13 +- .../monitoring/components/charts/options.js | 14 +- .../components/charts/time_series.vue | 24 +- .../components/dashboard_header.vue | 6 + .../monitoring/components/dashboard_panel.vue | 5 + .../monitoring/monitoring_bundle.js | 2 + .../javascripts/monitoring/stores/state.js | 2 + .../javascripts/snippets/components/edit.vue | 5 +- .../components/mr_widget_terraform_plan.vue | 17 +- app/controllers/groups/boards_controller.rb | 1 + app/helpers/projects_helper.rb | 4 +- app/views/projects/cleanup/_show.html.haml | 4 +- app/views/shared/boards/_show.html.haml | 29 +- .../217680-health-metric-instrumentation.yml | 5 + .../unreleased/219210-column-date-format.yml | 5 + changelogs/unreleased/reduce-repo-size.yml | 5 + .../update-workhorse-version-master.yml | 5 + .../20200429023324_add_composer_metadata.rb | 12 + ...0200528054112_add_index_to_package_name.rb | 19 ++ db/structure.sql | 15 + doc/ci/environments/index.md | 6 + doc/push_rules/push_rules.md | 4 +- doc/topics/git/lfs/index.md | 2 +- .../repository/img/repository_cleanup.png | Bin 8114 -> 0 bytes .../reducing_the_repo_size_using_git.md | 308 ++++++++++++------ lib/extracts_path.rb | 124 +------ lib/extracts_ref.rb | 128 ++++++++ spec/frontend/boards/stores/actions_spec.js | 17 +- spec/frontend/boards/stores/mutations_spec.js | 147 +++++---- .../components/error_details_spec.js | 14 +- .../components/error_tracking_list_spec.js | 7 +- .../ide/components/branches/item_spec.js | 1 + .../components/merge_requests/item_spec.js | 94 +++--- .../ide/stores/modules/router/actions_spec.js | 19 ++ .../stores/modules/router/mutations_spec.js | 23 ++ .../ide/sync_router_and_store_spec.js | 158 +++++++++ .../components/charts/column_spec.js | 52 ++- .../components/dashboard_panel_spec.js | 28 ++ .../monitoring/components/dashboard_spec.js | 54 ++- .../frontend/snippets/components/edit_spec.js | 46 +++ .../mr_widget_terraform_plan_spec.js | 6 +- spec/helpers/projects_helper_spec.rb | 12 +- spec/lib/extracts_path_spec.rb | 126 +------ spec/lib/extracts_ref_spec.rb | 23 ++ .../path_extraction_shared_examples.rb | 118 +++++++ 63 files changed, 1370 insertions(+), 539 deletions(-) create mode 100644 app/assets/javascripts/boards/components/board_content.vue create mode 100644 app/assets/javascripts/ide/stores/modules/router/actions.js create mode 100644 app/assets/javascripts/ide/stores/modules/router/index.js create mode 100644 app/assets/javascripts/ide/stores/modules/router/mutation_types.js create mode 100644 app/assets/javascripts/ide/stores/modules/router/mutations.js create mode 100644 app/assets/javascripts/ide/stores/modules/router/state.js create mode 100644 app/assets/javascripts/ide/sync_router_and_store.js create mode 100644 changelogs/unreleased/217680-health-metric-instrumentation.yml create mode 100644 changelogs/unreleased/219210-column-date-format.yml create mode 100644 changelogs/unreleased/reduce-repo-size.yml create mode 100644 changelogs/unreleased/update-workhorse-version-master.yml create mode 100644 db/migrate/20200429023324_add_composer_metadata.rb create mode 100644 db/migrate/20200528054112_add_index_to_package_name.rb delete mode 100644 doc/user/project/repository/img/repository_cleanup.png create mode 100644 lib/extracts_ref.rb create mode 100644 spec/frontend/ide/stores/modules/router/actions_spec.js create mode 100644 spec/frontend/ide/stores/modules/router/mutations_spec.js create mode 100644 spec/frontend/ide/sync_router_and_store_spec.js create mode 100644 spec/lib/extracts_ref_spec.rb create mode 100644 spec/support/shared_examples/path_extraction_shared_examples.rb diff --git a/GITLAB_WORKHORSE_VERSION b/GITLAB_WORKHORSE_VERSION index a35ebc6eaa7..13afb01d493 100644 --- a/GITLAB_WORKHORSE_VERSION +++ b/GITLAB_WORKHORSE_VERSION @@ -1 +1 @@ -8.34.0 +8.35.0 diff --git a/app/assets/javascripts/boards/components/board_content.vue b/app/assets/javascripts/boards/components/board_content.vue new file mode 100644 index 00000000000..9c3a88845f6 --- /dev/null +++ b/app/assets/javascripts/boards/components/board_content.vue @@ -0,0 +1,70 @@ + + + diff --git a/app/assets/javascripts/boards/index.js b/app/assets/javascripts/boards/index.js index 49ccabe54fd..a882cd1cdfa 100644 --- a/app/assets/javascripts/boards/index.js +++ b/app/assets/javascripts/boards/index.js @@ -1,8 +1,10 @@ import $ from 'jquery'; import Vue from 'vue'; +import { mapActions } from 'vuex'; import 'ee_else_ce/boards/models/issue'; import 'ee_else_ce/boards/models/list'; +import BoardContent from '~/boards/components/board_content.vue'; import BoardSidebar from 'ee_else_ce/boards/components/board_sidebar'; import initNewListDropdown from 'ee_else_ce/boards/components/new_list_dropdown'; import boardConfigToggle from 'ee_else_ce/boards/config_toggle'; @@ -77,6 +79,7 @@ export default () => { issueBoardsApp = new Vue({ el: $boardApp, components: { + BoardContent, Board: () => window?.gon?.features?.sfcIssueBoards ? import('ee_else_ce/boards/components/board_column.vue') @@ -115,14 +118,16 @@ export default () => { }, }, created() { - boardsStore.setEndpoints({ + const endpoints = { boardsEndpoint: this.boardsEndpoint, recentBoardsEndpoint: this.recentBoardsEndpoint, listsEndpoint: this.listsEndpoint, bulkUpdatePath: this.bulkUpdatePath, boardId: this.boardId, fullPath: $boardApp.dataset.fullPath, - }); + }; + this.setEndpoints(endpoints); + boardsStore.setEndpoints(endpoints); boardsStore.rootPath = this.boardsEndpoint; eventHub.$on('updateTokens', this.updateTokens); @@ -193,6 +198,7 @@ export default () => { } }, methods: { + ...mapActions(['setEndpoints']), updateTokens() { this.filterManager.updateTokens(); }, diff --git a/app/assets/javascripts/boards/stores/actions.js b/app/assets/javascripts/boards/stores/actions.js index 34598d66f45..08fedb14dff 100644 --- a/app/assets/javascripts/boards/stores/actions.js +++ b/app/assets/javascripts/boards/stores/actions.js @@ -1,11 +1,13 @@ +import * as types from './mutation_types'; + const notImplemented = () => { /* eslint-disable-next-line @gitlab/require-i18n-strings */ throw new Error('Not implemented!'); }; export default { - setEndpoints: () => { - notImplemented(); + setEndpoints: ({ commit }, endpoints) => { + commit(types.SET_ENDPOINTS, endpoints); }, fetchLists: () => { diff --git a/app/assets/javascripts/boards/stores/mutations.js b/app/assets/javascripts/boards/stores/mutations.js index 7a287400265..e4459cdcc07 100644 --- a/app/assets/javascripts/boards/stores/mutations.js +++ b/app/assets/javascripts/boards/stores/mutations.js @@ -6,8 +6,8 @@ const notImplemented = () => { }; export default { - [mutationTypes.SET_ENDPOINTS]: () => { - notImplemented(); + [mutationTypes.SET_ENDPOINTS]: (state, endpoints) => { + state.endpoints = endpoints; }, [mutationTypes.REQUEST_ADD_LIST]: () => { diff --git a/app/assets/javascripts/boards/stores/state.js b/app/assets/javascripts/boards/stores/state.js index 10aac2f649e..aca93c4d7c6 100644 --- a/app/assets/javascripts/boards/stores/state.js +++ b/app/assets/javascripts/boards/stores/state.js @@ -1,6 +1,7 @@ import { inactiveListId } from '~/boards/constants'; export default () => ({ + endpoints: {}, isShowingLabels: true, activeListId: inactiveListId, }); diff --git a/app/assets/javascripts/error_tracking/components/error_details.vue b/app/assets/javascripts/error_tracking/components/error_details.vue index 7e3b5210085..f77e1f0d539 100644 --- a/app/assets/javascripts/error_tracking/components/error_details.vue +++ b/app/assets/javascripts/error_tracking/components/error_details.vue @@ -233,8 +233,8 @@ export default { Tracking.event(category, action); }, trackStatusUpdate(status) { - const { category, action, label } = trackErrorStatusUpdateOptions; - Tracking.event(category, action, { label, property: status }); + const { category, action } = trackErrorStatusUpdateOptions(status); + Tracking.event(category, action); }, }, }; diff --git a/app/assets/javascripts/error_tracking/components/error_tracking_list.vue b/app/assets/javascripts/error_tracking/components/error_tracking_list.vue index 111b5ad60a5..62a73e21096 100644 --- a/app/assets/javascripts/error_tracking/components/error_tracking_list.vue +++ b/app/assets/javascripts/error_tracking/components/error_tracking_list.vue @@ -218,8 +218,8 @@ export default { Tracking.event(category, action); }, trackStatusUpdate(status) { - const { category, action, label } = trackErrorStatusUpdateOptions; - Tracking.event(category, action, { label, property: status }); + const { category, action } = trackErrorStatusUpdateOptions(status); + Tracking.event(category, action); }, }, }; diff --git a/app/assets/javascripts/error_tracking/utils.js b/app/assets/javascripts/error_tracking/utils.js index e519b8ebfe5..5b705cc5510 100644 --- a/app/assets/javascripts/error_tracking/utils.js +++ b/app/assets/javascripts/error_tracking/utils.js @@ -30,8 +30,7 @@ export const trackErrorDetailsViewsOptions = { /** * Tracks snowplow event when error status is updated */ -export const trackErrorStatusUpdateOptions = { +export const trackErrorStatusUpdateOptions = status => ({ category: 'Error Tracking', - action: 'update_error_status', - label: 'Status', -}; + action: `update_${status}_status`, +}); diff --git a/app/assets/javascripts/ide/components/branches/item.vue b/app/assets/javascripts/ide/components/branches/item.vue index 58a0631ee0d..e7f4cd796b5 100644 --- a/app/assets/javascripts/ide/components/branches/item.vue +++ b/app/assets/javascripts/ide/components/branches/item.vue @@ -2,7 +2,6 @@ /* eslint-disable @gitlab/vue-require-i18n-strings */ import Icon from '~/vue_shared/components/icon.vue'; import Timeago from '~/vue_shared/components/time_ago_tooltip.vue'; -import router from '../../ide_router'; export default { components: { @@ -26,7 +25,7 @@ export default { }, computed: { branchHref() { - return router.resolve(`/project/${this.projectId}/edit/${this.item.name}`).href; + return this.$router.resolve(`/project/${this.projectId}/edit/${this.item.name}`).href; }, }, }; diff --git a/app/assets/javascripts/ide/components/merge_requests/item.vue b/app/assets/javascripts/ide/components/merge_requests/item.vue index 60889c893cf..3f060392686 100644 --- a/app/assets/javascripts/ide/components/merge_requests/item.vue +++ b/app/assets/javascripts/ide/components/merge_requests/item.vue @@ -1,6 +1,5 @@