kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix rubocop in spec/helpers/diff_helper_spec.rb

Browse source
This commit is contained in:
Valery Sizov 2017-06-01 12:07:06 +03:00
parent 22acd28908
commit b417fc0329
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
spec/helpers/diff_helper_spec.rb
View file

@ -130,10 +130,14 @@ describe DiffHelper do
end
describe '#parallel_diff_discussions' do
it 'does not put comments on nonewline lines' do
discussion = {'abc_3_3' => 'comment'}
let(:discussion) { { 'abc_3_3' => 'comment' } }
let(:diff_file) { double(line_code: 'abc_3_3') }
before do
helper.instance_variable_set(:@grouped_diff_discussions, discussion)
diff_file = double(line_code: 'abc_3_3')
end
it 'does not put comments on nonewline lines' do
left = Gitlab::Diff::Line.new('\\nonewline', 'old-nonewline', 3, 3, 3)
right = Gitlab::Diff::Line.new('\\nonewline', 'new-nonewline', 3, 3, 3)
@ -143,9 +147,6 @@ describe DiffHelper do
end
it 'puts comments on added lines' do
discussion = {'abc_3_3' => 'comment'}
helper.instance_variable_set(:@grouped_diff_discussions, discussion)
diff_file = double(line_code: 'abc_3_3')
left = Gitlab::Diff::Line.new('\\nonewline', 'old-nonewline', 3, 3, 3)
right = Gitlab::Diff::Line.new('new line', 'add', 3, 3, 3)