kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Miscellaneous cycle-analytics-related changes. 

1. Add indexes to `CreateMergeRequestsClosingIssues` columns.
2. Remove an extraneous `check_if_open` check that is redundant now.

It would've been better to rebase this in, but that's not possible
because more people are working on this branch.
This commit is contained in:
Timothy Andrew 2016-09-20 11:20:51 +05:30
parent d0e101e997
commit b43d3af782
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/issue.rb
View File

@ -210,11 +210,7 @@ class Issue < ActiveRecord::Base
note.all_references(current_user, extractor: ext)
end
if check_if_open
ext.merge_requests.select { |mr| mr.open? && mr.closes_issue?(self) }
else
ext.merge_requests.select { |mr| mr.closes_issue?(self) }
end
ext.merge_requests.select { |mr| mr.open? && mr.closes_issue?(self) }
end
def moved?

4
db/migrate/20160915042921_create_merge_requests_closing_issues.rb
View File

@ -25,8 +25,8 @@ class CreateMergeRequestsClosingIssues < ActiveRecord::Migration
def change
create_table :merge_requests_closing_issues do |t|
t.references :merge_request, foreign_key: true, null: false
t.references :issue, foreign_key: true, null: false
t.references :merge_request, foreign_key: true, index: true, null: false
t.references :issue, foreign_key: true, index: true, null: false
t.timestamps null: false
end