Return all variables after UPDATE

This commit is contained in:
Matija Čupić 2018-01-30 00:44:53 +01:00
parent 9eb3bb5cff
commit b48d8c8ad0
No known key found for this signature in database
GPG key ID: 4BAF84FFACD2E5DE
4 changed files with 36 additions and 2 deletions

View file

@ -16,7 +16,12 @@ module Groups
def update def update
respond_to do |format| respond_to do |format|
format.json do format.json do
return head :ok if @group.update(variables_params) if @group.update(variables_params)
variables = @group.variables
.map { |variable| variable.present(current_user: current_user) }
return render status: :ok, json: { variables: variables }
end
render status: :bad_request, json: @group.errors.full_messages render status: :bad_request, json: @group.errors.full_messages
end end

View file

@ -15,7 +15,12 @@ class Projects::VariablesController < Projects::ApplicationController
def update def update
respond_to do |format| respond_to do |format|
format.json do format.json do
return head :ok if @project.update(variables_params) if @project.update(variables_params)
variables = @project.variables
.map { |variable| variable.present(current_user: current_user) }
return render status: :ok, json: { variables: variables }
end
render status: :bad_request, json: @project.errors.full_messages render status: :bad_request, json: @project.errors.full_messages
end end

View file

@ -78,6 +78,12 @@ describe Groups::VariablesController do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
end end
it 'has all variables in response' do
subject
expect(response.body).to include(group.variables.reload.to_json)
end
end end
context 'with a deleted variable' do context 'with a deleted variable' do
@ -101,6 +107,12 @@ describe Groups::VariablesController do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
end end
it 'has all variables in response' do
subject
expect(response.body).to include(group.variables.reload.to_json)
end
end end
end end
end end

View file

@ -87,6 +87,12 @@ describe Projects::VariablesController do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
end end
it 'has all variables in response' do
subject
expect(response.body).to include(project.variables.reload.to_json)
end
end end
context 'with a deleted variable' do context 'with a deleted variable' do
@ -110,6 +116,12 @@ describe Projects::VariablesController do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
end end
it 'has all variables in response' do
subject
expect(response.body).to include(project.variables.reload.to_json)
end
end end
end end
end end