From fa8d70a989f548f55be44ae47fab0f6f68a480c8 Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Thu, 3 May 2018 14:28:41 +0100 Subject: [PATCH] fixed specs fixed review mode not being editable --- .../ide/components/commit_sidebar/success_message.vue | 8 +------- .../javascripts/ide/components/repo_commit_section.vue | 1 - app/assets/javascripts/ide/components/repo_editor.vue | 1 + app/assets/javascripts/ide/stores/getters.js | 1 + 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/ide/components/commit_sidebar/success_message.vue b/app/assets/javascripts/ide/components/commit_sidebar/success_message.vue index 628a17eddca..a6df91b79c2 100644 --- a/app/assets/javascripts/ide/components/commit_sidebar/success_message.vue +++ b/app/assets/javascripts/ide/components/commit_sidebar/success_message.vue @@ -2,14 +2,8 @@ import { mapState } from 'vuex'; export default { - props: { - committedStateSvgPath: { - type: String, - required: true, - }, - }, computed: { - ...mapState(['lastCommitMsg']), + ...mapState(['lastCommitMsg', 'committedStateSvgPath']), }, }; diff --git a/app/assets/javascripts/ide/components/repo_commit_section.vue b/app/assets/javascripts/ide/components/repo_commit_section.vue index 8dd21053eda..4c0dab70ab0 100644 --- a/app/assets/javascripts/ide/components/repo_commit_section.vue +++ b/app/assets/javascripts/ide/components/repo_commit_section.vue @@ -105,7 +105,6 @@ export default { > path => state.stagedFiles.find(f => f.path export const isEditModeActive = state => state.currentActivityView === activityBarViews.edit; export const isCommitModeActive = state => state.currentActivityView === activityBarViews.commit; +export const isReviewModeActive = state => state.currentActivityView === activityBarViews.review; // prevent babel-plugin-rewire from generating an invalid default during karma tests export default () => {};