diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml index 821e3398301..a2ba217dbcc 100644 --- a/.rubocop_todo/style/accessor_grouping.yml +++ b/.rubocop_todo/style/accessor_grouping.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Style/AccessorGrouping: - # Offense count: 254 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/finders/template_finder.rb' - 'app/models/commit.rb' @@ -23,7 +21,6 @@ Style/AccessorGrouping: - 'app/models/project.rb' - 'app/services/deployments/update_environment_service.rb' - 'app/services/issues/clone_service.rb' - - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - 'app/services/note_summary.rb' - 'app/services/notification_recipients/builder/default.rb' - 'app/services/task_list_toggle_service.rb' @@ -38,6 +35,7 @@ Style/AccessorGrouping: - 'ee/lib/gitlab/ci/reports/security/locations/dast.rb' - 'ee/lib/gitlab/ci/reports/security/locations/dependency_scanning.rb' - 'lib/feature/definition.rb' + - 'lib/gitlab/audit/type/definition.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/ci/config/external/context.rb' - 'lib/gitlab/ci/reports/security/finding.rb' @@ -65,7 +63,6 @@ Style/AccessorGrouping: - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/suggestions/file_suggestion.rb' - 'lib/gitlab/tracking/event_definition.rb' - - 'lib/gitlab/tree_summary.rb' - 'lib/gitlab/usage/metric_definition.rb' - 'lib/gitlab/usage/metrics/instrumentations/base_metric.rb' - 'lib/gitlab/usage/service_ping/instrumented_payload.rb' diff --git a/app/assets/javascripts/issues/list/constants.js b/app/assets/javascripts/issues/list/constants.js index 27738d7a3e6..75aa3bfcdca 100644 --- a/app/assets/javascripts/issues/list/constants.js +++ b/app/assets/javascripts/issues/list/constants.js @@ -327,10 +327,12 @@ export const filters = { [TOKEN_TYPE_HEALTH]: { [API_PARAM]: { [NORMAL_FILTER]: 'healthStatus', + [SPECIAL_FILTER]: 'healthStatus', }, [URL_PARAM]: { [OPERATOR_IS]: { [NORMAL_FILTER]: 'health_status', + [SPECIAL_FILTER]: 'health_status', }, }, }, diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue index a82f485bf44..040860c8c91 100644 --- a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue +++ b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue @@ -898,7 +898,9 @@ export default { :help-path="pagesHelpPath" :label="$options.i18n.pagesLabel" :help-text=" - s__('ProjectSettings|With GitLab Pages you can host your static websites on GitLab.') + s__( + 'ProjectSettings|With GitLab Pages you can host your static websites on GitLab. GitLab Pages uses a caching mechanism for efficiency. Your changes may not take effect until that cache is invalidated, which usually takes less than a minute.', + ) " >