Fix RequestStore-related test failure
The test was failing
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/101444126 because
a04056efad/ee/spec/support/request_store.rb
which is in EE only, clears the RequestStore before every test,
regardless of whether RequestStore is active. This test is unusual
because it sets up RequestStore without it being active, to make sure
that the tested code doesn’t attempt to use RequestStore. These two
unusual facts combined to cause the failure in EE only. The fix works
because of the particular order of RSpec hooks in the test lifecycle.
This commit is contained in:
parent
0920342094
commit
b720ea0613
1 changed files with 3 additions and 3 deletions
|
@ -219,11 +219,11 @@ describe Gitlab::SafeRequestStore do
|
|||
end
|
||||
|
||||
context 'when RequestStore is NOT active' do
|
||||
around do |example|
|
||||
before do
|
||||
RequestStore.write('foo', true)
|
||||
end
|
||||
|
||||
example.run
|
||||
|
||||
after do
|
||||
RequestStore.clear! # Clean up
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in a new issue