From b72218d98e11514569939cf475d3c626fed445d1 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 30 Mar 2022 00:09:03 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/global.gitlab-ci.yml | 1 + .gitlab/ci/rules.gitlab-ci.yml | 5 +- .../components/navigation_popover.vue | 4 +- .../clusters_list/components/agent_token.vue | 33 ++----- .../javascripts/clusters_list/constants.js | 23 ++--- .../javascripts/monitoring/stores/actions.js | 2 +- .../jira_connect/events_controller.rb | 4 - app/helpers/diff_helper.rb | 14 ++- app/models/bulk_imports/export_status.rb | 8 +- app/models/ci/namespace_mirror.rb | 2 + app/models/namespaces/traversal/linear.rb | 27 ++++++ app/models/programming_language.rb | 7 +- app/models/project.rb | 9 ++ app/models/project_setting.rb | 9 +- app/models/repository_language.rb | 4 +- app/models/user.rb | 20 ++++- app/services/git/branch_push_service.rb | 7 ++ .../apple_target_platform_detector_service.rb | 58 ++++++++++++ .../record_target_platforms_service.rb | 29 ++++++ app/views/projects/diffs/_line.html.haml | 2 + .../projects/diffs/_parallel_view.html.haml | 4 + app/views/projects/diffs/_text_file.html.haml | 2 + app/workers/all_queues.yml | 9 ++ .../record_target_platforms_worker.rb | 55 ++++++++++++ ...l => record_projects_target_platforms.yml} | 10 +-- config/sidekiq_queues.yml | 2 + ...el_to_namespace_root_storage_statistics.rb | 13 +++ ...add_target_platforms_to_project_setting.rb | 7 ++ db/schema_migrations/20220317170122 | 1 + db/schema_migrations/20220318120802 | 1 + db/structure.sql | 4 +- lib/gitlab/diff/line.rb | 17 ++-- lib/gitlab/diff/parallel_diff.rb | 2 +- .../diff/rendered/notebook/diff_file.rb | 9 +- locale/gitlab.pot | 29 +++--- .../jira_connect/events_controller_spec.rb | 11 --- .../projects/commits/multi_view_diff_spec.rb | 79 ++++++++++++++--- .../components/agent_token_spec.js | 8 +- spec/helpers/diff_helper_spec.rb | 47 ++++++++++ spec/lib/gitlab/diff/file_spec.rb | 6 ++ .../models/bulk_imports/export_status_spec.rb | 18 +++- spec/models/group_spec.rb | 88 +++++++++++++++++++ spec/models/programming_language_spec.rb | 18 ++++ spec/models/project_setting_spec.rb | 30 +++++++ spec/models/project_spec.rb | 50 +++++++++++ spec/models/user_spec.rb | 22 +++-- spec/requests/api/project_attributes.yml | 1 + spec/services/git/branch_push_service_spec.rb | 10 +++ ...e_target_platform_detector_service_spec.rb | 61 +++++++++++++ .../record_target_platforms_service_spec.rb | 66 ++++++++++++++ .../record_target_platforms_worker_spec.rb | 87 ++++++++++++++++++ 51 files changed, 903 insertions(+), 132 deletions(-) create mode 100644 app/services/projects/apple_target_platform_detector_service.rb create mode 100644 app/services/projects/record_target_platforms_service.rb create mode 100644 app/workers/projects/record_target_platforms_worker.rb rename config/feature_flags/development/{jira_connect_installation_update.yml => record_projects_target_platforms.yml} (61%) create mode 100644 db/migrate/20220317170122_add_notification_level_to_namespace_root_storage_statistics.rb create mode 100644 db/migrate/20220318120802_add_target_platforms_to_project_setting.rb create mode 100644 db/schema_migrations/20220317170122 create mode 100644 db/schema_migrations/20220318120802 create mode 100644 spec/services/projects/apple_target_platform_detector_service_spec.rb create mode 100644 spec/services/projects/record_target_platforms_service_spec.rb create mode 100644 spec/workers/projects/record_target_platforms_worker_spec.rb diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 146a7067acd..f1c62e01674 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -41,6 +41,7 @@ key: files: - GITALY_SERVER_VERSION + - lib/gitlab/setup_helper.rb prefix: "gitaly-binaries-${DEBIAN-VERSION}" paths: - tmp/tests/gitaly/_build/bin/ diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 8c30fb5447e..e808a0297a6 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -161,6 +161,7 @@ .gitaly-patterns: &gitaly-patterns - "GITALY_SERVER_VERSION" + - "lib/gitlab/setup_helper.rb" .workhorse-patterns: &workhorse-patterns - "GITLAB_WORKHORSE_VERSION" @@ -274,7 +275,9 @@ - "lib/gitlab/markdown_cache/active_record/**/*" - "config/prometheus/common_metrics.yml" # Used by Gitlab::DatabaseImporters::CommonMetrics::Importer - "{,ee/,jh/}app/models/project_statistics.rb" # Used to calculate sizes in migration specs - - "GITALY_SERVER_VERSION" # Has interactions with background migrations:https://gitlab.com/gitlab-org/gitlab/-/issues/336538 + # Gitaly has interactions with background migrations: https://gitlab.com/gitlab-org/gitlab/-/issues/336538 + - "GITALY_SERVER_VERSION" + - "lib/gitlab/setup_helper.rb" # CI changes - ".gitlab-ci.yml" - ".gitlab/ci/**/*" diff --git a/app/assets/javascripts/attention_requests/components/navigation_popover.vue b/app/assets/javascripts/attention_requests/components/navigation_popover.vue index 1542bc9a7e9..804eda8f321 100644 --- a/app/assets/javascripts/attention_requests/components/navigation_popover.vue +++ b/app/assets/javascripts/attention_requests/components/navigation_popover.vue @@ -82,7 +82,9 @@ export default { return 'bottom'; }, }, - docsPage: helpPagePath('development/code_review.html'), + docsPage: helpPagePath('user/project/merge_requests/index.md', { + anchor: 'request-attention-to-a-merge-request', + }), }; diff --git a/app/assets/javascripts/clusters_list/components/agent_token.vue b/app/assets/javascripts/clusters_list/components/agent_token.vue index eab3fc3ed63..951cf7926b4 100644 --- a/app/assets/javascripts/clusters_list/components/agent_token.vue +++ b/app/assets/javascripts/clusters_list/components/agent_token.vue @@ -8,9 +8,6 @@ import { I18N_AGENT_TOKEN } from '../constants'; export default { i18n: I18N_AGENT_TOKEN, - basicInstallPath: helpPagePath('user/clusters/agent/install/index', { - anchor: 'install-the-agent-into-the-cluster', - }), advancedInstallPath: helpPagePath('user/clusters/agent/install/index', { anchor: 'advanced-installation', }), @@ -43,27 +40,7 @@ export default {