kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Optimise includes

Browse source
This commit is contained in:
Kamil Trzcinski 2017-04-06 15:04:26 +02:00
parent 8a1c12aa6f
commit b828a98c1c
No known key found for this signature in database
GPG key ID: 4505F5C7E12C6A5A
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/serializers/pipeline_serializer.rb
View file

@ -13,7 +13,15 @@ class PipelineSerializer < BaseSerializer
def represent(resource, opts = {})
if resource.is_a?(ActiveRecord::Relation)
resource = resource.includes(project: :namespace)
resource = resource.includes(:project)
resource = resource.includes(:pending_builds,
:retryable_builds,
:cancelable_statuses,
:manual_actions,
:artifacts)
resource = resource.includes(pending_builds: :project)
resource = resource.includes(manual_actions: :project)
resource = resource.includes(artifacts: :project)
end
if paginated?

3
spec/serializers/pipeline_serializer_spec.rb
View file

@ -105,7 +105,8 @@ describe PipelineSerializer do
it "verifies number of queries" do
recorded = ActiveRecord::QueryRecorder.new { subject }
expect(recorded.count).to be_within(200).of(10)
expect(recorded.count).to be_within(10).of(230)
expect(recorded.cached_count).to be_within(5).of(5)
end
def create_pipeline(status)