From b8e272100415ae1a550a455f4ad091fccb692a1e Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 19 Nov 2020 00:09:41 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../New End To End Test.md | 26 ++++ .../groups/components/group_item.vue | 30 +++- app/assets/javascripts/groups/index.js | 3 +- .../javascripts/groups/store/groups_store.js | 5 +- app/assets/javascripts/groups/store/utils.js | 27 ++++ app/finders/ci/commit_statuses_finder.rb | 2 +- app/helpers/user_callouts_helper.rb | 5 +- app/views/groups/_home_panel.html.haml | 6 +- .../groups/_subgroups_and_projects.html.haml | 2 +- app/views/groups/show.html.haml | 1 + .../shared/_new_project_item_select.html.haml | 2 +- .../273751-fj-structured-data-for-groups.yml | 5 + .../unreleased/283825-split-button-gap-mr.yml | 5 + ...pen-registration-callout-on-gitlab-com.yml | 5 + doc/.vale/gitlab/SubstitutionSuggestions.yml | 1 + doc/.vale/gitlab/spelling-exceptions.txt | 4 +- doc/administration/instance_review.md | 4 +- .../gitlab_self_monitoring_project/index.md | 4 +- doc/administration/terraform_state.md | 2 +- doc/api/group_clusters.md | 6 +- doc/api/instance_clusters.md | 6 +- doc/api/invitations.md | 2 +- doc/api/project_clusters.md | 4 +- doc/ci/yaml/README.md | 130 +++++++----------- doc/development/experiment_guide/index.md | 10 +- doc/development/logging.md | 6 +- doc/development/product_analytics/snowplow.md | 2 +- .../product_analytics/usage_ping.md | 36 ++--- .../incident_management/alert_integrations.md | 2 +- doc/topics/autodevops/customize.md | 66 ++++----- doc/topics/autodevops/index.md | 12 +- doc/topics/autodevops/quick_start_guide.md | 28 ++-- doc/topics/autodevops/requirements.md | 12 +- doc/topics/autodevops/stages.md | 16 +-- doc/topics/autodevops/upgrading_postgresql.md | 14 +- doc/user/clusters/applications.md | 12 +- doc/user/clusters/cost_management.md | 2 +- doc/user/clusters/management_project.md | 8 +- doc/user/group/clusters/index.md | 6 +- doc/user/group/epics/index.md | 4 +- doc/user/project/clusters/add_eks_clusters.md | 29 ++-- doc/user/project/clusters/add_gke_clusters.md | 12 +- doc/user/project/clusters/runbooks/index.md | 8 +- doc/user/project/clusters/serverless/aws.md | 26 ++-- doc/user/project/clusters/serverless/index.md | 50 +++---- doc/user/project/issue_board.md | 86 +++++++----- lib/microsoft_teams/notifier.rb | 11 +- spec/features/groups/show_spec.rb | 65 +++++++++ .../finders/ci/commit_statuses_finder_spec.rb | 8 +- spec/frontend/groups/components/app_spec.js | 2 +- .../groups/components/group_item_spec.js | 49 +++++++ .../groups/store/groups_store_spec.js | 27 ++-- spec/frontend/groups/store/utils_spec.js | 44 ++++++ spec/helpers/user_callouts_helper_spec.rb | 17 ++- spec/lib/microsoft_teams/notifier_spec.rb | 4 +- .../projects/tags/index.html.haml_spec.rb | 9 ++ 56 files changed, 619 insertions(+), 351 deletions(-) create mode 100644 .gitlab/merge_request_templates/New End To End Test.md create mode 100644 app/assets/javascripts/groups/store/utils.js create mode 100644 changelogs/unreleased/273751-fj-structured-data-for-groups.yml create mode 100644 changelogs/unreleased/283825-split-button-gap-mr.yml create mode 100644 changelogs/unreleased/hide-open-registration-callout-on-gitlab-com.yml create mode 100644 spec/frontend/groups/store/utils_spec.js diff --git a/.gitlab/merge_request_templates/New End To End Test.md b/.gitlab/merge_request_templates/New End To End Test.md new file mode 100644 index 00000000000..9bd7f11d4a5 --- /dev/null +++ b/.gitlab/merge_request_templates/New End To End Test.md @@ -0,0 +1,26 @@ +## Description of the test + + + +### Check-list + +- [ ] Confirm the test has a [`testcase:` tag linking to an existing test case](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/best_practices.html#link-a-test-to-its-test-case-issue) in the test case project. +- [ ] Note if the test is intended to run in specific scenarios. If a scenario is new, add a link to the MR that adds the new scenario. +- [ ] Follow the end-to-end tests [style guide](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/style_guide.html) and [best practices](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/best_practices.html). +- [ ] Use the appropriate [RSpec metadata tag(s)](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/rspec_metadata_tests.html#rspec-metadata-for-end-to-end-tests). +- [ ] Ensure that a created resource is removed after test execution. +- [ ] Verify the tags to ensure it runs on the desired test environments. +- [ ] If this MR has a dependency on another MR, such as a GitLab QA MR, specify the order in which the MRs should be merged. +- [ ] (If applicable) Create a follow-up issue to document [the special setup](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/running_tests_that_require_special_setup.html) necessary to run the test: ISSUE_LINK + + +/label ~"Quality" ~"QA" ~test + + + +/label ~"Quality:test-gap" ~"Quality:EE test gaps" + + +/label ~"feature::addition" ~"feature::maintenance" diff --git a/app/assets/javascripts/groups/components/group_item.vue b/app/assets/javascripts/groups/components/group_item.vue index 6e99b6ad4fa..ef58b93c049 100644 --- a/app/assets/javascripts/groups/components/group_item.vue +++ b/app/assets/javascripts/groups/components/group_item.vue @@ -74,6 +74,9 @@ export default { visibilityTooltip() { return GROUP_VISIBILITY_TYPE[this.group.visibility]; }, + microdata() { + return this.group.microdata || {}; + }, }, mounted() { if (this.group.name === 'Learn GitLab') { @@ -99,7 +102,15 @@ export default {