wall comment does not create an event on dashboard any more
This commit is contained in:
parent
b1bd3f1252
commit
ba4f0abf47
2 changed files with 7 additions and 5 deletions
|
@ -1,8 +1,7 @@
|
|||
module NotesHelper
|
||||
# Helps to distinguish e.g. commit notes in mr notes list
|
||||
def note_for_main_target?(note)
|
||||
note.for_wall? ||
|
||||
(@target_type.camelize == note.noteable_type && !note.for_diff_line?)
|
||||
(@target_type.camelize == note.noteable_type && !note.for_diff_line?)
|
||||
end
|
||||
|
||||
def note_target_fields
|
||||
|
|
|
@ -4,9 +4,12 @@ class ActivityObserver < ActiveRecord::Observer
|
|||
def after_create(record)
|
||||
event_author_id = record.author_id
|
||||
|
||||
# Skip status notes
|
||||
if record.kind_of?(Note) && record.note.include?("_Status changed to ")
|
||||
return true
|
||||
if record.kind_of?(Note)
|
||||
# Skip system status notes like 'status changed to close'
|
||||
return true if record.note.include?("_Status changed to ")
|
||||
|
||||
# Skip wall notes to prevent spaming of dashboard
|
||||
return true if record.noteable_type.blank?
|
||||
end
|
||||
|
||||
if event_author_id
|
||||
|
|
Loading…
Reference in a new issue