add simple logging to UpdateMergeRequestsWorker#perform

this is to try to debug #35914
This commit is contained in:
micael.bergeron 2017-11-13 14:56:08 -05:00
parent 9200b50012
commit bae6385bda
2 changed files with 18 additions and 1 deletions

View File

@ -9,6 +9,17 @@ class UpdateMergeRequestsWorker
user = User.find_by(id: user_id)
return unless user
MergeRequests::RefreshService.new(project, user).execute(oldrev, newrev, ref)
# TODO: remove this benchmarking when we have rich logging
time = Benchmark.measure do
MergeRequests::RefreshService.new(project, user).execute(oldrev, newrev, ref)
end
log_args = ["elapsed=#{time.real}"]
method(__method__).parameters.map do |_, p|
pname = p.to_s
log_args << [pname, binding.local_variable_get(pname)].join('=')
end
Rails.logger.info("UpdateMergeRequestsWorker#perform #{log_args.join(',')}")
end
end

View File

@ -23,5 +23,11 @@ describe UpdateMergeRequestsWorker do
perform
end
it 'logs performance' do
expect(Rails.logger).to receive(:info).with(a_string_matching(/\AUpdateMergeRequestsWorker#perform.*project_id=#{project.id},user_id=#{user.id},oldrev=#{oldrev},newrev=#{newrev},ref=#{ref}/))
perform
end
end
end