Merge branch 'fix-header-logo-link' into 'master'
Fix the logo in header not being an anchor link. ## What does this MR do? Adds an actual link to the Tanuki in the header instead of a `Turbolinks.visit()`. ## Are there points in the code the reviewer needs to double check? Do we care that this reverts the Safari issue fixed in !2690? I feel bad, but it's hacky and there's not a great way to fix it here. ## Why was this MR needed? You couldn't open the home page in a new tab before, it was very annoying. ## What are the relevant issue numbers? Fixes #18604 cc: @rspeicher See merge request !4661
This commit is contained in:
commit
bb7af46d32
2 changed files with 1 additions and 7 deletions
|
@ -42,9 +42,3 @@ work = ->
|
|||
|
||||
$(document).on('page:fetch', start)
|
||||
$(document).on('page:change', stop)
|
||||
|
||||
$ ->
|
||||
# Make logo clickable as part of a workaround for Safari visited
|
||||
# link behaviour (See !2690).
|
||||
$('#logo').on 'click', ->
|
||||
Turbolinks.visit('/')
|
||||
|
|
|
@ -50,7 +50,7 @@
|
|||
%h1.title= title
|
||||
|
||||
.header-logo
|
||||
#logo
|
||||
= link_to root_path, class: 'home', title: 'Dashboard', id: 'logo' do
|
||||
= brand_header_logo
|
||||
|
||||
= yield :header_content
|
||||
|
|
Loading…
Reference in a new issue