From bbd945a9eaeaf8ff084fcd5f697902fe9f67ccdb Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 27 Jun 2022 12:09:11 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../issue_templates/Feature Flag Roll Out.md | 6 +- .rubocop_todo/layout/line_length.yml | 1 - .../add_context_commits_modal_trigger.vue | 2 +- .../diffs/components/diff_line_note_form.vue | 2 +- .../javascripts/mr_notes/stores/index.js | 14 +- .../color_select_dropdown/color_item.vue | 6 +- .../color_select_root.vue | 19 +- .../color_select_dropdown/constants.js | 4 +- .../dropdown_contents.vue | 17 +- .../dropdown_contents_color_view.vue | 4 +- .../color_select_dropdown/dropdown_value.vue | 22 +- .../stylesheets/_page_specific_files.scss | 5 +- .../stylesheets/highlight/themes/dark.scss | 12 +- .../stylesheets/highlight/themes/monokai.scss | 12 +- .../stylesheets/highlight/themes/none.scss | 8 +- .../highlight/themes/solarized-dark.scss | 14 +- .../highlight/themes/solarized-light.scss | 12 +- .../stylesheets/highlight/white_base.scss | 18 +- app/assets/stylesheets/pages/colors.scss | 24 ++ .../_performance_bar.html.haml | 2 +- ..._request_squash_options_settings.html.haml | 2 +- .../gitlab_rails_cheat_sheet.md | 3 + .../project/integrations/webhook_events.md | 19 +- lib/gitlab/data_builder/pipeline.rb | 1 + locale/gitlab.pot | 9 + package.json | 4 +- .../__helpers__/init_vue_mr_page_helper.js | 4 +- .../collapsed_files_warning_spec.js | 4 +- .../diffs/components/diff_content_spec.js | 6 +- .../components/diff_expansion_cell_spec.js | 177 +++++----- .../diffs/components/diff_file_spec.js | 4 +- .../components/diff_line_note_form_spec.js | 301 +++++++++--------- .../diffs/components/diff_row_spec.js | 3 +- .../diffs/components/diff_stats_spec.js | 3 +- spec/frontend/diffs/mock_data/diff_file.js | 4 +- spec/frontend/diffs/store/actions_spec.js | 4 +- spec/frontend/diffs/store/mutations_spec.js | 5 +- spec/frontend/diffs/store/utils_spec.js | 6 +- spec/frontend/diffs/utils/diff_file_spec.js | 6 +- .../components/noteable_discussion_spec.js | 6 +- .../dropdown_value_spec.js | 2 +- spec/lib/gitlab/data_builder/pipeline_spec.rb | 11 + yarn.lock | 18 +- 43 files changed, 476 insertions(+), 330 deletions(-) create mode 100644 app/assets/stylesheets/pages/colors.scss diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md index 1b3d82cf522..f3830a5cc10 100644 --- a/.gitlab/issue_templates/Feature Flag Roll Out.md +++ b/.gitlab/issue_templates/Feature Flag Roll Out.md @@ -62,7 +62,7 @@ _Consider adding links to check for Sentry errors, Production logs for 5xx, 302s - Ensure that the feature MRs have been deployed to non-production environments. - [ ] `/chatops run auto_deploy status ` - [ ] Enable the feature globally on non-production environments. - - [ ] `/chatops run feature set true --dev --staging` + - [ ] `/chatops run feature set true --dev --staging --staging-ref` - [ ] Verify that the feature works as expected. Posting the QA result in this issue is preferable. The best environment to validate the feature in is [staging-canary](https://about.gitlab.com/handbook/engineering/infrastructure/environments/#staging-canary) as this is the first environment deployed to. Note you will need to make sure you are configured to use canary as outlined [here](https://about.gitlab.com/handbook/engineering/infrastructure/environments/canary-stage/) @@ -120,7 +120,7 @@ To do so, follow these steps: the feature can be officially announced in a release blog post. - [ ] `/chatops run release check ` - [ ] Consider cleaning up the feature flag from all environments by running these chatops command in `#production` channel. Otherwise these settings may override the default enabled. - - [ ] `/chatops run feature delete --dev --staging --production` + - [ ] `/chatops run feature delete --dev --staging --staging-ref --production` - [ ] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone. - [ ] Set the next milestone to this rollout issue for scheduling [the flag removal](#release-the-feature). - [ ] (Optional) You can [create a separate issue](https://gitlab.com/gitlab-org/gitlab/-/issues/new?issuable_template=Feature%20Flag%20Cleanup) for scheduling the steps below to [Release the feature](#release-the-feature). @@ -156,7 +156,7 @@ You can either [create a follow-up issue for Feature Flag Cleanup](https://gitla - [ ] `/chatops run release check ` - [ ] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone. - [ ] If not already done, clean up the feature flag from all environments by running these chatops command in `#production` channel: - - [ ] `/chatops run feature delete --dev --staging --production` + - [ ] `/chatops run feature delete --dev --staging --staging-ref --production` - [ ] Close this rollout issue. ## Rollback Steps diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 98db0d8fa9b..6aed65b586e 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -2825,7 +2825,6 @@ Layout/LineLength: - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' - 'ee/spec/services/ee/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'ee/spec/services/ee/commits/create_service_spec.rb' - 'ee/spec/services/ee/git/wiki_push_service_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' diff --git a/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_trigger.vue b/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_trigger.vue index 2287872e8c1..a58b6e62254 100644 --- a/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_trigger.vue +++ b/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_trigger.vue @@ -41,7 +41,7 @@ export default { 'gl-mt-5': !commitsEmpty && contextCommitsEmpty, }, ]" - :variant="commitsEmpty ? 'info' : 'default'" + :variant="commitsEmpty ? 'confirm' : 'default'" @click="openModal" > {{ buttonText }} diff --git a/app/assets/javascripts/diffs/components/diff_line_note_form.vue b/app/assets/javascripts/diffs/components/diff_line_note_form.vue index ebc68bafb9a..467a0f8d2db 100644 --- a/app/assets/javascripts/diffs/components/diff_line_note_form.vue +++ b/app/assets/javascripts/diffs/components/diff_line_note_form.vue @@ -206,6 +206,7 @@ export default { ); }, updateStartLine(line) { + this.commentLineStart = line; this.lines.start = line; }, }, @@ -216,7 +217,6 @@ export default {
({ + page: mrPageModule(), + notes: notesModule(), + diffs: diffsModule(), + batchComments: batchCommentsModule(), +}); + export const createStore = () => new Vuex.Store({ - modules: { - page: mrPageModule(), - notes: notesModule(), - diffs: diffsModule(), - batchComments: batchCommentsModule(), - }, + modules: createModules(), }); export default createStore(); diff --git a/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_item.vue b/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_item.vue index 92817d5fa70..70cac061ca6 100644 --- a/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_item.vue +++ b/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_item.vue @@ -14,12 +14,12 @@ export default { diff --git a/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_select_root.vue b/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_select_root.vue index 6b79883d76b..e567040bc51 100644 --- a/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_select_root.vue +++ b/app/assets/javascripts/vue_shared/components/color_select_dropdown/color_select_root.vue @@ -1,4 +1,5 @@